From: "Bae, Chang Seok" <chang.seok.bae@intel.com>
To: Andy Lutomirski <luto@kernel.org>
Cc: "H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@kernel.org>, Andi Kleen <ak@linux.intel.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
"Metzger, Markus T" <markus.t.metzger@intel.com>,
"Shankar, Ravi V" <ravi.v.shankar@intel.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 8/8] x86/vdso: Move out the CPU number store
Date: Wed, 6 Jun 2018 22:59:53 +0000 [thread overview]
Message-ID: <620DB16F-FED8-4CE6-A93A-FA110A28F4A1@intel.com> (raw)
In-Reply-To: <1D572EBD-5B82-4828-AE3E-8CB9E1FA054E@intel.com>
> On Wed, Jun 6, 2018 at 10:25 AM Andy Lutomirski <luto@kernel.org> wrote:
>> On Wed, Jun 6, 2018 at 9:23 AM Chang S. Bae <chang.seok.bae@intel.com> wrote:
>> +static inline void setup_cpu_number_segment(int cpu)
>> +{
>> +#ifdef CONFIG_NUMA
>> + unsigned long node = early_cpu_to_node(cpu);
>> +#else
>> + unsigned long node = 0;
>> +#endif
> This duplicates half the rdtscp_aux code. How about making this one
> function setup_cpu_number() that does all of it?
Looks like the segment setup done during early boot (single-threaded).
So, separating MSR TSC_AUX setup out to each CPU initialization seems
to be still reasonable to me.
Thanks,
Chang
prev parent reply other threads:[~2018-06-06 23:00 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-06 16:23 [PATCH v2 0/8] x86: infrastructure to enable FSGSBASE Chang S. Bae
2018-06-06 16:23 ` [PATCH v2 1/8] x86/fsgsbase/64: Introduce FS/GS base helper functions Chang S. Bae
2018-06-06 16:23 ` [PATCH v2 2/8] x86/fsgsbase/64: Make ptrace read FS/GS base accurately Chang S. Bae
2018-06-06 16:23 ` [PATCH v2 3/8] x86/fsgsbase/64: Use FS/GS base helpers in core dump Chang S. Bae
2018-06-06 16:23 ` [PATCH v2 4/8] x86/fsgsbase/64: Factor out load FS/GS segments from __switch_to Chang S. Bae
2018-06-06 16:23 ` [PATCH v2 5/8] x86/msr: write_rdtscp_aux() to use wrmsr_safe() Chang S. Bae
2018-06-06 17:11 ` Andy Lutomirski
2018-06-06 16:23 ` [PATCH v2 6/8] x86/segments/64: Rename PER_CPU segment to CPU_NUMBER Chang S. Bae
2018-06-06 17:16 ` Andy Lutomirski
2018-06-06 16:23 ` [PATCH v2 7/8] x86/segments/32: Introduce CPU_NUMBER segment Chang S. Bae
2018-06-06 17:16 ` Andy Lutomirski
2018-06-06 19:07 ` Brian Gerst
2018-06-06 19:24 ` Andy Lutomirski
2018-06-06 22:53 ` hpa
2018-06-06 16:23 ` [PATCH v2 8/8] x86/vdso: Move out the CPU number store Chang S. Bae
2018-06-06 17:25 ` Andy Lutomirski
2018-06-06 18:27 ` Bae, Chang Seok
2018-06-06 22:59 ` Bae, Chang Seok [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=620DB16F-FED8-4CE6-A93A-FA110A28F4A1@intel.com \
--to=chang.seok.bae@intel.com \
--cc=ak@linux.intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=markus.t.metzger@intel.com \
--cc=mingo@kernel.org \
--cc=ravi.v.shankar@intel.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®