* [PATCH] erofs: remove unnecessary goto
@ 2023-06-15 3:45 Yangtao Li
2023-06-15 4:01 ` Gao Xiang
2023-06-15 4:20 ` Jingbo Xu
0 siblings, 2 replies; 3+ messages in thread
From: Yangtao Li @ 2023-06-15 3:45 UTC (permalink / raw)
To: Gao Xiang, Chao Yu, Yue Hu, Jeffle Xu
Cc: Yangtao Li, linux-erofs, linux-kernel
It's redundant, let's remove it.
Signed-off-by: Yangtao Li <frank.li@vivo.com>
---
fs/erofs/super.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/fs/erofs/super.c b/fs/erofs/super.c
index 811ab66d805e..f48ce692094d 100644
--- a/fs/erofs/super.c
+++ b/fs/erofs/super.c
@@ -1016,10 +1016,8 @@ static int __init erofs_module_init(void)
sizeof(struct erofs_inode), 0,
SLAB_RECLAIM_ACCOUNT,
erofs_inode_init_once);
- if (!erofs_inode_cachep) {
- err = -ENOMEM;
- goto icache_err;
- }
+ if (!erofs_inode_cachep)
+ return -ENOMEM;
err = erofs_init_shrinker();
if (err)
@@ -1054,7 +1052,6 @@ static int __init erofs_module_init(void)
erofs_exit_shrinker();
shrinker_err:
kmem_cache_destroy(erofs_inode_cachep);
-icache_err:
return err;
}
--
2.39.0
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] erofs: remove unnecessary goto
2023-06-15 3:45 [PATCH] erofs: remove unnecessary goto Yangtao Li
@ 2023-06-15 4:01 ` Gao Xiang
2023-06-15 4:20 ` Jingbo Xu
1 sibling, 0 replies; 3+ messages in thread
From: Gao Xiang @ 2023-06-15 4:01 UTC (permalink / raw)
To: Yangtao Li, Gao Xiang, Chao Yu, Yue Hu, Jeffle Xu
Cc: linux-erofs, linux-kernel
On 2023/6/15 11:45, Yangtao Li wrote:
> It's redundant, let's remove it.
>
> Signed-off-by: Yangtao Li <frank.li@vivo.com>
Reviewed-by: Gao Xiang <hsiangkao@linux.alibaba.com>
Thanks,
Gao Xiang
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] erofs: remove unnecessary goto
2023-06-15 3:45 [PATCH] erofs: remove unnecessary goto Yangtao Li
2023-06-15 4:01 ` Gao Xiang
@ 2023-06-15 4:20 ` Jingbo Xu
1 sibling, 0 replies; 3+ messages in thread
From: Jingbo Xu @ 2023-06-15 4:20 UTC (permalink / raw)
To: Yangtao Li, Gao Xiang, Chao Yu, Yue Hu; +Cc: linux-erofs, linux-kernel
On 6/15/23 11:45 AM, Yangtao Li wrote:
> It's redundant, let's remove it.
>
> Signed-off-by: Yangtao Li <frank.li@vivo.com>
Reviewed-by: Jingbo Xu <jefflexu@linux.alibaba.com>
> ---
> fs/erofs/super.c | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/fs/erofs/super.c b/fs/erofs/super.c
> index 811ab66d805e..f48ce692094d 100644
> --- a/fs/erofs/super.c
> +++ b/fs/erofs/super.c
> @@ -1016,10 +1016,8 @@ static int __init erofs_module_init(void)
> sizeof(struct erofs_inode), 0,
> SLAB_RECLAIM_ACCOUNT,
> erofs_inode_init_once);
> - if (!erofs_inode_cachep) {
> - err = -ENOMEM;
> - goto icache_err;
> - }
> + if (!erofs_inode_cachep)
> + return -ENOMEM;
>
> err = erofs_init_shrinker();
> if (err)
> @@ -1054,7 +1052,6 @@ static int __init erofs_module_init(void)
> erofs_exit_shrinker();
> shrinker_err:
> kmem_cache_destroy(erofs_inode_cachep);
> -icache_err:
> return err;
> }
>
--
Thanks,
Jingbo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-06-15 4:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-15 3:45 [PATCH] erofs: remove unnecessary goto Yangtao Li
2023-06-15 4:01 ` Gao Xiang
2023-06-15 4:20 ` Jingbo Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®