* [PATCH] libata: disable LPM for WDC WD20EFAX-68FB5N0 hard drive
@ 2025-04-23 17:21 Mikko Juhani Korhonen
2025-04-24 5:44 ` Damien Le Moal
0 siblings, 1 reply; 4+ messages in thread
From: Mikko Juhani Korhonen @ 2025-04-23 17:21 UTC (permalink / raw)
To: Damien Le Moal, Niklas Cassel, linux-ide, linux-kernel
Make WDC WD20EFAX-68FB5N0 hard drive work again
after regression in 6.9.0 when LPM was enabled,
so disable it for this model.
Signed-off-by: Mikko Korhonen <mjkorhon@gmail.com>
diff -u linux-6.14.3/drivers/ata/libata-core.c
linux-6.14.3-mk/drivers/ata/libata-core.c
--- linux-6.14.3/drivers/ata/libata-core.c 2025-04-20
11:23:22.000000000 +0300
+++ linux-6.14.3-mk/drivers/ata/libata-core.c 2025-04-22
16:53:52.341934384 +0300
@@ -4238,6 +4238,11 @@
{ "WDC WD2500JD-*", NULL, ATA_QUIRK_WD_BROKEN_LPM },
{ "WDC WD3000JD-*", NULL, ATA_QUIRK_WD_BROKEN_LPM },
{ "WDC WD3200JD-*", NULL, ATA_QUIRK_WD_BROKEN_LPM },
+
+ /*
+ * This specific WD SATA-3 model has problems with LPM.
+ */
+ { "WDC WD20EFAX-68FB5N0", NULL, ATA_QUIRK_NOLPM },
/*
* This sata dom device goes on a walkabout when the ATA_LOG_DIRECTORY
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] libata: disable LPM for WDC WD20EFAX-68FB5N0 hard drive
2025-04-23 17:21 [PATCH] libata: disable LPM for WDC WD20EFAX-68FB5N0 hard drive Mikko Juhani Korhonen
@ 2025-04-24 5:44 ` Damien Le Moal
2025-04-24 20:43 ` [PATCH v2] ata: libata: disable LPM for WDC WD20EFAX-68FB5N0 hard drives Mikko Juhani Korhonen
0 siblings, 1 reply; 4+ messages in thread
From: Damien Le Moal @ 2025-04-24 5:44 UTC (permalink / raw)
To: Mikko Juhani Korhonen, Niklas Cassel, linux-ide, linux-kernel
On 4/24/25 02:21, Mikko Juhani Korhonen wrote:
> Make WDC WD20EFAX-68FB5N0 hard drive work again
> after regression in 6.9.0 when LPM was enabled,
> so disable it for this model.
>
> Signed-off-by: Mikko Korhonen <mjkorhon@gmail.com>
>
> diff -u linux-6.14.3/drivers/ata/libata-core.c
> linux-6.14.3-mk/drivers/ata/libata-core.c
> --- linux-6.14.3/drivers/ata/libata-core.c 2025-04-20
> 11:23:22.000000000 +0300
> +++ linux-6.14.3-mk/drivers/ata/libata-core.c 2025-04-22
> 16:53:52.341934384 +0300
> @@ -4238,6 +4238,11 @@
> { "WDC WD2500JD-*", NULL, ATA_QUIRK_WD_BROKEN_LPM },
> { "WDC WD3000JD-*", NULL, ATA_QUIRK_WD_BROKEN_LPM },
> { "WDC WD3200JD-*", NULL, ATA_QUIRK_WD_BROKEN_LPM },
> +
> + /*
> + * This specific WD SATA-3 model has problems with LPM.
> + */
> + { "WDC WD20EFAX-68FB5N0", NULL, ATA_QUIRK_NOLPM },
>
> /*
> * This sata dom device goes on a walkabout when the ATA_LOG_DIRECTORY
This looks OK but the patch seems broken (missing separator after sign-off so
this does not apply.
Please use "git format-patch" to generate proper patches.
Also please change the patch title to:
ata: libata: disable LPM for WDC WD20EFAX-68FB5N0 hard drives
--
Damien Le Moal
Western Digital Research
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH v2] ata: libata: disable LPM for WDC WD20EFAX-68FB5N0 hard drives
2025-04-24 5:44 ` Damien Le Moal
@ 2025-04-24 20:43 ` Mikko Juhani Korhonen
2025-04-25 1:14 ` Damien Le Moal
0 siblings, 1 reply; 4+ messages in thread
From: Mikko Juhani Korhonen @ 2025-04-24 20:43 UTC (permalink / raw)
To: Damien Le Moal; +Cc: Niklas Cassel, linux-ide, linux-kernel
Make WDC WD20EFAX-68FB5N0 hard drive work again
after regression in 6.9.0 when LPM was enabled,
so disable it for this model
Signed-off-by: Mikko Korhonen <mjkorhon@gmail.com>
---
drivers/ata/libata-core.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index d956735e2a76..c429ba259548 100644
--- a/drivers/ata/libata-core.c
+++ b/drivers/ata/libata-core.c
@@ -4208,6 +4208,11 @@ static const struct ata_dev_quirks_entry
__ata_dev_quirks[] = {
{ "WDC WD3000JD-*", NULL, ATA_QUIRK_WD_BROKEN_LPM },
{ "WDC WD3200JD-*", NULL, ATA_QUIRK_WD_BROKEN_LPM },
+ /*
+ * This specific WD SATA-3 model has problems with LPM.
+ */
+ { "WDC WD20EFAX-68FB5N0", NULL, ATA_QUIRK_NOLPM },
+
/*
* This sata dom device goes on a walkabout when the ATA_LOG_DIRECTORY
* log page is accessed. Ensure we never ask for this log page with
base-commit: 38fec10eb60d687e30c8c6b5420d86e8149f7557
--
2.47.2
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v2] ata: libata: disable LPM for WDC WD20EFAX-68FB5N0 hard drives
2025-04-24 20:43 ` [PATCH v2] ata: libata: disable LPM for WDC WD20EFAX-68FB5N0 hard drives Mikko Juhani Korhonen
@ 2025-04-25 1:14 ` Damien Le Moal
0 siblings, 0 replies; 4+ messages in thread
From: Damien Le Moal @ 2025-04-25 1:14 UTC (permalink / raw)
To: Mikko Juhani Korhonen; +Cc: Niklas Cassel, linux-ide, linux-kernel
On 4/25/25 05:43, Mikko Juhani Korhonen wrote:
> Make WDC WD20EFAX-68FB5N0 hard drive work again
> after regression in 6.9.0 when LPM was enabled,
> so disable it for this model
>
> Signed-off-by: Mikko Korhonen <mjkorhon@gmail.com>
I still cannot apply this. I get the errors:
error: corrupt patch at line 10
error: could not build fake ancestor
Your base-commit is Linus tag for Linux 6.14, which is not appropriate for new
patches. Please rebase this on libata for-6.15-fixes branch or Linus latest tree.
Also please properly format you commit message to use up to 72 characters per
line. And terminate your sentence with a period please.
> ---
> drivers/ata/libata-core.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
> index d956735e2a76..c429ba259548 100644
> --- a/drivers/ata/libata-core.c
> +++ b/drivers/ata/libata-core.c
> @@ -4208,6 +4208,11 @@ static const struct ata_dev_quirks_entry
> __ata_dev_quirks[] = {
> { "WDC WD3000JD-*", NULL, ATA_QUIRK_WD_BROKEN_LPM },
> { "WDC WD3200JD-*", NULL, ATA_QUIRK_WD_BROKEN_LPM },
>
> + /*
> + * This specific WD SATA-3 model has problems with LPM.
> + */
> + { "WDC WD20EFAX-68FB5N0", NULL, ATA_QUIRK_NOLPM },
> +
> /*
> * This sata dom device goes on a walkabout when the ATA_LOG_DIRECTORY
> * log page is accessed. Ensure we never ask for this log page with
>
> base-commit: 38fec10eb60d687e30c8c6b5420d86e8149f7557
> --
> 2.47.2
--
Damien Le Moal
Western Digital Research
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-04-25 1:14 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-04-23 17:21 [PATCH] libata: disable LPM for WDC WD20EFAX-68FB5N0 hard drive Mikko Juhani Korhonen
2025-04-24 5:44 ` Damien Le Moal
2025-04-24 20:43 ` [PATCH v2] ata: libata: disable LPM for WDC WD20EFAX-68FB5N0 hard drives Mikko Juhani Korhonen
2025-04-25 1:14 ` Damien Le Moal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®