From: Krzysztof Kozlowski <krzk@kernel.org>
To: Loic Poulain <loic.poulain@oss.qualcomm.com>
Cc: Nihal Kumar Gupta <nihal.gupta@oss.qualcomm.com>,
Bryan O'Donoghue <bod@kernel.org>,
Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Suresh Vankadara <svankada@qti.qualcomm.com>,
Vikram Sharma <vikram.sharma@oss.qualcomm.com>
Subject: Re: [PATCH 1/2] dt-bindings: media: qcom,glymur-camss: Use CSIPHY indices for ports
Date: Thu, 5 Nov 2026 14:21:34 +0100 [thread overview]
Message-ID: <62fba00d-831c-44cc-8d3e-083a95abfbe8@kernel.org> (raw)
In-Reply-To: <CAFEp6-1fSPP41cVFmu8=0z2xibDpHuH5Lxrw7W_rvnt+Fw9EpA@mail.gmail.com>
On 05/11/2026 13:04, Loic Poulain wrote:
> On Thu, Nov 5, 2026 at 11:45 AM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>>
>> On 05/11/2026 10:53, Loic Poulain wrote:
>>> So some chipsets share the same IP blocks, with some block/phy
>>> instances disabled. As a result, we need to decide whether we're
>>> numbering based on active instances or on the actual hardware instance
>>> index/offset. If we use active-instance numbering, then yes, it should
>>> be @2 (CSIPHY4 being the third active instance). Alternatively, if the
>>> port numbering is intended to reflect the hardware instance offset,
>>> matching the register prop, then @4 would be more appropriate. It also
>>> has the advantage of directly identifying the underlying hardware
>>> instance, without requiring any additional driver-side mapping. In any
>>> case, @3 is incorrect.
>>>
>>> That said, since the bindings have already been merged in its current
>>> form, we'll need to preserve backward compatibility when addressing
>>> this.
>>
>> This is the input port to camss, so how is it called in camss, not the
>> csi phy?
>
> The CSIPHYs are connected to the CAMSS input ports, which can then be
> multiplexed and routed to different CSIDs. The mux identifies its PHY
> inputs using the hardware PHY IDs, so the CSIPHY4 is identified as the
> CAMSS PHY4 input. In this configuration, PHY2 and PHY3 inputs are not
> connected.
I could not find that information in Glymur HPG, but maybe I looked
wrong. CSID Wrapper lists CSID 0-2, not 0, 1 and 4, but again maybe I am
looking at wrong device description/interface...
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-11-05 13:21 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-02 8:50 [PATCH 0/2] media: qcom: camss: Use Glymur graph ports as CSIPHY IDs Nihal Kumar Gupta
2026-11-02 8:50 ` [PATCH 1/2] dt-bindings: media: qcom,glymur-camss: Use CSIPHY indices for ports Nihal Kumar Gupta
2026-11-04 13:52 ` Krzysztof Kozlowski
2026-11-04 16:00 ` Nihal Kumar Gupta
2026-11-04 16:12 ` Krzysztof Kozlowski
2026-11-05 5:32 ` Nihal Kumar Gupta
2026-11-05 7:33 ` Krzysztof Kozlowski
2026-11-05 9:18 ` Nihal Kumar Gupta
2026-11-05 9:23 ` Krzysztof Kozlowski
2026-11-05 9:53 ` Loic Poulain
2026-11-05 10:15 ` Bryan O'Donoghue
2026-11-05 10:45 ` Krzysztof Kozlowski
2026-11-05 11:03 ` Bryan O'Donoghue
2026-11-05 12:04 ` Loic Poulain
2026-11-05 13:21 ` Krzysztof Kozlowski [this message]
2026-11-05 14:01 ` Loic Poulain
2026-11-02 8:50 ` [PATCH 2/2] media: qcom: camss: Add Glymur specific resources Nihal Kumar Gupta
2026-11-04 13:54 ` Krzysztof Kozlowski
2026-11-04 16:01 ` Nihal Kumar Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=62fba00d-831c-44cc-8d3e-083a95abfbe8@kernel.org \
--to=krzk@kernel.org \
--cc=bod@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=loic.poulain@oss.qualcomm.com \
--cc=mchehab@kernel.org \
--cc=nihal.gupta@oss.qualcomm.com \
--cc=robh@kernel.org \
--cc=svankada@qti.qualcomm.com \
--cc=vikram.sharma@oss.qualcomm.com \
--cc=vladimir.zapolskiy@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®