From: Jay Dolan <jay.dolan@accesio.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
Jiri Slaby <jirislaby@kernel.org>
Subject: Re: [PATCH v1 0/2] serial: 8250_pci: Split Pericom driver
Date: Fri, 19 Nov 2021 06:33:38 -0800 [thread overview]
Message-ID: <633bbad1-7b13-7299-a570-2bf1a87c47a5@accesio.com> (raw)
In-Reply-To: <YZdfAdOcH2Bn1K+W@smile.fi.intel.com>
On 11/19/21 12:23 AM, Andy Shevchenko wrote:
> On Thu, Nov 18, 2021 at 10:32:51PM -0800, Jay Dolan wrote:
>> On 11/17/21 6:57 AM, Andy Shevchenko wrote:
>>> Split Pericom driver to a separate module.
>>> While at it, re-enable high baud rates.
>>>
>>> Jay, can you, please, test this on as many hardware as you have?
>>>
>>> The series depends on the fix-series: https://lore.kernel.org/linux-serial/20211117145502.43645-1-andriy.shevchenko@linux.intel.com/T/#u
>
>> I have my current state here: https://github.com/accesio/linux/blob/split-pericom-driver/drivers/tty/serial/8250/8250_pericom.c
>>
>> * Change port type to UPIO_PORT
>> * Add in pericom_do_startup() because the UPF_MAGIC_MULTIPLIER doesn't
>> stick.
>
> Thanks, I have updated my local tree with these changes.
>
>> When I'm testing baud rates greater than baud_base I'm seeing strange things
>> on the scope.
>
> Can you confirm that there are no issues with the first (fixes) series?
Yes. The fixes series has no issues, and was tested up to baud_base for
both 14 and 24 MHz crystals.
> I have slightly changed your set_divisor() refactoring, it may be that issue
> is there.
>
>> Maybe I'm just tired, and it's human error. I should be able
>> to get back to it and get it done on Saturday.
>
> Thank you.
>
next prev parent reply other threads:[~2021-11-19 14:33 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-17 14:57 Andy Shevchenko
2021-11-17 14:57 ` [PATCH v1 1/2] serial: 8250_pci: Split out " Andy Shevchenko
2021-11-18 1:12 ` Jay Dolan
2021-11-18 9:50 ` Andy Shevchenko
2021-11-18 14:45 ` Jay Dolan
2021-11-17 14:57 ` [PATCH v1 2/2] serial: 8250_pericom: Re-enable higher baud rates Andy Shevchenko
2021-11-19 6:32 ` [PATCH v1 0/2] serial: 8250_pci: Split Pericom driver Jay Dolan
2021-11-19 8:23 ` Andy Shevchenko
2021-11-19 14:33 ` Jay Dolan [this message]
2021-11-20 21:05 ` Jay Dolan
2021-11-21 10:16 ` Andy Shevchenko
2021-11-21 15:36 ` Jay Dolan
2021-11-22 12:47 ` Andy Shevchenko
2021-11-22 12:48 ` Andy Shevchenko
2021-11-23 5:19 ` Jay Dolan
2021-11-23 9:25 ` Andy Shevchenko
2021-11-23 15:02 ` Jay Dolan
2021-11-23 15:38 ` Andy Shevchenko
2021-11-24 4:29 ` Jay Dolan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=633bbad1-7b13-7299-a570-2bf1a87c47a5@accesio.com \
--to=jay.dolan@accesio.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®