From: Jay Dolan <jay.dolan@accesio.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
Jiri Slaby <jirislaby@kernel.org>
Subject: Re: [PATCH v1 0/2] serial: 8250_pci: Split Pericom driver
Date: Mon, 22 Nov 2021 21:19:09 -0800 [thread overview]
Message-ID: <ede18fd7-266e-406d-0c9c-570d95ab3673@accesio.com> (raw)
In-Reply-To: <YZuRnSaZz04KJIDk@smile.fi.intel.com>
On 11/22/21 4:48 AM, Andy Shevchenko wrote:
> On Mon, Nov 22, 2021 at 02:47:20PM +0200, Andy Shevchenko wrote:
>> On Thu, Nov 18, 2021 at 10:32:51PM -0800, Jay Dolan wrote:
>>> On 11/17/21 6:57 AM, Andy Shevchenko wrote:
>>>> Split Pericom driver to a separate module.
>>>> While at it, re-enable high baud rates.
>>>>
>>>> Jay, can you, please, test this on as many hardware as you have?
>>
>> ...
>>
>>> * Add in pericom_do_startup() because the UPF_MAGIC_MULTIPLIER doesn't
>>> stick.
>>
>> Can't find an evidence that this is the case. Can you recheck this (reading
>> flags back via sysfs or so)? So, for v2 I'll leave my approach.
>
> Otherwise how the other drivers which are using that flag survive? If it's
> indeed an issue, it should be fixed on generic level.
>
I modified pericom_do_startup to log when the UPF_MAGIC_MULTIPLIER flag
was present. Then tried to set the port to 3000000 a few times. The port
stayed at 9600. It looks like pericom_do_startup() is getting called
twice per port on boot, and the flag is gone with the second one.
[ 4.925577] [J4D] flag present
[ 4.926121] [J4D[ flag not present
[ 4.926843] [J4D] flag present
[ 4.927415] [J4D[ flag not present
[ 4.928106] [J4D] flag present
[ 4.928673] [J4D[ flag not present
[ 4.929419] [J4D] flag present
[ 4.930447] [J4D[ flag not present
[ 49.528504] [J4D[ flag not present
[ 51.675240] [J4D[ flag not present
[ 59.617954] [J4D[ flag not present
Then I modified it to log when it was adding the flag in. The port was
set to 3000000. Also the flag only needed to be added in once. It sticks
after the first time.
[ 4.647546] [J4D] flag present
[ 4.648119] [J4D] flag not present(adding)
[ 4.648778] [J4D] flag present
[ 4.649330] [J4D] flag not present(adding)
[ 4.650001] [J4D] flag present
[ 4.650537] [J4D] flag not present(adding)
[ 4.651192] [J4D] flag present
[ 4.651718] [J4D] flag not present(adding)
[ 96.025668] [J4D] flag present
[ 100.130626] [J4D] flag present
[ 116.435436] [J4D] flag present
I mostly just guessed at do_startup() being the place to set the magic
multiplier flag after it didn't stick in quirk in 8250_pci.c.
next prev parent reply other threads:[~2021-11-23 5:19 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-17 14:57 Andy Shevchenko
2021-11-17 14:57 ` [PATCH v1 1/2] serial: 8250_pci: Split out " Andy Shevchenko
2021-11-18 1:12 ` Jay Dolan
2021-11-18 9:50 ` Andy Shevchenko
2021-11-18 14:45 ` Jay Dolan
2021-11-17 14:57 ` [PATCH v1 2/2] serial: 8250_pericom: Re-enable higher baud rates Andy Shevchenko
2021-11-19 6:32 ` [PATCH v1 0/2] serial: 8250_pci: Split Pericom driver Jay Dolan
2021-11-19 8:23 ` Andy Shevchenko
2021-11-19 14:33 ` Jay Dolan
2021-11-20 21:05 ` Jay Dolan
2021-11-21 10:16 ` Andy Shevchenko
2021-11-21 15:36 ` Jay Dolan
2021-11-22 12:47 ` Andy Shevchenko
2021-11-22 12:48 ` Andy Shevchenko
2021-11-23 5:19 ` Jay Dolan [this message]
2021-11-23 9:25 ` Andy Shevchenko
2021-11-23 15:02 ` Jay Dolan
2021-11-23 15:38 ` Andy Shevchenko
2021-11-24 4:29 ` Jay Dolan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ede18fd7-266e-406d-0c9c-570d95ab3673@accesio.com \
--to=jay.dolan@accesio.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®