mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Shuah Khan <shuah@kernel.org>
To: julien.boibessot@free.fr,
	Valentina Manea <valentina.manea.m@gmail.com>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Julien BOIBESSOT <julien.boibessot@armadeus.com>,
	Shuah Khan <shuahkh@osg.samsung.com>
Subject: Re: [PATCH] tools/usbip: fixes build with musl libc toolchain
Date: Wed, 6 Dec 2017 11:17:51 -0700	[thread overview]
Message-ID: <6378931e-57f5-0960-9a88-53bcfbf8dc69@kernel.org> (raw)
In-Reply-To: <1512496094-8940-1-git-send-email-julien.boibessot@free.fr>

On 12/05/2017 10:48 AM, julien.boibessot@free.fr wrote:
> From: Julien BOIBESSOT <julien.boibessot@armadeus.com>
> 
> Indeed musl doesn't define old SIGCLD signal name but only new one SIGCHLD.
> SIGCHLD is the new POSIX name for that signal so it doesn't change
> anything on other libcs.
> 
> This fixes this kind of build error:
> 
> usbipd.c: In function ‘set_signal’:
> usbipd.c:459:12: error: 'SIGCLD' undeclared (first use in this function)
>   sigaction(SIGCLD, &act, NULL);
>             ^~~~~~
> usbipd.c:459:12: note: each undeclared identifier is reported only once
> 	for each function it appears in
> Makefile:407: recipe for target 'usbipd.o' failed
> make[3]: *** [usbipd.o] Error 1
> 
> Signed-off-by: Julien BOIBESSOT <julien.boibessot@armadeus.com>
> ---

Thanks for the patch.

Greg,

Please pick this up.

Acked-by: Shuah Khan <shuahkh@osg.samsung.com>

thanks,
-- Shuah

      reply	other threads:[~2017-12-06 18:18 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-05 17:48 julien.boibessot
2017-12-06 18:17 ` Shuah Khan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6378931e-57f5-0960-9a88-53bcfbf8dc69@kernel.org \
    --to=shuah@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=julien.boibessot@armadeus.com \
    --cc=julien.boibessot@free.fr \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=shuahkh@osg.samsung.com \
    --cc=valentina.manea.m@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®