[PATCH] tools/usbip: fixes build with musl libc toolchain

[PATCH] tools/usbip: fixes build with musl libc toolchain

[julien.boibessot]

From: Julien BOIBESSOT <julien.boibessot@armadeus.com>

Indeed musl doesn't define old SIGCLD signal name but only new one SIGCHLD.
SIGCHLD is the new POSIX name for that signal so it doesn't change
anything on other libcs.

This fixes this kind of build error:

usbipd.c: In function ‘set_signal’:
usbipd.c:459:12: error: 'SIGCLD' undeclared (first use in this function)
  sigaction(SIGCLD, &act, NULL);
            ^~~~~~
usbipd.c:459:12: note: each undeclared identifier is reported only once
	for each function it appears in
Makefile:407: recipe for target 'usbipd.o' failed
make[3]: *** [usbipd.o] Error 1

Signed-off-by: Julien BOIBESSOT <julien.boibessot@armadeus.com>
---
 tools/usb/usbip/src/usbipd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/usb/usbip/src/usbipd.c b/tools/usb/usbip/src/usbipd.c
index 009afb4..c6dad2a 100644
--- a/tools/usb/usbip/src/usbipd.c
+++ b/tools/usb/usbip/src/usbipd.c
@@ -456,7 +456,7 @@ static void set_signal(void)
 	sigaction(SIGTERM, &act, NULL);
 	sigaction(SIGINT, &act, NULL);
 	act.sa_handler = SIG_IGN;
-	sigaction(SIGCLD, &act, NULL);
+	sigaction(SIGCHLD, &act, NULL);
 }
 
 static const char *pid_file;
-- 
2.1.4

Re: [PATCH] tools/usbip: fixes build with musl libc toolchain

[Shuah Khan]

On 12/05/2017 10:48 AM, julien.boibessot@free.fr wrote:
> From: Julien BOIBESSOT <julien.boibessot@armadeus.com>
> 
> Indeed musl doesn't define old SIGCLD signal name but only new one SIGCHLD.
> SIGCHLD is the new POSIX name for that signal so it doesn't change
> anything on other libcs.
> 
> This fixes this kind of build error:
> 
> usbipd.c: In function ‘set_signal’:
> usbipd.c:459:12: error: 'SIGCLD' undeclared (first use in this function)
>   sigaction(SIGCLD, &act, NULL);
>             ^~~~~~
> usbipd.c:459:12: note: each undeclared identifier is reported only once
> 	for each function it appears in
> Makefile:407: recipe for target 'usbipd.o' failed
> make[3]: *** [usbipd.o] Error 1
> 
> Signed-off-by: Julien BOIBESSOT <julien.boibessot@armadeus.com>
> ---

Thanks for the patch.

Greg,

Please pick this up.

Acked-by: Shuah Khan <shuahkh@osg.samsung.com>

thanks,
-- Shuah