mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] soc: mediatek: cmdq: Don't log an error when gce-client-reg is not found
@ 2024-02-26 21:31 Nícolas F. R. A. Prado
  2024-02-28  9:41 ` AngeloGioacchino Del Regno
  0 siblings, 1 reply; 4+ messages in thread
From: Nícolas F. R. A. Prado @ 2024-02-26 21:31 UTC (permalink / raw)
  To: Matthias Brugger, AngeloGioacchino Del Regno
  Cc: kernel, linux-kernel, linux-arm-kernel, linux-mediatek,
	Nícolas F. R. A. Prado

Most of the callers to this function do not require CMDQ support, it is
optional, so the missing property shouldn't cause an error message.
Furthermore, the callers that do require CMDQ support already log at the
error level when an error is returned.

Change the log message in this helper to be printed at the debug level
instead.

Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
---
 drivers/soc/mediatek/mtk-cmdq-helper.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/soc/mediatek/mtk-cmdq-helper.c b/drivers/soc/mediatek/mtk-cmdq-helper.c
index b0cd071c4719..2130ff3aac9e 100644
--- a/drivers/soc/mediatek/mtk-cmdq-helper.c
+++ b/drivers/soc/mediatek/mtk-cmdq-helper.c
@@ -55,7 +55,7 @@ int cmdq_dev_get_client_reg(struct device *dev,
 					       "mediatek,gce-client-reg",
 					       3, idx, &spec);
 	if (err < 0) {
-		dev_err(dev,
+		dev_dbg(dev,
 			"error %d can't parse gce-client-reg property (%d)",
 			err, idx);
 

---
base-commit: 41913bcddc83b131649ee8ff0d9ff29e01731398
change-id: 20240226-gce-client-reg-log-dbg-5ae9637a08ed

Best regards,
-- 
Nícolas F. R. A. Prado <nfraprado@collabora.com>


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2024-02-28 14:48 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-02-26 21:31 [PATCH] soc: mediatek: cmdq: Don't log an error when gce-client-reg is not found Nícolas F. R. A. Prado
2024-02-28  9:41 ` AngeloGioacchino Del Regno
2024-02-28 14:44   ` Nícolas F. R. A. Prado
2024-02-28 14:48     ` AngeloGioacchino Del Regno

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®