From: Andrew Lunn <andrew@lunn.ch>
To: Haiyang Zhang <haiyangz@microsoft.com>
Cc: Jakub Kicinski <kuba@kernel.org>,
Erni Sri Satya Vennela <ernis@linux.microsoft.com>,
KY Srinivasan <kys@microsoft.com>,
"wei.liu@kernel.org" <wei.liu@kernel.org>,
Dexuan Cui <decui@microsoft.com>,
"andrew+netdev@lunn.ch" <andrew+netdev@lunn.ch>,
"davem@davemloft.net" <davem@davemloft.net>,
"edumazet@google.com" <edumazet@google.com>,
"pabeni@redhat.com" <pabeni@redhat.com>,
Long Li <longli@microsoft.com>,
Konstantin Taranov <kotaranov@microsoft.com>,
"horms@kernel.org" <horms@kernel.org>,
"brett.creeley@amd.com" <brett.creeley@amd.com>,
"surenb@google.com" <surenb@google.com>,
"schakrabarti@linux.microsoft.com"
<schakrabarti@linux.microsoft.com>,
"kent.overstreet@linux.dev" <kent.overstreet@linux.dev>,
"shradhagupta@linux.microsoft.com"
<shradhagupta@linux.microsoft.com>,
"erick.archer@outlook.com" <erick.archer@outlook.com>,
"rosenp@gmail.com" <rosenp@gmail.com>,
"linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
Paul Rosswurm <paulros@microsoft.com>
Subject: Re: [EXTERNAL] Re: [PATCH 2/3] net: mana: Implement set_link_ksettings in ethtool for speed
Date: Tue, 25 Mar 2025 20:58:54 +0100 [thread overview]
Message-ID: <6396c1f7-756d-476a-833e-7ea35ae41da8@lunn.ch> (raw)
In-Reply-To: <MN0PR21MB3437DA2C43930B08036BB146CAA72@MN0PR21MB3437.namprd21.prod.outlook.com>
> This patch is just to support the ethtool option for the speed.
> And seems there is no option on ethtool to reset NIC to the default
> speed?
There is no such thing as default speed. Speed is either:
1) Negotiated with the link partner, picking the highest speed link
modes both partners support
2) Forced to a specific speed, based on one of the link modes the
interfaces supports.
Since you don't have link modes, you are abusing the API. You should
choose a different API which actually fits what you are doing,
configuring a leaky bucket shaper.
Andrew
next prev parent reply other threads:[~2025-03-25 19:59 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-20 12:22 [PATCH 0/3] Add support for speed in MANA ethtool Erni Sri Satya Vennela
2025-03-20 12:22 ` [PATCH 1/3] net: mana: Add speed support in mana_get_link_ksettings Erni Sri Satya Vennela
2025-03-20 13:37 ` Andrew Lunn
2025-03-24 17:43 ` Erni Sri Satya Vennela
2025-03-24 18:44 ` Andrew Lunn
2025-03-25 16:25 ` Erni Sri Satya Vennela
2025-03-25 16:43 ` Andrew Lunn
2025-03-20 12:22 ` [PATCH 2/3] net: mana: Implement set_link_ksettings in ethtool for speed Erni Sri Satya Vennela
2025-03-20 13:43 ` Andrew Lunn
2025-03-25 17:09 ` Erni Sri Satya Vennela
2025-03-25 17:52 ` Andrew Lunn
2025-03-25 19:21 ` Jakub Kicinski
2025-03-25 19:53 ` [EXTERNAL] " Haiyang Zhang
2025-03-25 19:58 ` Andrew Lunn [this message]
2025-03-25 20:28 ` Haiyang Zhang
2025-03-25 20:38 ` Andrew Lunn
2025-03-31 9:08 ` Erni Sri Satya Vennela
2025-04-17 8:12 ` Erni Sri Satya Vennela
2025-03-20 12:22 ` [PATCH 3/3] net: mana: Handle unsupported HWC commands Erni Sri Satya Vennela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6396c1f7-756d-476a-833e-7ea35ae41da8@lunn.ch \
--to=andrew@lunn.ch \
--cc=andrew+netdev@lunn.ch \
--cc=brett.creeley@amd.com \
--cc=davem@davemloft.net \
--cc=decui@microsoft.com \
--cc=edumazet@google.com \
--cc=erick.archer@outlook.com \
--cc=ernis@linux.microsoft.com \
--cc=haiyangz@microsoft.com \
--cc=horms@kernel.org \
--cc=kent.overstreet@linux.dev \
--cc=kotaranov@microsoft.com \
--cc=kuba@kernel.org \
--cc=kys@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=longli@microsoft.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=paulros@microsoft.com \
--cc=rosenp@gmail.com \
--cc=schakrabarti@linux.microsoft.com \
--cc=shradhagupta@linux.microsoft.com \
--cc=surenb@google.com \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®