From: Paolo Bonzini <pbonzini@redhat.com>
To: Anton Romanov <romanton@google.com>
Cc: Sean Christopherson <seanjc@google.com>,
Vitaly Kuznetsov <vkuznets@redhat.com>,
Wanpeng Li <wanpengli@tencent.com>,
Jim Mattson <jmattson@google.com>, Joerg Roedel <joro@8bytes.org>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
Suleiman Souhlal <suleiman@google.com>
Subject: Re: [PATCH] KVM: x86: Don't snapshot "max" TSC if host TSC is constant
Date: Wed, 13 Apr 2022 10:31:20 +0200 [thread overview]
Message-ID: <64456e38-0994-f2bb-39df-a7614c98c62c@redhat.com> (raw)
In-Reply-To: <CAHFSQMj-Q08Fu1tdPuz+kcdvAoh2cuc_ZgH=qijSet55fxHLNw@mail.gmail.com>
On 4/12/22 19:38, Anton Romanov wrote:
>> Queued, but I'd rather have a subject that calls out that max_tsc_khz
>> needs a replacement at vCPU creation time. In fact, the real change
>> (and bug, and fix) is in kvm_arch_vcpu_create(), while the subject
>> mentions only the change in kvm_timer_init().
>>
>> What do you think of "KVM: x86: Use current rather than max TSC
>> frequency if it is constant"?
>
> Ping. This said "queued" but I don't think this ever landed.
> What's the status of this?
> Paolo, does this need more work?
The features in my second pull request were rejected by Linus so they
will be in 5.19. I'm going to open kvm/next today and the patches will
be there.
Unfortunately he hasn't replied to my rebuttal at
https://lore.kernel.org/kvm/30ffdecc-6ecd-5194-14ec-40e8b818889a@redhat.com/#t
so I have no idea what his opinion is. I'll try to get more stuff in
early for the next releases.
Paolo
next prev parent reply other threads:[~2022-04-13 8:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-25 1:39 Sean Christopherson
2022-02-25 12:10 ` Paolo Bonzini
2022-02-25 12:20 ` David Woodhouse
2022-02-25 16:21 ` Sean Christopherson
2022-02-25 16:34 ` David Woodhouse
2022-04-12 17:38 ` Anton Romanov
2022-04-13 8:31 ` Paolo Bonzini [this message]
2022-02-25 12:52 ` David Woodhouse
2022-02-25 16:40 ` Sean Christopherson
2022-02-25 16:51 ` David Woodhouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=64456e38-0994-f2bb-39df-a7614c98c62c@redhat.com \
--to=pbonzini@redhat.com \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=romanton@google.com \
--cc=seanjc@google.com \
--cc=suleiman@google.com \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®