* [PATCH] fuse: cleanup fuse_wait_on_page_writeback
@ 2019-07-22 7:17 Vasily Averin
2019-07-22 7:18 ` Vasily Averin
2019-08-01 11:03 ` Miklos Szeredi
0 siblings, 2 replies; 3+ messages in thread
From: Vasily Averin @ 2019-07-22 7:17 UTC (permalink / raw)
To: linux-kernel, linux-fsdevel, Miklos Szeredi
From: Maxim Patlasov <mpatlasov@virtuozzo.com>
fuse_wait_on_page_writeback() always returns zero and nobody cares.
Let's make it void.
Signed-off-by: Maxim Patlasov <mpatlasov@virtuozzo.com>
Signed-off-by: Vasily Averin <vvs@virtuozzo.com>
---
fs/fuse/file.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/fs/fuse/file.c b/fs/fuse/file.c
index 5ae2828beb00..e076c2cf65b0 100644
--- a/fs/fuse/file.c
+++ b/fs/fuse/file.c
@@ -383,12 +383,11 @@ static inline bool fuse_page_is_writeback(struct inode *inode, pgoff_t index)
* Since fuse doesn't rely on the VM writeback tracking, this has to
* use some other means.
*/
-static int fuse_wait_on_page_writeback(struct inode *inode, pgoff_t index)
+static void fuse_wait_on_page_writeback(struct inode *inode, pgoff_t index)
{
struct fuse_inode *fi = get_fuse_inode(inode);
wait_event(fi->page_waitq, !fuse_page_is_writeback(inode, index));
- return 0;
}
/*
--
2.17.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] fuse: cleanup fuse_wait_on_page_writeback
2019-07-22 7:17 [PATCH] fuse: cleanup fuse_wait_on_page_writeback Vasily Averin
@ 2019-07-22 7:18 ` Vasily Averin
2019-08-01 11:03 ` Miklos Szeredi
1 sibling, 0 replies; 3+ messages in thread
From: Vasily Averin @ 2019-07-22 7:18 UTC (permalink / raw)
To: linux-kernel, linux-fsdevel, Miklos Szeredi
I forget to add this patch was used in OpenVZ kernels last few years.
On 7/22/19 10:17 AM, Vasily Averin wrote:
> From: Maxim Patlasov <mpatlasov@virtuozzo.com>
> fuse_wait_on_page_writeback() always returns zero and nobody cares.
> Let's make it void.
>
> Signed-off-by: Maxim Patlasov <mpatlasov@virtuozzo.com>
> Signed-off-by: Vasily Averin <vvs@virtuozzo.com>
> ---
> fs/fuse/file.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/fs/fuse/file.c b/fs/fuse/file.c
> index 5ae2828beb00..e076c2cf65b0 100644
> --- a/fs/fuse/file.c
> +++ b/fs/fuse/file.c
> @@ -383,12 +383,11 @@ static inline bool fuse_page_is_writeback(struct inode *inode, pgoff_t index)
> * Since fuse doesn't rely on the VM writeback tracking, this has to
> * use some other means.
> */
> -static int fuse_wait_on_page_writeback(struct inode *inode, pgoff_t index)
> +static void fuse_wait_on_page_writeback(struct inode *inode, pgoff_t index)
> {
> struct fuse_inode *fi = get_fuse_inode(inode);
>
> wait_event(fi->page_waitq, !fuse_page_is_writeback(inode, index));
> - return 0;
> }
>
> /*
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] fuse: cleanup fuse_wait_on_page_writeback
2019-07-22 7:17 [PATCH] fuse: cleanup fuse_wait_on_page_writeback Vasily Averin
2019-07-22 7:18 ` Vasily Averin
@ 2019-08-01 11:03 ` Miklos Szeredi
1 sibling, 0 replies; 3+ messages in thread
From: Miklos Szeredi @ 2019-08-01 11:03 UTC (permalink / raw)
To: Vasily Averin; +Cc: linux-kernel, linux-fsdevel
On Mon, Jul 22, 2019 at 9:17 AM Vasily Averin <vvs@virtuozzo.com> wrote:
>
> From: Maxim Patlasov <mpatlasov@virtuozzo.com>
> fuse_wait_on_page_writeback() always returns zero and nobody cares.
> Let's make it void.
Applied.
Thanks,
Miklos
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-08-01 11:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-22 7:17 [PATCH] fuse: cleanup fuse_wait_on_page_writeback Vasily Averin
2019-07-22 7:18 ` Vasily Averin
2019-08-01 11:03 ` Miklos Szeredi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®