* [PATCH] um: remove unneeded semicolon in um_arch.c
@ 2021-06-19 2:02 Wan Jiabing
2021-06-19 6:41 ` Anton Ivanov
0 siblings, 1 reply; 3+ messages in thread
From: Wan Jiabing @ 2021-06-19 2:02 UTC (permalink / raw)
To: Jeff Dike, Richard Weinberger, Anton Ivanov, Johannes Berg,
Andrew Morton, Nick Desaulniers, Corey Minyard, Thomas Meyer,
Andy Shevchenko, Joe Perches, Wan Jiabing, linux-um,
linux-kernel
Fix following coccicheck warning:
./arch/um/kernel/um_arch.c:284:34-35: Unneeded semicolon
Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
---
arch/um/kernel/um_arch.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/um/kernel/um_arch.c b/arch/um/kernel/um_arch.c
index f9f1463f0521..a149a5e9a16a 100644
--- a/arch/um/kernel/um_arch.c
+++ b/arch/um/kernel/um_arch.c
@@ -281,7 +281,7 @@ static void parse_host_cpu_flags(char *line)
int i;
for (i = 0; i < 32*NCAPINTS; i++) {
if ((x86_cap_flags[i] != NULL) && strstr(line, x86_cap_flags[i]))
- set_cpu_cap(&boot_cpu_data, i);;
+ set_cpu_cap(&boot_cpu_data, i);
}
}
static void parse_cache_line(char *line)
--
2.20.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] um: remove unneeded semicolon in um_arch.c
2021-06-19 2:02 [PATCH] um: remove unneeded semicolon in um_arch.c Wan Jiabing
@ 2021-06-19 6:41 ` Anton Ivanov
2021-06-19 8:04 ` Richard Weinberger
0 siblings, 1 reply; 3+ messages in thread
From: Anton Ivanov @ 2021-06-19 6:41 UTC (permalink / raw)
To: Wan Jiabing, Jeff Dike, Richard Weinberger, Johannes Berg,
Andrew Morton, Nick Desaulniers, Corey Minyard, Thomas Meyer,
Andy Shevchenko, Joe Perches, linux-um, linux-kernel
On 19/06/2021 03:02, Wan Jiabing wrote:
> Fix following coccicheck warning:
> ./arch/um/kernel/um_arch.c:284:34-35: Unneeded semicolon
>
> Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
> ---
> arch/um/kernel/um_arch.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/um/kernel/um_arch.c b/arch/um/kernel/um_arch.c
> index f9f1463f0521..a149a5e9a16a 100644
> --- a/arch/um/kernel/um_arch.c
> +++ b/arch/um/kernel/um_arch.c
> @@ -281,7 +281,7 @@ static void parse_host_cpu_flags(char *line)
> int i;
> for (i = 0; i < 32*NCAPINTS; i++) {
> if ((x86_cap_flags[i] != NULL) && strstr(line, x86_cap_flags[i]))
> - set_cpu_cap(&boot_cpu_data, i);;
> + set_cpu_cap(&boot_cpu_data, i);
> }
> }
> static void parse_cache_line(char *line)
>
Thanks.
I do not think the patch which introduces this ([v7,1/3] um: Add support
for host CPU flags and alignment) has been merged yet. I do not see it
in the tree as of this morning.
I can see that it is already marked as done in patchwork so it is on its
way.
Richard, what do you want me to do - reissue a fixed one or we should
accept the fix once the original is merged?
--
Anton R. Ivanov
Cambridgegreys Limited. Registered in England. Company Number 10273661
https://www.cambridgegreys.com/
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] um: remove unneeded semicolon in um_arch.c
2021-06-19 6:41 ` Anton Ivanov
@ 2021-06-19 8:04 ` Richard Weinberger
0 siblings, 0 replies; 3+ messages in thread
From: Richard Weinberger @ 2021-06-19 8:04 UTC (permalink / raw)
To: anton ivanov
Cc: Wan Jiabing, Jeff Dike, Johannes Berg, Andrew Morton,
Nick Desaulniers, Corey Minyard, Thomas Meyer, Andy Shevchenko,
Joe Perches, linux-um, linux-kernel
Anton,
----- Ursprüngliche Mail -----
> Thanks.
>
> I do not think the patch which introduces this ([v7,1/3] um: Add support
> for host CPU flags and alignment) has been merged yet. I do not see it
> in the tree as of this morning.
>
> I can see that it is already marked as done in patchwork so it is on its
> way.
>
> Richard, what do you want me to do - reissue a fixed one or we should
> accept the fix once the original is merged?
I have just applied the fix to UML's next tree. :-)
Thanks,
//richard
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-06-19 8:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-19 2:02 [PATCH] um: remove unneeded semicolon in um_arch.c Wan Jiabing
2021-06-19 6:41 ` Anton Ivanov
2021-06-19 8:04 ` Richard Weinberger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®