* [RESEND PATCH] drm/panel: otm8009a: Set backlight parent to panel device
@ 2023-04-12 17:35 James Cowgill
2023-04-17 7:40 ` Neil Armstrong
2023-04-17 7:44 ` Neil Armstrong
0 siblings, 2 replies; 4+ messages in thread
From: James Cowgill @ 2023-04-12 17:35 UTC (permalink / raw)
To: Neil Armstrong, Sam Ravnborg, David Airlie, Daniel Vetter,
Philippe CORNU, Thierry Reding
Cc: James Cowgill, stable, dri-devel, linux-kernel
This is the logical place to put the backlight device, and it also
fixes a kernel crash if the MIPI host is removed. Previously the
backlight device would be unregistered twice when this happened - once
as a child of the MIPI host through `mipi_dsi_host_unregister`, and
once when the panel device is destroyed.
Fixes: 12a6cbd4f3f1 ("drm/panel: otm8009a: Use new backlight API")
Signed-off-by: James Cowgill <james.cowgill@blaize.com>
Cc: stable@vger.kernel.org
---
drivers/gpu/drm/panel/panel-orisetech-otm8009a.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/panel/panel-orisetech-otm8009a.c b/drivers/gpu/drm/panel/panel-orisetech-otm8009a.c
index b4729a94c34a8..898b892f11439 100644
--- a/drivers/gpu/drm/panel/panel-orisetech-otm8009a.c
+++ b/drivers/gpu/drm/panel/panel-orisetech-otm8009a.c
@@ -471,7 +471,7 @@ static int otm8009a_probe(struct mipi_dsi_device *dsi)
DRM_MODE_CONNECTOR_DSI);
ctx->bl_dev = devm_backlight_device_register(dev, dev_name(dev),
- dsi->host->dev, ctx,
+ dev, ctx,
&otm8009a_backlight_ops,
NULL);
if (IS_ERR(ctx->bl_dev)) {
--
2.39.1
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [RESEND PATCH] drm/panel: otm8009a: Set backlight parent to panel device
2023-04-12 17:35 [RESEND PATCH] drm/panel: otm8009a: Set backlight parent to panel device James Cowgill
@ 2023-04-17 7:40 ` Neil Armstrong
2023-04-17 7:44 ` Neil Armstrong
1 sibling, 0 replies; 4+ messages in thread
From: Neil Armstrong @ 2023-04-17 7:40 UTC (permalink / raw)
To: James Cowgill, Sam Ravnborg, David Airlie, Daniel Vetter,
Philippe CORNU, Thierry Reding
Cc: stable, dri-devel, linux-kernel
On 12/04/2023 19:35, James Cowgill wrote:
> This is the logical place to put the backlight device, and it also
> fixes a kernel crash if the MIPI host is removed. Previously the
> backlight device would be unregistered twice when this happened - once
> as a child of the MIPI host through `mipi_dsi_host_unregister`, and
> once when the panel device is destroyed.
>
> Fixes: 12a6cbd4f3f1 ("drm/panel: otm8009a: Use new backlight API")
> Signed-off-by: James Cowgill <james.cowgill@blaize.com>
> Cc: stable@vger.kernel.org
> ---
> drivers/gpu/drm/panel/panel-orisetech-otm8009a.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/panel/panel-orisetech-otm8009a.c b/drivers/gpu/drm/panel/panel-orisetech-otm8009a.c
> index b4729a94c34a8..898b892f11439 100644
> --- a/drivers/gpu/drm/panel/panel-orisetech-otm8009a.c
> +++ b/drivers/gpu/drm/panel/panel-orisetech-otm8009a.c
> @@ -471,7 +471,7 @@ static int otm8009a_probe(struct mipi_dsi_device *dsi)
> DRM_MODE_CONNECTOR_DSI);
>
> ctx->bl_dev = devm_backlight_device_register(dev, dev_name(dev),
> - dsi->host->dev, ctx,
> + dev, ctx,
> &otm8009a_backlight_ops,
> NULL);
> if (IS_ERR(ctx->bl_dev)) {
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [RESEND PATCH] drm/panel: otm8009a: Set backlight parent to panel device
2023-04-12 17:35 [RESEND PATCH] drm/panel: otm8009a: Set backlight parent to panel device James Cowgill
2023-04-17 7:40 ` Neil Armstrong
@ 2023-04-17 7:44 ` Neil Armstrong
1 sibling, 0 replies; 4+ messages in thread
From: Neil Armstrong @ 2023-04-17 7:44 UTC (permalink / raw)
To: Sam Ravnborg, David Airlie, Daniel Vetter, Philippe CORNU,
Thierry Reding, James Cowgill
Cc: stable, dri-devel, linux-kernel
Hi,
On Wed, 12 Apr 2023 17:35:07 +0000, James Cowgill wrote:
> This is the logical place to put the backlight device, and it also
> fixes a kernel crash if the MIPI host is removed. Previously the
> backlight device would be unregistered twice when this happened - once
> as a child of the MIPI host through `mipi_dsi_host_unregister`, and
> once when the panel device is destroyed.
>
>
> [...]
Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git (drm-misc-next-fixes)
[1/1] drm/panel: otm8009a: Set backlight parent to panel device
https://cgit.freedesktop.org/drm/drm-misc/commit/?id=ab4f869fba6119997f7630d600049762a2b014fa
--
Neil
^ permalink raw reply [flat|nested] 4+ messages in thread
* [RESEND PATCH] drm/panel: otm8009a: Set backlight parent to panel device
@ 2023-01-31 19:19 James Cowgill
0 siblings, 0 replies; 4+ messages in thread
From: James Cowgill @ 2023-01-31 19:19 UTC (permalink / raw)
To: Thierry Reding, Sam Ravnborg, David Airlie, Daniel Vetter,
Philippe CORNU
Cc: James Cowgill, stable, Thierry Reding, dri-devel, linux-kernel
This is the logical place to put the backlight device, and it also
fixes a kernel crash if the MIPI host is removed. Previously the
backlight device would be unregistered twice when this happened - once
as a child of the MIPI host through `mipi_dsi_host_unregister`, and
once when the panel device is destroyed.
Fixes: 12a6cbd4f3f1 ("drm/panel: otm8009a: Use new backlight API")
Signed-off-by: James Cowgill <james.cowgill@blaize.com>
Cc: stable@vger.kernel.org
---
drivers/gpu/drm/panel/panel-orisetech-otm8009a.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/panel/panel-orisetech-otm8009a.c b/drivers/gpu/drm/panel/panel-orisetech-otm8009a.c
index b4729a94c34a8..898b892f11439 100644
--- a/drivers/gpu/drm/panel/panel-orisetech-otm8009a.c
+++ b/drivers/gpu/drm/panel/panel-orisetech-otm8009a.c
@@ -471,7 +471,7 @@ static int otm8009a_probe(struct mipi_dsi_device *dsi)
DRM_MODE_CONNECTOR_DSI);
ctx->bl_dev = devm_backlight_device_register(dev, dev_name(dev),
- dsi->host->dev, ctx,
+ dev, ctx,
&otm8009a_backlight_ops,
NULL);
if (IS_ERR(ctx->bl_dev)) {
--
2.39.1
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-04-17 7:45 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-04-12 17:35 [RESEND PATCH] drm/panel: otm8009a: Set backlight parent to panel device James Cowgill
2023-04-17 7:40 ` Neil Armstrong
2023-04-17 7:44 ` Neil Armstrong
-- strict thread matches above, loose matches on Subject: below --
2023-01-31 19:19 James Cowgill
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®