* [PATCH] selftests/efivarfs: create-read: fix a resource leak
@ 2023-10-17 2:33 zhujun2
2023-10-17 15:46 ` Shuah Khan
0 siblings, 1 reply; 4+ messages in thread
From: zhujun2 @ 2023-10-17 2:33 UTC (permalink / raw)
To: shuah; +Cc: linux-kselftest, linux-kernel, zhujun2
The opened file should be closed in main(), otherwise resource
leak will occur
Signed-off-by: zhujun2 <zhujun2@cmss.chinamobile.com>
---
tools/testing/selftests/efivarfs/create-read.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/tools/testing/selftests/efivarfs/create-read.c b/tools/testing/selftests/efivarfs/create-read.c
index 9674a1939..6812104a5 100644
--- a/tools/testing/selftests/efivarfs/create-read.c
+++ b/tools/testing/selftests/efivarfs/create-read.c
@@ -32,8 +32,11 @@ int main(int argc, char **argv)
rc = read(fd, buf, sizeof(buf));
if (rc != 0) {
fprintf(stderr, "Reading a new var should return EOF\n");
+ close(fd);
return EXIT_FAILURE;
}
+ close(fd);
+
return EXIT_SUCCESS;
}
--
2.17.1
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] selftests/efivarfs: create-read: fix a resource leak
2023-10-17 2:33 [PATCH] selftests/efivarfs: create-read: fix a resource leak zhujun2
@ 2023-10-17 15:46 ` Shuah Khan
2023-10-18 1:59 ` zhujun2
0 siblings, 1 reply; 4+ messages in thread
From: Shuah Khan @ 2023-10-17 15:46 UTC (permalink / raw)
To: zhujun2, shuah; +Cc: linux-kselftest, linux-kernel, Shuah Khan
On 10/16/23 20:33, zhujun2 wrote:
> The opened file should be closed in main(), otherwise resource
> leak will occur
>
Did you find this by code reading or by any other means. Please
add how you found the problem to the change log.
> Signed-off-by: zhujun2 <zhujun2@cmss.chinamobile.com>
> ---
> tools/testing/selftests/efivarfs/create-read.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/tools/testing/selftests/efivarfs/create-read.c b/tools/testing/selftests/efivarfs/create-read.c
> index 9674a1939..6812104a5 100644
> --- a/tools/testing/selftests/efivarfs/create-read.c
> +++ b/tools/testing/selftests/efivarfs/create-read.c
> @@ -32,8 +32,11 @@ int main(int argc, char **argv)
> rc = read(fd, buf, sizeof(buf));
> if (rc != 0) {
> fprintf(stderr, "Reading a new var should return EOF\n");
> + close(fd);
> return EXIT_FAILURE;
> }
>
> + close(fd);
> +
No need for this extra line here.
> return EXIT_SUCCESS;
> }
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH] selftests/efivarfs: create-read: fix a resource leak
2023-10-17 15:46 ` Shuah Khan
@ 2023-10-18 1:59 ` zhujun2
2023-10-18 19:08 ` Shuah Khan
0 siblings, 1 reply; 4+ messages in thread
From: zhujun2 @ 2023-10-18 1:59 UTC (permalink / raw)
To: skhan; +Cc: linux-kernel, linux-kselftest, shuah, zhujun2
The opened file should be closed in main(), otherwise resource
leak will occur that this problem was discovered by code reading
Signed-off-by: zhujun2 <zhujun2@cmss.chinamobile.com>
---
tools/testing/selftests/efivarfs/create-read.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tools/testing/selftests/efivarfs/create-read.c b/tools/testing/selftests/efivarfs/create-read.c
index 9674a1939..7bc7af4eb 100644
--- a/tools/testing/selftests/efivarfs/create-read.c
+++ b/tools/testing/selftests/efivarfs/create-read.c
@@ -32,8 +32,10 @@ int main(int argc, char **argv)
rc = read(fd, buf, sizeof(buf));
if (rc != 0) {
fprintf(stderr, "Reading a new var should return EOF\n");
+ close(fd);
return EXIT_FAILURE;
}
+ close(fd);
return EXIT_SUCCESS;
}
--
2.17.1
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] selftests/efivarfs: create-read: fix a resource leak
2023-10-18 1:59 ` zhujun2
@ 2023-10-18 19:08 ` Shuah Khan
0 siblings, 0 replies; 4+ messages in thread
From: Shuah Khan @ 2023-10-18 19:08 UTC (permalink / raw)
To: zhujun2; +Cc: linux-kernel, linux-kselftest, shuah, Shuah Khan
On 10/17/23 19:59, zhujun2 wrote:
> The opened file should be closed in main(), otherwise resource
> leak will occur that this problem was discovered by code reading
>
> Signed-off-by: zhujun2 <zhujun2@cmss.chinamobile.com>
> ---
> tools/testing/selftests/efivarfs/create-read.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tools/testing/selftests/efivarfs/create-read.c b/tools/testing/selftests/efivarfs/create-read.c
> index 9674a1939..7bc7af4eb 100644
> --- a/tools/testing/selftests/efivarfs/create-read.c
> +++ b/tools/testing/selftests/efivarfs/create-read.c
> @@ -32,8 +32,10 @@ int main(int argc, char **argv)
> rc = read(fd, buf, sizeof(buf));
> if (rc != 0) {
> fprintf(stderr, "Reading a new var should return EOF\n");
> + close(fd);
> return EXIT_FAILURE;
> }
>
> + close(fd);
> return EXIT_SUCCESS;
> }
Thank you. Applied to linux-kselftest next for Linux 6.7-c1.
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-10-18 19:08 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-10-17 2:33 [PATCH] selftests/efivarfs: create-read: fix a resource leak zhujun2
2023-10-17 15:46 ` Shuah Khan
2023-10-18 1:59 ` zhujun2
2023-10-18 19:08 ` Shuah Khan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®