From: Rohit Agarwal <quic_rohiagar@quicinc.com>
To: Konrad Dybcio <konrad.dybcio@linaro.org>, <agross@kernel.org>,
<andersson@kernel.org>, <robh+dt@kernel.org>,
<krzysztof.kozlowski+dt@linaro.org>, <conor+dt@kernel.org>
Cc: <linux-arm-msm@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 5/8] ARM: dts: qcom: sdx65-mtp: Update the pmic used in sdx65
Date: Wed, 2 Aug 2023 18:47:22 +0530 [thread overview]
Message-ID: <6653d101-c9d8-fff6-46af-149a2f28e4b6@quicinc.com> (raw)
In-Reply-To: <51902449-11ea-508e-002d-b4b772ffe754@linaro.org>
On 8/2/2023 6:16 PM, Konrad Dybcio wrote:
> On 2.08.2023 11:59, Rohit Agarwal wrote:
>> Update the pmic used in sdx65 platform to pm7250b.
>>
>> Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com>
>> ---
> Has this changed with a board revision? Was this wrong before?
>
> Need more explanation, and this definitely deserves a Fixes: tag.
Just went through the sdx65 pmics and found this mistake so updating here.
Although the validations were successful with the earlier pmic as well
when originally pushed the patch.
Will add the fixes tag.
Thanks,
Rohit.
>
> Konrad
>> arch/arm/boot/dts/qcom/qcom-sdx65-mtp.dts | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/boot/dts/qcom/qcom-sdx65-mtp.dts b/arch/arm/boot/dts/qcom/qcom-sdx65-mtp.dts
>> index 02d8d6e..fcf1c51 100644
>> --- a/arch/arm/boot/dts/qcom/qcom-sdx65-mtp.dts
>> +++ b/arch/arm/boot/dts/qcom/qcom-sdx65-mtp.dts
>> @@ -7,7 +7,7 @@
>> #include "qcom-sdx65.dtsi"
>> #include <dt-bindings/regulator/qcom,rpmh-regulator.h>
>> #include <arm64/qcom/pmk8350.dtsi>
>> -#include <arm64/qcom/pm8150b.dtsi>
>> +#include <arm64/qcom/pm7250b.dtsi>
>> #include "qcom-pmx65.dtsi"
>>
>> / {
next prev parent reply other threads:[~2023-08-02 13:17 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-02 9:59 [PATCH 0/8] Add pmics supported in Qualcomm's SDX75 platform Rohit Agarwal
2023-08-02 9:59 ` [PATCH 1/8] arm64: dts: qcom: sdx75: Add spmi node Rohit Agarwal
2023-08-02 12:40 ` Konrad Dybcio
2023-08-02 13:07 ` Rohit Agarwal
2023-08-02 9:59 ` [PATCH 2/8] arm64: dts: qcom: Add pinctrl gpio support for pm7250b Rohit Agarwal
2023-08-02 12:41 ` Konrad Dybcio
2023-08-02 9:59 ` [PATCH 3/8] arm64: dts: qcom: Add PMIC pm7550ba dtsi Rohit Agarwal
2023-08-02 12:42 ` Konrad Dybcio
2023-08-02 13:13 ` Rohit Agarwal
2023-08-02 13:14 ` Konrad Dybcio
2023-08-02 13:19 ` Rohit Agarwal
2023-08-03 5:06 ` Pavan Kondeti
2023-08-04 16:58 ` Konrad Dybcio
2023-08-07 4:41 ` Pavan Kondeti
2023-08-02 9:59 ` [PATCH 4/8] arm64: dts: qcom: Add PMIC pmx75 dtsi Rohit Agarwal
2023-08-02 12:46 ` Konrad Dybcio
2023-08-02 13:13 ` Rohit Agarwal
2023-08-02 9:59 ` [PATCH 5/8] ARM: dts: qcom: sdx65-mtp: Update the pmic used in sdx65 Rohit Agarwal
2023-08-02 12:46 ` Konrad Dybcio
2023-08-02 13:17 ` Rohit Agarwal [this message]
2023-08-02 9:59 ` [PATCH 6/8] arm64: dts: qcom: sdx75-idp: Add pmics supported in SDX75 Rohit Agarwal
2023-08-02 9:59 ` [PATCH 7/8] arm64: dts: qcom: sdx75: Add rpmhpd node Rohit Agarwal
2023-08-02 12:48 ` Konrad Dybcio
2023-08-02 13:17 ` Rohit Agarwal
2023-08-02 9:59 ` [PATCH 8/8] arm64: dts: qcom: sdx75-idp: Add regulator nodes Rohit Agarwal
2023-08-02 12:49 ` Konrad Dybcio
2023-08-02 17:57 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6653d101-c9d8-fff6-46af-149a2f28e4b6@quicinc.com \
--to=quic_rohiagar@quicinc.com \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®