From: Michal Simek <michal.simek@amd.com>
To: Krzysztof Kozlowski <krzk@kernel.org>,
Abdurrahman Hussain <abdurrahman@nexthop.ai>
Cc: Andi Shyti <andi.shyti@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
info@mocean-labs.com,
Andy Shevchenko <andriy.shevchenko@intel.com>,
linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v6 1/7] dt-bindings: i2c: xiic: make clocks optional
Date: Wed, 28 Jan 2026 12:21:41 +0100 [thread overview]
Message-ID: <66c7435c-a936-413e-a016-c860d448c971@amd.com> (raw)
In-Reply-To: <20260128-remarkable-airborne-chihuahua-a1a16c@quoll>
On 1/28/26 11:37, Krzysztof Kozlowski wrote:
> On Tue, Jan 27, 2026 at 09:03:55PM +0000, Abdurrahman Hussain wrote:
>> The xiic driver is designed to operate without explicit clock configuration
>
> And if you change this in the driver, then you change bindings?
>
> You miss here explanation based on hardware - how does the hardware work
> if nothing ticks it clocks?
Hardware obviously have clock input which needs to be connected. Without it it
won't work.
And there are designs like Microblaze one where clock is shared with cpu itself
and there is no way to adjust it. It is just working.
Then we have configurations where clock is coming from clock generator which
needs to be enabled. That's case for SOCs with ARM cpus or with clock generators.
This series targets case around PCIe EP. Clock is likely derived from PCIe
itself and there is no way how to change it, adjust it. It is just running on
fixed value.
In DT this is design/described via fixed-clock but I expect this concept is not
used on systems with ACPI.
Thanks,
Michal
next prev parent reply other threads:[~2026-01-28 11:21 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-27 21:03 [PATCH v6 0/7] i2c: xiic: use generic device property accessors Abdurrahman Hussain via B4 Relay
2026-01-27 21:03 ` [PATCH v6 1/7] dt-bindings: i2c: xiic: make clocks optional Abdurrahman Hussain via B4 Relay
2026-01-28 10:37 ` Krzysztof Kozlowski
2026-01-28 11:21 ` Michal Simek [this message]
2026-01-28 14:34 ` Andrew Lunn
2026-01-28 14:38 ` Michal Simek
2026-01-28 14:40 ` Conor Dooley
2026-01-28 14:45 ` Andy Shevchenko
2026-01-28 15:00 ` Michal Simek
2026-01-28 15:43 ` Andy Shevchenko
2026-01-28 16:40 ` Abdurrahman Hussain
2026-01-29 16:14 ` Rob Herring
2026-01-30 5:33 ` Andy Shevchenko
2026-01-27 21:03 ` [PATCH v6 2/7] i2c: xiic: make the clock optional Abdurrahman Hussain via B4 Relay
2026-01-27 21:03 ` [PATCH v6 3/7] i2c: xiic: switch to devres managed APIs Abdurrahman Hussain via B4 Relay
2026-01-27 21:24 ` Andy Shevchenko
2026-01-27 21:03 ` [PATCH v6 4/7] i2c: xiic: remove duplicate error message Abdurrahman Hussain via B4 Relay
2026-01-27 21:03 ` [PATCH v6 5/7] i2c: xiic: switch to generic device property accessors Abdurrahman Hussain via B4 Relay
2026-01-27 21:04 ` [PATCH v6 6/7] i2c: xiic: cosmetic cleanup Abdurrahman Hussain via B4 Relay
2026-01-27 21:04 ` [PATCH v6 7/7] i2c xiic: cosmetic: use resource format specifier in debug log Abdurrahman Hussain via B4 Relay
2026-01-27 21:23 ` [PATCH v6 0/7] i2c: xiic: use generic device property accessors Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=66c7435c-a936-413e-a016-c860d448c971@amd.com \
--to=michal.simek@amd.com \
--cc=abdurrahman@nexthop.ai \
--cc=andi.shyti@kernel.org \
--cc=andriy.shevchenko@intel.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=info@mocean-labs.com \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®