* [PATCH] ASoC: qcom: sc8280xp: Derive TDM channels from DT mask
@ 2026-10-21 2:53 Shawn Guo
2026-10-21 5:25 ` Mohammad Rafi Shaik
0 siblings, 1 reply; 2+ messages in thread
From: Shawn Guo @ 2026-10-21 2:53 UTC (permalink / raw)
To: Mark Brown
Cc: Srinivas Kandagatla, Liam Girdwood, Jaroslav Kysela,
Takashi Iwai, Mohammad Rafi Shaik, Zhangfei Gao,
Bartosz Golaszewski, linux-sound, linux-arm-msm, linux-kernel,
Shawn Guo
Derive the AIF_TDM_RX_8 and AIF_TDM_TX_8 backend channel count from
the cpu DAI TDM slot mask in the DT, using the same tx/rx mask
selection as q6tdm_set_tdm_slot(). Each board then gets the channel
count its dai-link describes, e.g. 4/4 on Nord RRD, 6/4 on RIDE.
Keep the default of two when the link has no TDM slot description.
Signed-off-by: Shawn Guo <shengchao.guo@oss.qualcomm.com>
---
sound/soc/qcom/sc8280xp.c | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
diff --git a/sound/soc/qcom/sc8280xp.c b/sound/soc/qcom/sc8280xp.c
index 9aae6aadd43d..f3fb13145b3b 100644
--- a/sound/soc/qcom/sc8280xp.c
+++ b/sound/soc/qcom/sc8280xp.c
@@ -303,6 +303,22 @@ static int sc8280xp_be_hw_params_fixup(struct snd_soc_pcm_runtime *rtd,
channels->min = 2;
channels->max = 2;
switch (cpu_dai->id) {
+ case AIF_TDM_RX_8:
+ case AIF_TDM_TX_8: {
+ struct qcom_snd_tdm_slot_cfg cpu_cfg, codec_cfg;
+ unsigned int mask;
+
+ if (qcom_snd_get_dai_tdm_slots(rtd, &cpu_cfg, &codec_cfg))
+ break;
+
+ /* Same slot mask selection as q6tdm_set_tdm_slot() */
+ mask = (cpu_dai->id & 0x1) ? cpu_cfg.tx_mask : cpu_cfg.rx_mask;
+ if (mask) {
+ channels->min = hweight32(mask);
+ channels->max = channels->min;
+ }
+ break;
+ }
case TX_CODEC_DMA_TX_0:
case TX_CODEC_DMA_TX_1:
case TX_CODEC_DMA_TX_2:
--
2.43.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] ASoC: qcom: sc8280xp: Derive TDM channels from DT mask
2026-10-21 2:53 [PATCH] ASoC: qcom: sc8280xp: Derive TDM channels from DT mask Shawn Guo
@ 2026-10-21 5:25 ` Mohammad Rafi Shaik
0 siblings, 0 replies; 2+ messages in thread
From: Mohammad Rafi Shaik @ 2026-10-21 5:25 UTC (permalink / raw)
To: Shawn Guo, Mark Brown
Cc: Srinivas Kandagatla, Liam Girdwood, Jaroslav Kysela,
Takashi Iwai, Zhangfei Gao, Bartosz Golaszewski, linux-sound,
linux-arm-msm, linux-kernel
On 10/21/2026 8:23 AM, Shawn Guo wrote:
> Derive the AIF_TDM_RX_8 and AIF_TDM_TX_8 backend channel count from
> the cpu DAI TDM slot mask in the DT, using the same tx/rx mask
> selection as q6tdm_set_tdm_slot(). Each board then gets the channel
> count its dai-link describes, e.g. 4/4 on Nord RRD, 6/4 on RIDE.
> Keep the default of two when the link has no TDM slot description.
>
> Signed-off-by: Shawn Guo <shengchao.guo@oss.qualcomm.com>
> ---
> sound/soc/qcom/sc8280xp.c | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>
> diff --git a/sound/soc/qcom/sc8280xp.c b/sound/soc/qcom/sc8280xp.c
> index 9aae6aadd43d..f3fb13145b3b 100644
> --- a/sound/soc/qcom/sc8280xp.c
> +++ b/sound/soc/qcom/sc8280xp.c
> @@ -303,6 +303,22 @@ static int sc8280xp_be_hw_params_fixup(struct snd_soc_pcm_runtime *rtd,
> channels->min = 2;
> channels->max = 2;
> switch (cpu_dai->id) {
> + case AIF_TDM_RX_8:
> + case AIF_TDM_TX_8: {
This should not be limited to AIF_TDM_RX_8/AIF_TDM_TX_8.
Enable it for all TDM DAI IDs.
case PRIMARY_TDM_RX_0 ... QUINARY_TDM_TX_7:
case AIF_TDM_RX_0 ... AIF_TDM_TX_12:
Best Regards,
Rafi
> + struct qcom_snd_tdm_slot_cfg cpu_cfg, codec_cfg;
> + unsigned int mask;
> +
> + if (qcom_snd_get_dai_tdm_slots(rtd, &cpu_cfg, &codec_cfg))
> + break;
> +
> + /* Same slot mask selection as q6tdm_set_tdm_slot() */
> + mask = (cpu_dai->id & 0x1) ? cpu_cfg.tx_mask : cpu_cfg.rx_mask;
> + if (mask) {
> + channels->min = hweight32(mask);
> + channels->max = channels->min;
> + }
> + break;
> + }
> case TX_CODEC_DMA_TX_0:
> case TX_CODEC_DMA_TX_1:
> case TX_CODEC_DMA_TX_2:
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-10-21 5:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-10-21 2:53 [PATCH] ASoC: qcom: sc8280xp: Derive TDM channels from DT mask Shawn Guo
2026-10-21 5:25 ` Mohammad Rafi Shaik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®