From: "lihuisong (C)" <lihuisong@huawei.com>
To: Sudeep Holla <sudeep.holla@arm.com>, <linux-acpi@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Cc: Adam Young <admiyo@os.amperecomputing.com>,
Robbie King <robbiek@xsightlabs.com>,
Jassi Brar <jassisinghbrar@gmail.com>,
"Cristian Marussi" <cristian.marussi@arm.com>
Subject: Re: [PATCH 3/6] mailbox: pcc: Set txdone_irq/txdone_poll based on PCCT flags
Date: Mon, 20 Oct 2025 12:02:17 +0800 [thread overview]
Message-ID: <685b549a-2119-45a4-8996-89e33f47bc5a@huawei.com> (raw)
In-Reply-To: <20251016-pcc_mb_updates-v1-3-0fba69616f69@arm.com>
在 2025/10/17 3:08, Sudeep Holla 写道:
> The PCC controller currently enables txdone via IRQ if the PCCT exposes
> platform capability to generate command completion interrupt, but it
> leaves txdone_poll unchanged. Make the behaviour explicit:
>
> - If ACPI_PCCT_DOORBELL is present, use txdone_irq and disable polling.
> - Otherwise, disable txdone_irq and fall back to txdone_poll.
>
> Configure the PCC mailbox to use interrupt-based completion for PCC types
> that signal completion via IRQ using TXDONE_BY_IRQ, and fall back to
> polling for others using TXDONE_BY_POLL.
>
> This ensures the PCC driver uses the appropriate completion mechanism
> according to the PCCT table definition and makes the completion mode
> unambiguous avoiding mixed signalling when the platform lacks a doorbell
> flag set.
>
> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
> ---
LGTM,
Acked-by: lihuisong@huawei.com
>
next prev parent reply other threads:[~2025-10-20 4:02 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-16 19:08 [PATCH 0/6] mailbox: pcc: Refactor and improve initialisation and interrupt handling Sudeep Holla
2025-10-16 19:08 ` [PATCH 1/6] Revert "mailbox/pcc: support mailbox management of the shared buffer" Sudeep Holla
2025-10-17 16:54 ` Adam Young
2025-10-20 3:46 ` lihuisong (C)
2025-10-16 19:08 ` [PATCH 2/6] mailbox: pcc: Wire up ->last_tx_done() for PCC channels Sudeep Holla
2025-10-17 16:48 ` Adam Young
2025-10-17 16:59 ` Adam Young
2025-10-20 4:01 ` lihuisong (C)
2025-10-16 19:08 ` [PATCH 3/6] mailbox: pcc: Set txdone_irq/txdone_poll based on PCCT flags Sudeep Holla
2025-10-17 17:16 ` Adam Young
2025-10-20 4:02 ` lihuisong (C) [this message]
2025-10-16 19:08 ` [PATCH 4/6] mailbox: pcc: Mark Tx as complete in PCC IRQ handler Sudeep Holla
2025-10-17 16:54 ` Adam Young
2025-10-20 4:08 ` lihuisong (C)
2026-04-10 9:15 ` lihuisong (C)
2025-10-16 19:08 ` [PATCH 5/6] mailbox: pcc: Initialize SHMEM before binding the channel with the client Sudeep Holla
2025-10-17 16:59 ` Adam Young
2025-10-20 4:15 ` lihuisong (C)
2025-10-16 19:08 ` [PATCH 6/6] mailbox: pcc: Clear any pending responder interrupts before enabling it Sudeep Holla
2025-10-17 17:03 ` Adam Young
2025-10-17 16:49 ` [PATCH 0/6] mailbox: pcc: Refactor and improve initialisation and interrupt handling Adam Young
2025-11-27 14:40 ` Sudeep Holla
2026-01-12 16:55 ` Sudeep Holla
2026-01-26 17:07 ` Adam Young
2026-01-26 17:08 ` Adam Young
2026-01-27 9:29 ` Sudeep Holla
2026-02-04 21:40 ` Adam Young
2026-02-05 7:31 ` Adam Young
2026-02-24 23:13 ` Adam Young
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=685b549a-2119-45a4-8996-89e33f47bc5a@huawei.com \
--to=lihuisong@huawei.com \
--cc=admiyo@os.amperecomputing.com \
--cc=cristian.marussi@arm.com \
--cc=jassisinghbrar@gmail.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robbiek@xsightlabs.com \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®