mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Adam Young <admiyo@amperemail.onmicrosoft.com>
To: Sudeep Holla <sudeep.holla@arm.com>,
	linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Adam Young <admiyo@os.amperecomputing.com>,
	Robbie King <robbiek@xsightlabs.com>,
	Huisong Li <lihuisong@huawei.com>,
	Jassi Brar <jassisinghbrar@gmail.com>,
	Cristian Marussi <cristian.marussi@arm.com>
Subject: Re: [PATCH 6/6] mailbox: pcc: Clear any pending responder interrupts before enabling it
Date: Fri, 17 Oct 2025 13:03:05 -0400	[thread overview]
Message-ID: <d46a659d-6571-40e4-9c79-9a69ec919bad@amperemail.onmicrosoft.com> (raw)
In-Reply-To: <20251016-pcc_mb_updates-v1-6-0fba69616f69@arm.com>

Tested-by: Adam Young <admiyo@os.amperecomputing.com>

On 10/16/25 15:08, Sudeep Holla wrote:
> Some platforms may leave a responder interrupt pending from earlier
> transactions. If a PCC responder channel has a pending interrupt when
> the controller starts up, enabling the IRQ line without first clearing
> the condition can lead to a spurious interrupt which could disrupt other
> transmissions if the IRQ is shared.
>
> Explicitly clear any pending responder interrupt before enabling the IRQ
> to ensure a clean start. Acknowledge the responder channel via
> pcc_chan_acknowledge() in startup before requesting/enablement of the
> IRQ. This ensures a clean baseline for the first transfer/receiption
> of the notification/response.
>
> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
> ---
>   drivers/mailbox/pcc.c | 6 ++++++
>   1 file changed, 6 insertions(+)
>
> diff --git a/drivers/mailbox/pcc.c b/drivers/mailbox/pcc.c
> index 2829ec51b47f..418007020439 100644
> --- a/drivers/mailbox/pcc.c
> +++ b/drivers/mailbox/pcc.c
> @@ -468,6 +468,12 @@ static int pcc_startup(struct mbox_chan *chan)
>   	unsigned long irqflags;
>   	int rc;
>   
> +	/*
> +	 * Clear and acknowledge any pending interrupts on responder channel
> +	 * before enabling the interrupt
> +	 */
> +	pcc_chan_acknowledge(pchan);
> +
>   	if (pchan->plat_irq > 0) {
>   		irqflags = pcc_chan_plat_irq_can_be_shared(pchan) ?
>   						IRQF_SHARED | IRQF_ONESHOT : 0;
>

  reply	other threads:[~2025-10-17 17:03 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-16 19:08 [PATCH 0/6] mailbox: pcc: Refactor and improve initialisation and interrupt handling Sudeep Holla
2025-10-16 19:08 ` [PATCH 1/6] Revert "mailbox/pcc: support mailbox management of the shared buffer" Sudeep Holla
2025-10-17 16:54   ` Adam Young
2025-10-20  3:46   ` lihuisong (C)
2025-10-16 19:08 ` [PATCH 2/6] mailbox: pcc: Wire up ->last_tx_done() for PCC channels Sudeep Holla
2025-10-17 16:48   ` Adam Young
2025-10-17 16:59     ` Adam Young
2025-10-20  4:01   ` lihuisong (C)
2025-10-16 19:08 ` [PATCH 3/6] mailbox: pcc: Set txdone_irq/txdone_poll based on PCCT flags Sudeep Holla
2025-10-17 17:16   ` Adam Young
2025-10-20  4:02   ` lihuisong (C)
2025-10-16 19:08 ` [PATCH 4/6] mailbox: pcc: Mark Tx as complete in PCC IRQ handler Sudeep Holla
2025-10-17 16:54   ` Adam Young
2025-10-20  4:08   ` lihuisong (C)
2026-04-10  9:15     ` lihuisong (C)
2025-10-16 19:08 ` [PATCH 5/6] mailbox: pcc: Initialize SHMEM before binding the channel with the client Sudeep Holla
2025-10-17 16:59   ` Adam Young
2025-10-20  4:15   ` lihuisong (C)
2025-10-16 19:08 ` [PATCH 6/6] mailbox: pcc: Clear any pending responder interrupts before enabling it Sudeep Holla
2025-10-17 17:03   ` Adam Young [this message]
2025-10-17 16:49 ` [PATCH 0/6] mailbox: pcc: Refactor and improve initialisation and interrupt handling Adam Young
2025-11-27 14:40 ` Sudeep Holla
2026-01-12 16:55   ` Sudeep Holla
2026-01-26 17:07     ` Adam Young
2026-01-26 17:08       ` Adam Young
2026-01-27  9:29       ` Sudeep Holla
2026-02-04 21:40         ` Adam Young
2026-02-05  7:31           ` Adam Young
2026-02-24 23:13         ` Adam Young

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d46a659d-6571-40e4-9c79-9a69ec919bad@amperemail.onmicrosoft.com \
    --to=admiyo@amperemail.onmicrosoft.com \
    --cc=admiyo@os.amperecomputing.com \
    --cc=cristian.marussi@arm.com \
    --cc=jassisinghbrar@gmail.com \
    --cc=lihuisong@huawei.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robbiek@xsightlabs.com \
    --cc=sudeep.holla@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®