* [PATCH] drm/vmwgfx: Remove unused vmw_goal_waiter_add/remove
@ 2026-07-21 8:00 Saswat PC Ubuntu
2026-07-23 4:36 ` [PATCH v2] " Saswat Jung Khadka
0 siblings, 1 reply; 3+ messages in thread
From: Saswat PC Ubuntu @ 2026-07-21 8:00 UTC (permalink / raw)
To: zack.rusin
Cc: bcm-kernel-feedback-list, maarten.lankhorst, mripard,
tzimmermann, airlied, simona, dri-devel, linux-kernel,
Saswat PC Ubuntu
vmw_goal_waiter_add() and vmw_goal_waiter_remove() have had no
callers since commit 'db6a94b26354', which removed their only
call site. Their sibling functions vmw_seqno_waiter_add/remove
are still in active use, confirming these are leftover dead
code.
Signed-off-by: Saswat PC Ubuntu <saswatjungkhadka@gmail.com>
---
drivers/gpu/drm/vmwgfx/vmwgfx_drv.h | 2 --
drivers/gpu/drm/vmwgfx/vmwgfx_irq.c | 12 ------------
2 files changed, 14 deletions(-)
diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_drv.h b/drivers/gpu/drm/vmwgfx/vmwgfx_drv.h
index 38bea8aba..d84e077ed 100644
--- a/drivers/gpu/drm/vmwgfx/vmwgfx_drv.h
+++ b/drivers/gpu/drm/vmwgfx/vmwgfx_drv.h
@@ -1026,8 +1026,6 @@ extern int vmw_fallback_wait(struct vmw_private *dev_priv,
unsigned long timeout);
bool vmw_seqno_waiter_add(struct vmw_private *dev_priv);
bool vmw_seqno_waiter_remove(struct vmw_private *dev_priv);
-bool vmw_goal_waiter_add(struct vmw_private *dev_priv);
-bool vmw_goal_waiter_remove(struct vmw_private *dev_priv);
bool vmw_generic_waiter_add(struct vmw_private *dev_priv, u32 flag,
int *waiter_count);
bool vmw_generic_waiter_remove(struct vmw_private *dev_priv,
diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_irq.c b/drivers/gpu/drm/vmwgfx/vmwgfx_irq.c
index 05773eb39..88c77226c 100644
--- a/drivers/gpu/drm/vmwgfx/vmwgfx_irq.c
+++ b/drivers/gpu/drm/vmwgfx/vmwgfx_irq.c
@@ -273,18 +273,6 @@ bool vmw_seqno_waiter_remove(struct vmw_private *dev_priv)
&dev_priv->fence_queue_waiters);
}
-bool vmw_goal_waiter_add(struct vmw_private *dev_priv)
-{
- return vmw_generic_waiter_add(dev_priv, vmw_irqflag_fence_goal(dev_priv),
- &dev_priv->goal_queue_waiters);
-}
-
-bool vmw_goal_waiter_remove(struct vmw_private *dev_priv)
-{
- return vmw_generic_waiter_remove(dev_priv, vmw_irqflag_fence_goal(dev_priv),
- &dev_priv->goal_queue_waiters);
-}
-
static void vmw_irq_preinstall(struct drm_device *dev)
{
struct vmw_private *dev_priv = vmw_priv(dev);
--
2.43.0
^ permalink raw reply [flat|nested] 3+ messages in thread* [PATCH v2] drm/vmwgfx: Remove unused vmw_goal_waiter_add/remove
2026-07-21 8:00 [PATCH] drm/vmwgfx: Remove unused vmw_goal_waiter_add/remove Saswat PC Ubuntu
@ 2026-07-23 4:36 ` Saswat Jung Khadka
2026-07-24 20:12 ` Maaz Mombasawala
0 siblings, 1 reply; 3+ messages in thread
From: Saswat Jung Khadka @ 2026-07-23 4:36 UTC (permalink / raw)
To: zack.rusin
Cc: maaz.mombasawala, bcm-kernel-feedback-list, maarten.lankhorst,
mripard, tzimmermann, airlied, simona, dri-devel, linux-kernel,
Saswat Jung Khadka
vmw_goal_waiter_add() and vmw_goal_waiter_remove() have had no
callers since commit db6a94b26354 ("drm/vmwgfx: Implement
dma_fence_ops properly"), which removed their only call site.
Their sibling functions vmw_seqno_waiter_add/remove are still
in active use, confirming these are leftover dead code.
Signed-off-by: Saswat Jung Khadka <saswatjungkhadka@gmail.com>
---
drivers/gpu/drm/vmwgfx/vmwgfx_drv.h | 2 --
drivers/gpu/drm/vmwgfx/vmwgfx_irq.c | 12 ------------
2 files changed, 14 deletions(-)
diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_drv.h b/drivers/gpu/drm/vmwgfx/vmwgfx_drv.h
index 38bea8aba..d84e077ed 100644
--- a/drivers/gpu/drm/vmwgfx/vmwgfx_drv.h
+++ b/drivers/gpu/drm/vmwgfx/vmwgfx_drv.h
@@ -1026,8 +1026,6 @@ extern int vmw_fallback_wait(struct vmw_private *dev_priv,
unsigned long timeout);
bool vmw_seqno_waiter_add(struct vmw_private *dev_priv);
bool vmw_seqno_waiter_remove(struct vmw_private *dev_priv);
-bool vmw_goal_waiter_add(struct vmw_private *dev_priv);
-bool vmw_goal_waiter_remove(struct vmw_private *dev_priv);
bool vmw_generic_waiter_add(struct vmw_private *dev_priv, u32 flag,
int *waiter_count);
bool vmw_generic_waiter_remove(struct vmw_private *dev_priv,
diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_irq.c b/drivers/gpu/drm/vmwgfx/vmwgfx_irq.c
index 05773eb39..88c77226c 100644
--- a/drivers/gpu/drm/vmwgfx/vmwgfx_irq.c
+++ b/drivers/gpu/drm/vmwgfx/vmwgfx_irq.c
@@ -273,18 +273,6 @@ bool vmw_seqno_waiter_remove(struct vmw_private *dev_priv)
&dev_priv->fence_queue_waiters);
}
-bool vmw_goal_waiter_add(struct vmw_private *dev_priv)
-{
- return vmw_generic_waiter_add(dev_priv, vmw_irqflag_fence_goal(dev_priv),
- &dev_priv->goal_queue_waiters);
-}
-
-bool vmw_goal_waiter_remove(struct vmw_private *dev_priv)
-{
- return vmw_generic_waiter_remove(dev_priv, vmw_irqflag_fence_goal(dev_priv),
- &dev_priv->goal_queue_waiters);
-}
-
static void vmw_irq_preinstall(struct drm_device *dev)
{
struct vmw_private *dev_priv = vmw_priv(dev);
--
2.43.0
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v2] drm/vmwgfx: Remove unused vmw_goal_waiter_add/remove
2026-07-23 4:36 ` [PATCH v2] " Saswat Jung Khadka
@ 2026-07-24 20:12 ` Maaz Mombasawala
0 siblings, 0 replies; 3+ messages in thread
From: Maaz Mombasawala @ 2026-07-24 20:12 UTC (permalink / raw)
To: Saswat Jung Khadka, zack.rusin
Cc: bcm-kernel-feedback-list, maarten.lankhorst, mripard,
tzimmermann, airlied, simona, dri-devel, linux-kernel
On 7/22/26 9:36 PM, Saswat Jung Khadka wrote:
> vmw_goal_waiter_add() and vmw_goal_waiter_remove() have had no
> callers since commit db6a94b26354 ("drm/vmwgfx: Implement
> dma_fence_ops properly"), which removed their only call site.
> Their sibling functions vmw_seqno_waiter_add/remove are still
> in active use, confirming these are leftover dead code.
>
> Signed-off-by: Saswat Jung Khadka <saswatjungkhadka@gmail.com>
> ---
> drivers/gpu/drm/vmwgfx/vmwgfx_drv.h | 2 --
> drivers/gpu/drm/vmwgfx/vmwgfx_irq.c | 12 ------------
> 2 files changed, 14 deletions(-)
>
> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_drv.h b/drivers/gpu/drm/vmwgfx/vmwgfx_drv.h
> index 38bea8aba..d84e077ed 100644
> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_drv.h
> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_drv.h
> @@ -1026,8 +1026,6 @@ extern int vmw_fallback_wait(struct vmw_private *dev_priv,
> unsigned long timeout);
> bool vmw_seqno_waiter_add(struct vmw_private *dev_priv);
> bool vmw_seqno_waiter_remove(struct vmw_private *dev_priv);
> -bool vmw_goal_waiter_add(struct vmw_private *dev_priv);
> -bool vmw_goal_waiter_remove(struct vmw_private *dev_priv);
> bool vmw_generic_waiter_add(struct vmw_private *dev_priv, u32 flag,
> int *waiter_count);
> bool vmw_generic_waiter_remove(struct vmw_private *dev_priv,
> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_irq.c b/drivers/gpu/drm/vmwgfx/vmwgfx_irq.c
> index 05773eb39..88c77226c 100644
> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_irq.c
> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_irq.c
> @@ -273,18 +273,6 @@ bool vmw_seqno_waiter_remove(struct vmw_private *dev_priv)
> &dev_priv->fence_queue_waiters);
> }
>
> -bool vmw_goal_waiter_add(struct vmw_private *dev_priv)
> -{
> - return vmw_generic_waiter_add(dev_priv, vmw_irqflag_fence_goal(dev_priv),
> - &dev_priv->goal_queue_waiters);
> -}
> -
> -bool vmw_goal_waiter_remove(struct vmw_private *dev_priv)
> -{
> - return vmw_generic_waiter_remove(dev_priv, vmw_irqflag_fence_goal(dev_priv),
> - &dev_priv->goal_queue_waiters);
> -}
> -
> static void vmw_irq_preinstall(struct drm_device *dev)
> {
> struct vmw_private *dev_priv = vmw_priv(dev);
LGTM!
Reviewed-by: Maaz Mombasawala <maaz.mombasawala@broadcom.com>
--
Maaz Mombasawala <maaz.mombasawala@broadcom.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-07-24 20:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-07-21 8:00 [PATCH] drm/vmwgfx: Remove unused vmw_goal_waiter_add/remove Saswat PC Ubuntu
2026-07-23 4:36 ` [PATCH v2] " Saswat Jung Khadka
2026-07-24 20:12 ` Maaz Mombasawala
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®