Re: [PATCH v8 1/8] drm/msm/dpu: add dsc blocks for remaining chipsets in catalog

[Abhinav Kumar <quic_abhinavk@quicinc.com>]

On 5/14/2023 2:39 PM, Marijn Suijten wrote:
> DSC*, and mention 1.1 explicitly (since this skips the 1.2 blocks, while
> the series is clearly aimed at 1.1...).  This was done for the DSC 1.2
> HW block patch after all.
> 
> in catalog -> to catalog
> 
> But it's just two platforms, you can fit MSM8998 and SC8180X in the
> title.
> 
> On 2023-05-12 11:00:16, Kuogee Hsieh wrote:
>>
>> From: Abhinav Kumar <quic_abhinavk@quicinc.com>
>>
>> There are some platforms has DSC blocks but it is not declared at catalog.
> 
> Some platforms have DSC blocks which have not yet been declared in the
> catalog.*
> 
>> For completeness, this patch adds DSC blocks for platforms which missed
>> them.
> 
> Drop "this patch":
> 
>      Complete DSC 1.1 support for all platforms by adding the missing
>      blocks to MSM8998 and SC8180X.
> 
>>
>> Signed-off-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
>> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
>> ---
>>   drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_3_0_msm8998.h |  7 +++++++
>>   drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_5_1_sc8180x.h | 11 +++++++++++
> 
> How about SC7180, and any other DPU 6.x revision?
> 

Will let kuogee respond to the other nits. There is no DSC in sc7180 / 
sm6115 / qcm2290. So this patch is complete.

> Rest of the patch looks good and complete.
> 
> - Marijn
> 
>>   2 files changed, 18 insertions(+)
>>