[PATCHv4 1/1] platform/x86: dell-sysman: add support for alienware products

[PATCHv4 1/1] platform/x86: dell-sysman: add support for alienware products

[Crag Wang]

Alienware supports firmware-attributes and has its own OEM string.

Signed-off-by: Crag Wang <crag_wang@dell.com>
---
 drivers/platform/x86/dell/dell-wmi-sysman/sysman.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/platform/x86/dell/dell-wmi-sysman/sysman.c b/drivers/platform/x86/dell/dell-wmi-sysman/sysman.c
index 9def7983d7d6..40ddc6eb7562 100644
--- a/drivers/platform/x86/dell/dell-wmi-sysman/sysman.c
+++ b/drivers/platform/x86/dell/dell-wmi-sysman/sysman.c
@@ -521,6 +521,7 @@ static int __init sysman_init(void)
 	int ret = 0;
 
 	if (!dmi_find_device(DMI_DEV_TYPE_OEM_STRING, "Dell System", NULL) &&
+	    !dmi_find_device(DMI_DEV_TYPE_OEM_STRING, "Alienware", NULL) &&
 	    !dmi_find_device(DMI_DEV_TYPE_OEM_STRING, "www.dell.com", NULL)) {
 		pr_err("Unable to run on non-Dell system\n");
 		return -ENODEV;
-- 
2.43.0

Re: [PATCHv4 1/1] platform/x86: dell-sysman: add support for alienware products

[Hans de Goede]

Hi,

On 4-Oct-24 5:27 PM, Crag Wang wrote:
> Alienware supports firmware-attributes and has its own OEM string.
> 
> Signed-off-by: Crag Wang <crag_wang@dell.com>

Thank you for your patch/series, I've applied this patch
(series) to my review-hans branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans

Note it will show up in the pdx86 review-hans branch once I've
pushed my local branch there, which might take a while.

I will include this patch in my next fixes pull-req to Linus
for the current kernel development cycle.

Regards,

Hans



> ---
>  drivers/platform/x86/dell/dell-wmi-sysman/sysman.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/platform/x86/dell/dell-wmi-sysman/sysman.c b/drivers/platform/x86/dell/dell-wmi-sysman/sysman.c
> index 9def7983d7d6..40ddc6eb7562 100644
> --- a/drivers/platform/x86/dell/dell-wmi-sysman/sysman.c
> +++ b/drivers/platform/x86/dell/dell-wmi-sysman/sysman.c
> @@ -521,6 +521,7 @@ static int __init sysman_init(void)
>  	int ret = 0;
>  
>  	if (!dmi_find_device(DMI_DEV_TYPE_OEM_STRING, "Dell System", NULL) &&
> +	    !dmi_find_device(DMI_DEV_TYPE_OEM_STRING, "Alienware", NULL) &&
>  	    !dmi_find_device(DMI_DEV_TYPE_OEM_STRING, "www.dell.com", NULL)) {
>  		pr_err("Unable to run on non-Dell system\n");
>  		return -ENODEV;

Re: [PATCHv4 1/1] platform/x86: dell-sysman: add support for alienware products

[Hans de Goede]

Hi,

On 6-Oct-24 12:43 PM, Hans de Goede wrote:
> Hi,
> 
> On 4-Oct-24 5:27 PM, Crag Wang wrote:
>> Alienware supports firmware-attributes and has its own OEM string.
>>
>> Signed-off-by: Crag Wang <crag_wang@dell.com>
> 
> Thank you for your patch/series, I've applied this patch
> (series) to my review-hans branch:
> https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans
> 
> Note it will show up in the pdx86 review-hans branch once I've
> pushed my local branch there, which might take a while.
> 
> I will include this patch in my next fixes pull-req to Linus
> for the current kernel development cycle.

Running checkpatch after applying show:

WARNING: From:/Signed-off-by: email address mismatch: 'From: Crag Wang <crag0715@gmail.com>' != 'Signed-off-by: Crag Wang <crag_wang@dell.com>'

I have fixed this by running:

git commit --amend --author="Crag Wang <crag_wang@dell.com>"

So that things match now. Next time please try to use your Dell
email for submitting the patches instead of gmail.

Regards,

Hans

Re: [PATCHv4 1/1] platform/x86: dell-sysman: add support for alienware products

[Ilpo Järvinen]

[-- Attachment #1: Type: text/plain, Size: 1011 bytes --]

On Fri, 4 Oct 2024, Crag Wang wrote:

> Alienware supports firmware-attributes and has its own OEM string.
> 
> Signed-off-by: Crag Wang <crag_wang@dell.com>

Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>

-- 
 i.

> ---
>  drivers/platform/x86/dell/dell-wmi-sysman/sysman.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/platform/x86/dell/dell-wmi-sysman/sysman.c b/drivers/platform/x86/dell/dell-wmi-sysman/sysman.c
> index 9def7983d7d6..40ddc6eb7562 100644
> --- a/drivers/platform/x86/dell/dell-wmi-sysman/sysman.c
> +++ b/drivers/platform/x86/dell/dell-wmi-sysman/sysman.c
> @@ -521,6 +521,7 @@ static int __init sysman_init(void)
>  	int ret = 0;
>  
>  	if (!dmi_find_device(DMI_DEV_TYPE_OEM_STRING, "Dell System", NULL) &&
> +	    !dmi_find_device(DMI_DEV_TYPE_OEM_STRING, "Alienware", NULL) &&
>  	    !dmi_find_device(DMI_DEV_TYPE_OEM_STRING, "www.dell.com", NULL)) {
>  		pr_err("Unable to run on non-Dell system\n");
>  		return -ENODEV;
> 

RE: [PATCHv4 1/1] platform/x86: dell-sysman: add support for alienware products

[Ksr, Prasanth]

[EXTERNAL EMAIL]


Internal Use - Confidential
On Fri, 4 Oct 2024, Crag Wang wrote:

> Alienware supports firmware-attributes and has its own OEM string.
>
> Signed-off-by: Crag Wang <crag_wang@dell.com>

> Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>

Reviewed-by: Ksr, Prasanth <Prasanth_Ksr@Dell.com>

--
 i.

> ---
>  drivers/platform/x86/dell/dell-wmi-sysman/sysman.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/platform/x86/dell/dell-wmi-sysman/sysman.c b/drivers/platform/x86/dell/dell-wmi-sysman/sysman.c
> index 9def7983d7d6..40ddc6eb7562 100644
> --- a/drivers/platform/x86/dell/dell-wmi-sysman/sysman.c
> +++ b/drivers/platform/x86/dell/dell-wmi-sysman/sysman.c
> @@ -521,6 +521,7 @@ static int __init sysman_init(void)
>       int ret = 0;
>
>       if (!dmi_find_device(DMI_DEV_TYPE_OEM_STRING, "Dell System", NULL) &&
> +         !dmi_find_device(DMI_DEV_TYPE_OEM_STRING, "Alienware", NULL) &&
>           !dmi_find_device(DMI_DEV_TYPE_OEM_STRING, "www.dell.com", NULL)) {
>               pr_err("Unable to run on non-Dell system\n");
>               return -ENODEV;
>