* [PATCH rtw-next v12 0/3] wifi: rtw88: channel switch in AP mode
@ 2026-11-17 23:26 Mehmet Fide
2026-11-17 23:26 ` [PATCH rtw-next v12 1/3] wifi: rtw88: download the beacon the reserved page was built with Mehmet Fide
` (3 more replies)
0 siblings, 4 replies; 11+ messages in thread
From: Mehmet Fide @ 2026-11-17 23:26 UTC (permalink / raw)
To: Ping-Ke Shih
Cc: Luka Gejak, Bitterblue Smith, linux-wireless, linux-kernel, mehmet.fide
From: Mehmet Fide <mehmet.fide@screeningeagle.com>
An rtw88 AP cannot change its channel: the driver does not announce
channel switch support, so hostapd's CHAN_SWITCH is refused and the
only way is to tear the AP down. The series fixes the beacon download
the reserved page build makes twice, counts a switch down on top of
the firmware's beacon page, and times the countdown downloads from the
TBTT so that every count goes out on the air.
v12 applies on top of patches 1-4 of the firmware recovery fixes [2];
patch 5 of [2] is superseded by commit 3f2238709f5d ("wifi: rtw88:
clear RTW_FLAG_RESTARTING on stop and start failure") in rtw-next.
v12 was tested with [2] and the mac80211 patch [1] on top, [1] is in
mainline now as commit 12f97c692dcb, on a kernel with PROVE_LOCKING,
DEBUG_ATOMIC_SLEEP, kmemleak and KFENCE, on an RTL8821CU (two
adapters), an RTL8822BU, an RTL8822CU (USB) and an RTL8822CE (PCIe)
with hostapd as AP, the beacons sniffed from a second machine, on
rtw-next fb51e39dfaea:
- the regression suite on the five adapters on 2.4 and 5 GHz:
beacons, association, power save, scans, a hardware restart,
rebinding, a firmware crash on the RTL8822CE, and 300 switches with
counts 2, 5 and 10. The AP switched in 300 of 300 and every count
went out in 296; the other four were on 2.4 GHz on the RTL8822BU and
the RTL8822CU, which lost 46 % and 2.4 % of their beacons in the
beacon tests of the same run. One missing count was the single CSA
beacon of a count of 2, and the station lost the AP. In 30 more
switches with a count of 2 on that adapter every count went out, and
in 29 of 30 with the v12 of before [2]. In two more switches with a
count of 2 the station lost the AP although the sniffers heard its
single CSA beacon; the same happens with v11. No lockdep report, and
no kmemleak report from the drivers
- a test build that fails the first download of a countdown on purpose,
with counts 2 and 5 on the RTL8821CU, the RTL8822BU and the RTL8822CE:
the AP switched in 30 of 30 and every count went out in 25. In 15
more runs each, the v12 of before [2] and this one lost counts in 2
of 15 each. With v11 a count of 2 switched without any CSA beacon in
5 of 5
- the same build holding the first step back by 95 ms: the AP switched
in 30 of 30 and every count went out in 27. With v11, held back by 90
to 100 ms, a count of 2 switched without any CSA beacon in 10 of 12
- an IBSS left during its countdown, without [1] and with a monitor
interface keeping the radio up, on four adapters: the countdown work
stops and a scan works; with v11 the work ran on and every scan was
refused
- a station interface associated first, an AP started next to it and
stopped during a countdown of 50 on the RTL8822CE and the RTL8822CU:
the station stayed associated in the 5 runs in which it had
associated
- an off-channel period of 300 ms during a countdown of 20 on the
RTL8821CU: the AP switched in 3 of 3. The beacons after an off-channel
period are partly missing also without the series
Every count missing in the first three items fell on a TBTT at which
neither sniffer heard any beacon, as happens on these adapters without
a countdown too.
The RTL8822BU and the RTL8822CE ran again on rtw-next badf4c3c7679:
- the regression suite on 2.4 and 5 GHz with 36 switches: every
count went out, lockdep stayed on, no kmemleak report from the
drivers
- a firmware crash during a countdown of 40 on the RTL8822CE, the AP
alone and next to an associated station interface: no lockdep or
DEBUG_ATOMIC_SLEEP report; the AP alone ended on its new channel
- a firmware crash with the hardware restart held back by 4 s in a test
build, the AP and its interface stopped in between: the restart flag
was clear afterwards and the next crash was recovered, 2 of 2
In IBSS a countdown leaves more beacons off the air where the channel
is busy; the count goes on after each of them. With 20 s with and
without a countdown taking turns on one channel, the beacons that no
sniffer heard are, on 5 GHz, 1.9 % and 3.5 % of the countdown of an
RTL8821CU and the RTL8822BU against 0.3 % and 0.2 % without one, and
none on the RTL8822C; on 2.4 GHz 6.6 to 12.1 % against 2.7 to 7.2 % on
the five adapters. An AP shows no such difference. The cause is the
beacon function, which rtw_fw_write_data_rsvd_page() switches off for
the download: left on for the count steps, the difference is gone on
5 GHz, but one RTL8821CU AP then lost its station in 6 of 110
switches with counts 5 and 10 on 2.4 GHz, and in none of 100 without
the change, so the series leaves the download as it is. The TSF
stands still for the download as well, 2.8 ms on the USB chips and
0.3 ms on the RTL8822CE, so the beacons of a countdown are about
105 ms apart on USB.
Not run for v12: Windows stations. The WoWLAN paths are built but not
run: after a suspend the PCIe card of the test board is inaccessible and
the USB adapters are probed again. Without the series as well, an IBSS
interface stops beaconing after a scan. Patch 1 changed only in its
commit message since v6.
v12:
- 2/3: a failed download of a count is repeated before the next step,
and the switch completes only after the count of 1 reached the
firmware (Luka). The work steps with the count that
ieee80211_beacon_update_cntdwn() returns and no longer calls
ieee80211_beacon_cntdwn_is_complete(), which warned when the AP
stopped in between (Sashiko)
- 2/3: the work never clears csa_vif, and rtw_ops_stop_ap() downloads
the page again whenever a station interface stays (Luka)
- 2/3: the countdown stops while beaconing is disabled, for an IBSS
that is left or an off-channel period, and starts again when it is
enabled with the switch still announced (Sashiko)
- 2/3: WoWLAN suspend keeps the interface of the countdown and resume
starts it again, without iterating the interfaces (Luka)
- 2/3: a failed download of the replay after a hardware restart is
repeated before the next step
- 3/3: each step reads the TSF after its download and the next one runs
10 ms after the first TBTT at least 10 ms away; no step runs less than
5 ms after or 10 ms before a TBTT, the one that finishes the switch
included. A late step delays the switch instead of taking a count off
the air (Luka)
- 3/3: the commit message says which count the first CSA beacon
carries (Sashiko)
- 1/3: the commit message says why there is no Fixes tag and what
mac80211 reports for the double fetch (Sashiko)
- rebased on patches 1-4 of [2]
v11:
- 2/3: the channel_switch_beacon op is gone, the BSS_CHANGED_BEACON
path starts every countdown (Luka)
- 2/3: rtw_fw_csa_start() does nothing on a device that is not
running
- 2/3: only the countdown work advances the count. The beacon of the
reserved page is fetched as a template while a switch is announced,
so the replay after a firmware recovery and the page of the WoWLAN
firmware repeat the count that is on the air
- 2/3: an AP that stops in its countdown downloads the reserved page
again if a station interface stays behind; the downloads the
countdown held back were lost for it
- 3/3: the first download shares the branch of a late one, and the
comment says what the branch catches (Luka)
- the beacon interval that stays at 100 TU on the air is fixed by a
separate patch (Luka)
- rebased on rtw-next
v10:
- 2/3: rtw_core_stop() clears csa_vif and cancels the countdown work
again once it has the mutex back, for a switch started while the
mutex was dropped (Luka)
- 3/3: the first count is downloaded by the countdown work, 10 ms
after the next TBTT, and no longer when mac80211 changes the beacon.
My reply on v9 said v10 only drops the back-off; that is not enough
on the RTL8822CE, where a TBTT shortly before the download sends no
beacon and the next one stays out too, so a count of 2 went out
without a CSA beacon (Luka). The switch completes up to one beacon
interval later. Ping-Ke's Acked-by and Luka's Reviewed-by are
dropped for the changed code
- rebased on rtw-next
v9:
- 2/3: the countdown starts again after a WoWLAN resume that worked,
which mac80211 follows with no replay (Luka); Ping-Ke's Acked-by is
dropped for the new code
- 3/3: Acked-by from Ping-Ke on v8, Reviewed-by from Luka
- an IBSS left during its countdown and joined again kept csa_active;
that is mac80211's, fixed by a separate patch [1] (Luka)
v8:
- 2/3: Acked-by from Ping-Ke
- 3/3: the TSF read retries once instead of looping, rtw_fw_csa_queue()
reads the TSF once also on start, the port 0 comment is gone, empty
lines where asked (Ping-Ke)
v7:
- new patch 3: the countdown downloads are timed from the TSF, 10 ms
after each TBTT, so a download that runs late by less than a beacon
interval still reaches the firmware before the next beacon; one
later than that is followed by its successor at once. Ping-Ke's
question on v6: with the absolute due time a late download and its
successor could land in one beacon period and leave a count out of
the air
- patch 3 takes a TBTT within the margin before the start as the one
that sent the countdown template: a TBTT between the template
download and the first TSF read made the stations see one count
twice
- patch 2 keeps csa_vif until the beacon after the switch: a TIM
update before it fetched one beacon past count 1 and hit the WARN
in ieee80211_beacon_update_cntdwn()
- rebased on rtw-next
v6:
- the wiphy work patch of v5 is gone: the countdown work is an
ieee80211 delayed work and csa_vif is driver state, both under the
driver mutex, so rtw88 takes no wiphy lock anywhere (Ping-Ke)
- rtw_core_stop() cancels the countdown work and clears csa_vif, which
covers the IPS path and the firmware recovery; the wiphy_lock() in
the recovery work is gone (Ping-Ke)
- the BSS_CHANGED_BEACON path says why it starts the countdown, the
replay after a hardware restart, and stops it when the beacon comes
back without a switch announced (Ping-Ke)
- the downloads are paced from the first one with an absolute due
time. Queued after each download, they drifted by about 10 ms per
beacon interval on the ordered mac80211 workqueue; on a count of 50
the AP switched half a second after its station had, and the
station re-associated
v5:
- 2/3 is new: update_beacon_work becomes a wiphy work, so that it can
look at the channel switch state under the wiphy lock; it checks
RTW_FLAG_RUNNING instead of being cancelled in rtw_core_stop(), which
runs without the wiphy lock on the IPS path (Ping-Ke); reverted in v6
- 3/3: rtw_fw_csa_active/start/stop() assert the wiphy lock (Ping-Ke);
reverted in v6, they assert the driver mutex
- 3/3: hw_scan() takes the mutex with guard() (Ping-Ke)
- 3/3: a comment on the association download names the STA+AP
combination it skips the download for (Ping-Ke)
- the whole set ran on a PROVE_LOCKING kernel without a lockdep report:
switches with counts 1 to 100, hostapd stopped and restarted during
a countdown, scans during a countdown, a firmware crash during a
countdown, three stop/idle/start cycles, IBSS, 50 switches with a
station attached, and on the RTL8822CU a station interface
associating while the AP interface counted down
v4:
- 1/2: Reviewed-by from Luka
- 2/2: the countdown work is back in the device, initialised once,
with csa_vif naming the interface; no interface iteration and no
lookup through the reserved page any more (Ping-Ke)
- 2/2: the countdown is cancelled before a firmware recovery restarts
the hardware, instead of guarding the work with flags (Ping-Ke)
- 2/2: the page download on association skips a running countdown,
like the TIM update and the PG backup (Luka)
- 2/2: the scan refusal comes before the scan offload test, so that
firmware without scan offload does not fall back to a software scan
during a countdown (Luka)
v3:
- 1/2: the beacon out-pointer is initialised in the caller (Luka)
- 2/2: the countdown work lives in the interface, remove_interface
cancels it unconditionally, the queue wrapper and the comments are
gone (Ping-Ke)
- 2/2: the TIM update and the PG backup on set_key skip the page
download while a switch is announced; every beacon fetch advances
the countdown (Luka)
- 2/2: the commit message names the refused hardware scan (Ping-Ke)
v2:
- 2/2: a hardware scan is refused while a switch is announced
- the rtw89 mention is gone from the cover
[1] https://lore.kernel.org/linux-wireless/20261025193615.1123718-1-mehmet.fide@gmail.com/
[2] https://lore.kernel.org/linux-wireless/20261117171003.1840491-1-mehmet.fide@gmail.com/
Mehmet Fide (3):
wifi: rtw88: download the beacon the reserved page was built with
wifi: rtw88: support channel switch in AP mode
wifi: rtw88: time the countdown downloads from the TBTT
drivers/net/wireless/realtek/rtw88/fw.c | 182 ++++++++++++++++--
drivers/net/wireless/realtek/rtw88/fw.h | 5 +
drivers/net/wireless/realtek/rtw88/mac80211.c | 60 +++++-
drivers/net/wireless/realtek/rtw88/main.c | 9 +-
drivers/net/wireless/realtek/rtw88/main.h | 5 +
drivers/net/wireless/realtek/rtw88/reg.h | 1 +
6 files changed, 237 insertions(+), 25 deletions(-)
base-commit: badf4c3c7679871a50cff1150f66e63187201757
prerequisite-patch-id: 61a489b0da7e1d0028cc1c72c0ecd1301f3b8ec7
prerequisite-patch-id: 5040450eb00c500bda0b95bb35bd821721f149ee
prerequisite-patch-id: 8c5c1393ce4b56fecf3238b21bd34fcdbae8769a
prerequisite-patch-id: 6ecc624d0c38a71c64993f725622e02ae2ad1629
--
2.56.0
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH rtw-next v12 1/3] wifi: rtw88: download the beacon the reserved page was built with
2026-11-17 23:26 [PATCH rtw-next v12 0/3] wifi: rtw88: channel switch in AP mode Mehmet Fide
@ 2026-11-17 23:26 ` Mehmet Fide
2026-11-17 23:26 ` [PATCH rtw-next v12 2/3] wifi: rtw88: support channel switch in AP mode Mehmet Fide
` (2 subsequent siblings)
3 siblings, 0 replies; 11+ messages in thread
From: Mehmet Fide @ 2026-11-17 23:26 UTC (permalink / raw)
To: Ping-Ke Shih
Cc: Luka Gejak, Bitterblue Smith, linux-wireless, linux-kernel, mehmet.fide
From: Mehmet Fide <mehmet.fide@screeningeagle.com>
rtw_fw_download_rsvd_page() downloads the beacon twice: once as part of
the reserved page and once more on its own, so that the firmware ends up
with a TX descriptor that describes the beacon rather than the whole
page. The second download fetched a new beacon from mac80211 instead of
downloading the one the page already holds.
Besides the extra work, every beacon fetch advances the DTIM count and,
while a channel switch is announced, the CSA countdown; doing it twice
per update steps a countdown that starts at 2 past 1, which mac80211
reports as "beacon TX faster than countdown". Hand the beacon skb out of
the page build and download that. The hw scan, which downloads the
beacon without a page build, keeps fetching its own.
Without a channel switch nothing on the air depends on it: the hardware
writes the DTIM count of an AP beacon itself (BIT_TCR_UPDATE_TIMIE), so
this is not marked as a fix.
Signed-off-by: Mehmet Fide <mehmet.fide@screeningeagle.com>
Reviewed-by: Luka Gejak <luka.gejak@linux.dev>
Acked-by: Ping-Ke Shih <pkshih@realtek.com>
---
Notes:
Changes in v12:
- the commit message says why this is not marked as a fix and what
mac80211 reports for the double fetch (Sashiko); no code change, the
tags are kept
- rebased on patches 1-4 of the rtw88 firmware recovery fixes v3
Changes in v11:
- none, rebased on rtw-next
Changes in v10:
- none, rebased on rtw-next
Changes in v9:
- none
Changes in v8:
- none
Changes in v7:
- none, rebased on rtw-next
Changes in v6:
- none
Changes in v5:
- none
Changes in v4:
- none, rebased on rtw-next
Changes in v3:
- the beacon out-pointer is initialised in the caller
drivers/net/wireless/realtek/rtw88/fw.c | 34 +++++++++++++++----------
1 file changed, 21 insertions(+), 13 deletions(-)
diff --git a/drivers/net/wireless/realtek/rtw88/fw.c b/drivers/net/wireless/realtek/rtw88/fw.c
index aa2daf2d1820..e0f3e1adb13f 100644
--- a/drivers/net/wireless/realtek/rtw88/fw.c
+++ b/drivers/net/wireless/realtek/rtw88/fw.c
@@ -1625,7 +1625,8 @@ static int __rtw_build_rsvd_page_from_vifs(struct rtw_dev *rtwdev)
return 0;
}
-static u8 *rtw_build_rsvd_page(struct rtw_dev *rtwdev, u32 *size)
+static u8 *rtw_build_rsvd_page(struct rtw_dev *rtwdev, u32 *size,
+ struct sk_buff **beacon)
{
const struct rtw_chip_info *chip = rtwdev->chip;
struct ieee80211_hw *hw = rtwdev->hw;
@@ -1705,13 +1706,15 @@ static u8 *rtw_build_rsvd_page(struct rtw_dev *rtwdev, u32 *size)
list_for_each_entry(rsvd_pkt, &rtwdev->rsvd_page_list, build_list) {
rtw_rsvd_page_list_to_buf(rtwdev, page_size, page_margin,
page, buf, rsvd_pkt);
- if (page == 0)
+ if (page == 0) {
page += rtw_len_to_page(rsvd_pkt->skb->len +
tx_desc_sz, page_size);
- else
+ /* the caller downloads it once more on its own */
+ *beacon = rsvd_pkt->skb;
+ } else {
page += rtw_len_to_page(rsvd_pkt->skb->len, page_size);
-
- kfree_skb(rsvd_pkt->skb);
+ kfree_skb(rsvd_pkt->skb);
+ }
rsvd_pkt->skb = NULL;
}
@@ -1726,11 +1729,12 @@ static u8 *rtw_build_rsvd_page(struct rtw_dev *rtwdev, u32 *size)
return NULL;
}
-static int rtw_download_beacon(struct rtw_dev *rtwdev)
+/* the beacon the page was built with, or a fresh one for the hw scan */
+static int rtw_download_beacon(struct rtw_dev *rtwdev, struct sk_buff *beacon)
{
struct ieee80211_hw *hw = rtwdev->hw;
struct rtw_rsvd_page *rsvd_pkt;
- struct sk_buff *skb;
+ struct sk_buff *skb = beacon;
int ret = 0;
rsvd_pkt = list_first_entry_or_null(&rtwdev->rsvd_page_list,
@@ -1747,7 +1751,8 @@ static int rtw_download_beacon(struct rtw_dev *rtwdev)
return -EINVAL;
}
- skb = rtw_get_rsvd_page_skb(hw, rsvd_pkt);
+ if (!skb)
+ skb = rtw_get_rsvd_page_skb(hw, rsvd_pkt);
if (!skb) {
rtw_err(rtwdev, "failed to get beacon skb\n");
return -ENOMEM;
@@ -1757,21 +1762,23 @@ static int rtw_download_beacon(struct rtw_dev *rtwdev)
if (ret)
rtw_err(rtwdev, "failed to download drv rsvd page\n");
- dev_kfree_skb(skb);
+ if (!beacon)
+ dev_kfree_skb(skb);
return ret;
}
int rtw_fw_download_rsvd_page(struct rtw_dev *rtwdev)
{
- u8 *buf;
+ struct sk_buff *beacon = NULL;
u32 size;
+ u8 *buf;
int ret;
if (bitmap_empty(rtwdev->hw_port, RTW_PORT_NUM))
return 0;
- buf = rtw_build_rsvd_page(rtwdev, &size);
+ buf = rtw_build_rsvd_page(rtwdev, &size, &beacon);
if (!buf) {
rtw_err(rtwdev, "failed to build rsvd page pkt\n");
return -ENOMEM;
@@ -1788,13 +1795,14 @@ int rtw_fw_download_rsvd_page(struct rtw_dev *rtwdev)
* the beacon again to replace the TX desc header, and we will get
* a correct tx_desc for the beacon in the rsvd page.
*/
- ret = rtw_download_beacon(rtwdev);
+ ret = rtw_download_beacon(rtwdev, beacon);
if (ret) {
rtw_err(rtwdev, "failed to download beacon\n");
goto free;
}
free:
+ dev_kfree_skb(beacon);
kfree(buf);
return ret;
@@ -2352,7 +2360,7 @@ int rtw_hw_scan_offload(struct rtw_dev *rtwdev, struct ieee80211_vif *vif,
rtw_fw_set_scan_offload(rtwdev, &cs_option, rtwvif, &chan_list);
out:
if (rtwdev->ap_active) {
- ret = rtw_download_beacon(rtwdev);
+ ret = rtw_download_beacon(rtwdev, NULL);
if (ret)
rtw_err(rtwdev, "HW scan download beacon failed\n");
}
--
2.56.0
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH rtw-next v12 2/3] wifi: rtw88: support channel switch in AP mode
2026-11-17 23:26 [PATCH rtw-next v12 0/3] wifi: rtw88: channel switch in AP mode Mehmet Fide
2026-11-17 23:26 ` [PATCH rtw-next v12 1/3] wifi: rtw88: download the beacon the reserved page was built with Mehmet Fide
@ 2026-11-17 23:26 ` Mehmet Fide
2026-11-18 7:55 ` Mehmet Fide
2026-11-18 8:19 ` Luka Gejak
2026-11-17 23:26 ` [PATCH rtw-next v12 3/3] wifi: rtw88: time the countdown downloads from the TBTT Mehmet Fide
2026-11-18 12:48 ` [PATCH rtw-next v12 0/3] wifi: rtw88: channel switch in AP mode Luka Gejak
3 siblings, 2 replies; 11+ messages in thread
From: Mehmet Fide @ 2026-11-17 23:26 UTC (permalink / raw)
To: Ping-Ke Shih
Cc: Luka Gejak, Bitterblue Smith, linux-wireless, linux-kernel, mehmet.fide
From: Mehmet Fide <mehmet.fide@screeningeagle.com>
hostapd's CHAN_SWITCH is refused because the driver does not announce
channel switch support, so an rtw88 AP can only change its channel by
being torn down and started again.
Declare WIPHY_FLAG_HAS_CHANNEL_SWITCH and start the countdown when
BSS_CHANGED_BEACON brings a beacon with CSA: the firmware repeats the
beacon held in the first reserved page, so while a switch is announced
the page is downloaded again every beacon interval to advance the
countdown. The work steps the count with ieee80211_beacon_update_cntdwn()
and calls ieee80211_csa_finish() one beacon interval after the count of
1 was downloaded; a download that fails is repeated with the same count,
so the switch does not complete before its last count was handed to the
firmware. IBSS shares the page and the work.
The work is a delayed work of the device and csa_vif names the
interface, both under the driver mutex. The driver clears csa_vif, the
work never does: the countdown is cancelled when the AP stops, when the
interface goes away, on WoWLAN suspend and in rtw_core_stop(), and while
beaconing is disabled, as for an IBSS that is left or for an off-channel
period; it starts again when beaconing is enabled with the switch still
announced. It is not started while the device is stopped. The work
itself only stops, at the end of the countdown or once mac80211 has
taken the beacon away. The BSS_CHANGED_BEACON replay after a hardware
restart resumes the countdown, a failed download of the replay is
repeated before the next step, and the driver resumes the countdown
after a WoWLAN resume, which mac80211 follows with no replay.
While a switch is announced the beacon of the page is fetched as a
template, which leaves the count as it is, so a download for another
reason, the replay after a hardware restart or the page of the WoWLAN
firmware, carries the count as the work left it. The TIM update, the PG
backup and the download on association are left to the work during a
countdown, its next download carries their changes. An AP that stops
downloads the page once more if a station interface stays behind. A
scan is refused: it would take the AP off the channel its stations
count down to.
Signed-off-by: Mehmet Fide <mehmet.fide@screeningeagle.com>
---
drivers/net/wireless/realtek/rtw88/fw.c | 100 +++++++++++++++++-
drivers/net/wireless/realtek/rtw88/fw.h | 5 +
drivers/net/wireless/realtek/rtw88/mac80211.c | 55 ++++++++--
drivers/net/wireless/realtek/rtw88/main.c | 9 +-
drivers/net/wireless/realtek/rtw88/main.h | 6 ++
5 files changed, 164 insertions(+), 11 deletions(-)
diff --git a/drivers/net/wireless/realtek/rtw88/fw.c b/drivers/net/wireless/realtek/rtw88/fw.c
index e0f3e1adb13f..0910a9c7d7bc 100644
--- a/drivers/net/wireless/realtek/rtw88/fw.c
+++ b/drivers/net/wireless/realtek/rtw88/fw.c
@@ -1232,6 +1232,7 @@ static struct sk_buff *rtw_get_rsvd_page_skb(struct ieee80211_hw *hw,
struct ieee80211_vif *vif;
struct rtw_vif *rtwvif;
struct sk_buff *skb_new;
+ struct ieee80211_mutable_offsets offs = {};
struct cfg80211_ssid *ssid;
u16 tim_offset = 0;
@@ -1252,7 +1253,15 @@ static struct sk_buff *rtw_get_rsvd_page_skb(struct ieee80211_hw *hw,
switch (rsvd_pkt->type) {
case RSVD_BEACON:
- skb_new = ieee80211_beacon_get_tim(hw, vif, &tim_offset, NULL, 0);
+ /* only the countdown work advances the count */
+ if (vif->bss_conf.csa_active) {
+ skb_new = ieee80211_beacon_get_template(hw, vif, &offs,
+ 0);
+ tim_offset = offs.tim_offset;
+ } else {
+ skb_new = ieee80211_beacon_get_tim(hw, vif, &tim_offset,
+ NULL, 0);
+ }
rsvd_pkt->tim_offset = tim_offset;
break;
case RSVD_PS_POLL:
@@ -1808,14 +1817,99 @@ int rtw_fw_download_rsvd_page(struct rtw_dev *rtwdev)
return ret;
}
+bool rtw_fw_csa_active(struct rtw_dev *rtwdev)
+{
+ lockdep_assert_held(&rtwdev->mutex);
+
+ return !!rtwdev->csa_vif;
+}
+
+/* paced from the first download: a late one does not delay the next */
+static void rtw_fw_csa_queue(struct rtw_dev *rtwdev, struct ieee80211_vif *vif)
+{
+ u32 interval = ieee80211_tu_to_usec(vif->bss_conf.beacon_int);
+ s64 delay;
+
+ rtwdev->csa_due = ktime_add_us(rtwdev->csa_due, interval);
+ delay = ktime_us_delta(rtwdev->csa_due, ktime_get());
+ ieee80211_queue_delayed_work(rtwdev->hw, &rtwdev->csa_beacon_work,
+ usecs_to_jiffies(max(delay, 0)));
+}
+
+void rtw_fw_csa_start(struct rtw_dev *rtwdev, struct ieee80211_vif *vif,
+ bool retry)
+{
+ lockdep_assert_held(&rtwdev->mutex);
+
+ if (rtwdev->csa_vif == vif ||
+ !test_bit(RTW_FLAG_RUNNING, rtwdev->flags))
+ return;
+
+ rtwdev->csa_vif = vif;
+ rtwdev->csa_retry = retry;
+ rtwdev->csa_count = ieee80211_beacon_cntdwn_is_complete(vif, 0) ? 1 : 0;
+ rtwdev->csa_due = ktime_get();
+ rtw_fw_csa_queue(rtwdev, vif);
+}
+
+void rtw_fw_csa_stop(struct rtw_dev *rtwdev, struct ieee80211_vif *vif)
+{
+ lockdep_assert_held(&rtwdev->mutex);
+
+ if (!vif || rtwdev->csa_vif != vif)
+ return;
+
+ rtwdev->csa_vif = NULL;
+ cancel_delayed_work(&rtwdev->csa_beacon_work);
+}
+
void rtw_fw_update_beacon_work(struct work_struct *work)
{
struct rtw_dev *rtwdev = container_of(work, struct rtw_dev,
update_beacon_work);
mutex_lock(&rtwdev->mutex);
- rtw_fw_download_rsvd_page(rtwdev);
- rtw_send_rsvd_page_h2c(rtwdev);
+
+ /* the countdown's next download carries the TIM */
+ if (!rtw_fw_csa_active(rtwdev)) {
+ rtw_fw_download_rsvd_page(rtwdev);
+ rtw_send_rsvd_page_h2c(rtwdev);
+ }
+
+ mutex_unlock(&rtwdev->mutex);
+}
+
+void rtw_fw_csa_beacon_work(struct work_struct *work)
+{
+ struct rtw_dev *rtwdev = container_of(work, struct rtw_dev,
+ csa_beacon_work.work);
+ struct ieee80211_vif *vif;
+ u8 count;
+
+ mutex_lock(&rtwdev->mutex);
+
+ vif = rtwdev->csa_vif;
+ if (!vif || !vif->bss_conf.csa_active)
+ goto out;
+
+ if (!rtwdev->csa_retry) {
+ if (rtwdev->csa_count == 1) {
+ ieee80211_csa_finish(vif, 0);
+ goto out;
+ }
+
+ count = ieee80211_beacon_update_cntdwn(vif, 0);
+ if (!count)
+ goto out;
+ rtwdev->csa_count = count;
+ }
+
+ rtwdev->csa_retry = !!rtw_fw_download_rsvd_page(rtwdev);
+ if (!rtwdev->csa_retry)
+ rtw_send_rsvd_page_h2c(rtwdev);
+ rtw_fw_csa_queue(rtwdev, vif);
+
+out:
mutex_unlock(&rtwdev->mutex);
}
diff --git a/drivers/net/wireless/realtek/rtw88/fw.h b/drivers/net/wireless/realtek/rtw88/fw.h
index 48ad9ceab6ea..14bcddbd786d 100644
--- a/drivers/net/wireless/realtek/rtw88/fw.h
+++ b/drivers/net/wireless/realtek/rtw88/fw.h
@@ -863,7 +863,12 @@ void rtw_add_rsvd_page_pno(struct rtw_dev *rtwdev,
void rtw_add_rsvd_page_sta(struct rtw_dev *rtwdev,
struct rtw_vif *rtwvif);
int rtw_fw_download_rsvd_page(struct rtw_dev *rtwdev);
+bool rtw_fw_csa_active(struct rtw_dev *rtwdev);
+void rtw_fw_csa_start(struct rtw_dev *rtwdev, struct ieee80211_vif *vif,
+ bool retry);
+void rtw_fw_csa_stop(struct rtw_dev *rtwdev, struct ieee80211_vif *vif);
void rtw_fw_update_beacon_work(struct work_struct *work);
+void rtw_fw_csa_beacon_work(struct work_struct *work);
void rtw_send_rsvd_page_h2c(struct rtw_dev *rtwdev);
int rtw_dump_drv_rsvd_page(struct rtw_dev *rtwdev,
u32 offset, u32 size, u32 *buf);
diff --git a/drivers/net/wireless/realtek/rtw88/mac80211.c b/drivers/net/wireless/realtek/rtw88/mac80211.c
index ffd86f08185b..20969dd689df 100644
--- a/drivers/net/wireless/realtek/rtw88/mac80211.c
+++ b/drivers/net/wireless/realtek/rtw88/mac80211.c
@@ -240,6 +240,10 @@ static void rtw_ops_remove_interface(struct ieee80211_hw *hw,
mutex_lock(&rtwdev->mutex);
+ rtw_fw_csa_stop(rtwdev, vif);
+ if (rtwdev->csa_wow_vif == vif)
+ rtwdev->csa_wow_vif = NULL;
+
rtw_leave_lps_deep(rtwdev);
rtw_txq_cleanup(rtwdev, vif->txq);
@@ -388,6 +392,7 @@ static void rtw_ops_bss_info_changed(struct ieee80211_hw *hw,
struct rtw_coex *coex = &rtwdev->coex;
struct rtw_coex_stat *coex_stat = &coex->stat;
u32 config = 0;
+ int ret;
mutex_lock(&rtwdev->mutex);
@@ -398,8 +403,11 @@ static void rtw_ops_bss_info_changed(struct ieee80211_hw *hw,
if (vif->cfg.assoc) {
rtw_coex_connect_notify(rtwdev, COEX_ASSOCIATE_FINISH);
- rtw_fw_download_rsvd_page(rtwdev);
- rtw_send_rsvd_page_h2c(rtwdev);
+ /* a station associating while the AP counts down */
+ if (!rtw_fw_csa_active(rtwdev)) {
+ rtw_fw_download_rsvd_page(rtwdev);
+ rtw_send_rsvd_page_h2c(rtwdev);
+ }
rtw_fw_default_port(rtwdev, rtwvif);
rtw_coex_media_status_notify(rtwdev, vif->cfg.assoc);
if (rtw_bf_support)
@@ -439,8 +447,16 @@ static void rtw_ops_bss_info_changed(struct ieee80211_hw *hw,
if (changed & BSS_CHANGED_BEACON) {
rtw_set_dtim_period(rtwdev, conf->dtim_period);
- rtw_fw_download_rsvd_page(rtwdev);
+ ret = rtw_fw_download_rsvd_page(rtwdev);
rtw_send_rsvd_page_h2c(rtwdev);
+ /*
+ * A beacon with CSA starts the countdown, also when a restart
+ * replays it. A beacon without CSA ends it.
+ */
+ if (conf->csa_active)
+ rtw_fw_csa_start(rtwdev, vif, !!ret);
+ else
+ rtw_fw_csa_stop(rtwdev, vif);
}
if (changed & BSS_CHANGED_BEACON_ENABLED) {
@@ -450,6 +466,10 @@ static void rtw_ops_bss_info_changed(struct ieee80211_hw *hw,
else
rtw_write32_clr(rtwdev, REG_FWHW_TXQ_CTRL,
BIT_EN_BCNQ_DL);
+ if (!conf->enable_beacon)
+ rtw_fw_csa_stop(rtwdev, vif);
+ else if (conf->csa_active)
+ rtw_fw_csa_start(rtwdev, vif, false);
}
if (changed & BSS_CHANGED_CQM)
rtw_fw_beacon_filter_config(rtwdev, true, vif);
@@ -493,11 +513,17 @@ static void rtw_ops_stop_ap(struct ieee80211_hw *hw,
struct rtw_dev *rtwdev = hw->priv;
mutex_lock(&rtwdev->mutex);
+ rtw_fw_csa_stop(rtwdev, vif);
rtw_write32_clr(rtwdev, REG_TCR, BIT_TCR_UPDATE_HGQMD);
rtw_write16(rtwdev, REG_ATIMWND, ATIMWND_DEFAULT);
rtwdev->ap_active = false;
- if (!rtw_core_check_sta_active(rtwdev))
+ if (!rtw_core_check_sta_active(rtwdev)) {
rtw_clear_op_chan(rtwdev);
+ } else {
+ /* what a countdown may have held back */
+ rtw_fw_download_rsvd_page(rtwdev);
+ rtw_send_rsvd_page_h2c(rtwdev);
+ }
mutex_unlock(&rtwdev->mutex);
}
@@ -629,7 +655,8 @@ static int rtw_ops_set_key(struct ieee80211_hw *hw, enum set_key_cmd cmd,
}
/* download new cam settings for PG to backup */
- if (rtw_get_lps_deep_mode(rtwdev) == LPS_DEEP_MODE_PG)
+ if (rtw_get_lps_deep_mode(rtwdev) == LPS_DEEP_MODE_PG &&
+ !rtw_fw_csa_active(rtwdev))
rtw_fw_download_rsvd_page(rtwdev);
out:
@@ -846,12 +873,16 @@ static int rtw_ops_suspend(struct ieee80211_hw *hw,
struct cfg80211_wowlan *wowlan)
{
struct rtw_dev *rtwdev = hw->priv;
+ struct ieee80211_vif *csa_vif;
int ret;
mutex_lock(&rtwdev->mutex);
+ csa_vif = rtwdev->csa_vif;
+ rtw_fw_csa_stop(rtwdev, csa_vif);
ret = rtw_wow_suspend(rtwdev, wowlan);
if (ret)
rtw_err(rtwdev, "failed to suspend for wow %d\n", ret);
+ rtwdev->csa_wow_vif = ret ? NULL : csa_vif;
mutex_unlock(&rtwdev->mutex);
return ret ? 1 : 0;
@@ -860,12 +891,18 @@ static int rtw_ops_suspend(struct ieee80211_hw *hw,
static int rtw_ops_resume(struct ieee80211_hw *hw)
{
struct rtw_dev *rtwdev = hw->priv;
+ struct ieee80211_vif *csa_vif;
int ret;
mutex_lock(&rtwdev->mutex);
ret = rtw_wow_resume(rtwdev);
if (ret)
rtw_err(rtwdev, "failed to resume for wow %d\n", ret);
+ csa_vif = rtwdev->csa_wow_vif;
+ rtwdev->csa_wow_vif = NULL;
+ if (!ret && csa_vif && csa_vif->bss_conf.csa_active &&
+ csa_vif->bss_conf.enable_beacon)
+ rtw_fw_csa_start(rtwdev, csa_vif, false);
mutex_unlock(&rtwdev->mutex);
return ret ? 1 : 0;
@@ -896,20 +933,24 @@ static int rtw_ops_hw_scan(struct ieee80211_hw *hw, struct ieee80211_vif *vif,
struct rtw_dev *rtwdev = hw->priv;
int ret;
+ guard(mutex)(&rtwdev->mutex);
+
+ /* a scan takes the AP off the channel its stations count down to */
+ if (rtw_fw_csa_active(rtwdev))
+ return -EBUSY;
+
if (!rtw_fw_feature_check(&rtwdev->fw, FW_FEATURE_SCAN_OFFLOAD))
return 1;
if (test_bit(RTW_FLAG_SCANNING, rtwdev->flags))
return -EBUSY;
- mutex_lock(&rtwdev->mutex);
rtw_hw_scan_start(rtwdev, vif, req);
ret = rtw_hw_scan_offload(rtwdev, vif, true);
if (ret) {
rtw_hw_scan_abort(rtwdev);
rtw_err(rtwdev, "HW scan failed with status: %d\n", ret);
}
- mutex_unlock(&rtwdev->mutex);
return ret;
}
diff --git a/drivers/net/wireless/realtek/rtw88/main.c b/drivers/net/wireless/realtek/rtw88/main.c
index 48abf0daf402..38bf6100a0dd 100644
--- a/drivers/net/wireless/realtek/rtw88/main.c
+++ b/drivers/net/wireless/realtek/rtw88/main.c
@@ -1557,11 +1557,13 @@ void rtw_core_stop(struct rtw_dev *rtwdev)
clear_bit(RTW_FLAG_RUNNING, rtwdev->flags);
clear_bit(RTW_FLAG_FW_RUNNING, rtwdev->flags);
+ rtwdev->csa_vif = NULL;
mutex_unlock(&rtwdev->mutex);
cancel_work_sync(&rtwdev->c2h_work);
cancel_work_sync(&rtwdev->update_beacon_work);
+ cancel_delayed_work_sync(&rtwdev->csa_beacon_work);
cancel_delayed_work_sync(&rtwdev->watch_dog_work);
cancel_delayed_work_sync(&coex->bt_relink_work);
cancel_delayed_work_sync(&coex->bt_reenable_work);
@@ -1574,6 +1576,9 @@ void rtw_core_stop(struct rtw_dev *rtwdev)
mutex_lock(&rtwdev->mutex);
+ rtwdev->csa_vif = NULL;
+ cancel_delayed_work(&rtwdev->csa_beacon_work);
+
rtwdev->chip->ops->power_off(rtwdev);
}
@@ -2177,6 +2182,7 @@ int rtw_core_init(struct rtw_dev *rtwdev)
INIT_WORK(&rtwdev->ips_work, rtw_ips_work);
INIT_WORK(&rtwdev->fw_recovery_work, rtw_fw_recovery_work);
INIT_WORK(&rtwdev->update_beacon_work, rtw_fw_update_beacon_work);
+ INIT_DELAYED_WORK(&rtwdev->csa_beacon_work, rtw_fw_csa_beacon_work);
INIT_WORK(&rtwdev->ba_work, rtw_txq_ba_work);
skb_queue_head_init(&rtwdev->c2h_queue);
skb_queue_head_init(&rtwdev->coex.queue);
@@ -2297,7 +2303,8 @@ int rtw_register_hw(struct rtw_dev *rtwdev, struct ieee80211_hw *hw)
hw->wiphy->available_antennas_rx = hal->antenna_rx;
hw->wiphy->flags |= WIPHY_FLAG_SUPPORTS_TDLS |
- WIPHY_FLAG_TDLS_EXTERNAL_SETUP;
+ WIPHY_FLAG_TDLS_EXTERNAL_SETUP |
+ WIPHY_FLAG_HAS_CHANNEL_SWITCH;
hw->wiphy->features |= NL80211_FEATURE_SCAN_RANDOM_MAC_ADDR;
hw->wiphy->max_scan_ssids = RTW_SCAN_MAX_SSIDS;
diff --git a/drivers/net/wireless/realtek/rtw88/main.h b/drivers/net/wireless/realtek/rtw88/main.h
index 6034187ed29e..0444fd46028e 100644
--- a/drivers/net/wireless/realtek/rtw88/main.h
+++ b/drivers/net/wireless/realtek/rtw88/main.h
@@ -2095,6 +2095,12 @@ struct rtw_dev {
struct work_struct ips_work;
struct work_struct fw_recovery_work;
struct work_struct update_beacon_work;
+ struct delayed_work csa_beacon_work;
+ struct ieee80211_vif *csa_vif;
+ struct ieee80211_vif *csa_wow_vif;
+ ktime_t csa_due;
+ u8 csa_count;
+ bool csa_retry;
/* used to protect txqs list */
spinlock_t txq_lock;
--
2.56.0
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH rtw-next v12 3/3] wifi: rtw88: time the countdown downloads from the TBTT
2026-11-17 23:26 [PATCH rtw-next v12 0/3] wifi: rtw88: channel switch in AP mode Mehmet Fide
2026-11-17 23:26 ` [PATCH rtw-next v12 1/3] wifi: rtw88: download the beacon the reserved page was built with Mehmet Fide
2026-11-17 23:26 ` [PATCH rtw-next v12 2/3] wifi: rtw88: support channel switch in AP mode Mehmet Fide
@ 2026-11-17 23:26 ` Mehmet Fide
2026-11-18 12:48 ` [PATCH rtw-next v12 0/3] wifi: rtw88: channel switch in AP mode Luka Gejak
3 siblings, 0 replies; 11+ messages in thread
From: Mehmet Fide @ 2026-11-17 23:26 UTC (permalink / raw)
To: Ping-Ke Shih
Cc: Luka Gejak, Bitterblue Smith, linux-wireless, linux-kernel, mehmet.fide
From: Mehmet Fide <mehmet.fide@screeningeagle.com>
The countdown downloads are queued one beacon interval apart, with no
relation to the TBTT. A download that runs late past the next TBTT
leaves a count out of the air.
Read the TSF after each download and queue the next step 10 ms after the
first TBTT that is at least 10 ms away. Every count that was downloaded,
the first one too, then has a TBTT to go out at; a download that runs
late delays the switch by a beacon interval instead of taking a count
off the air, and stations that took the time of the switch from an
earlier count then switch up to that interval before the AP. As with a
driver that fetches each beacon with ieee80211_beacon_get(), the first
CSA beacon carries the count after the first step.
The first count is downloaded the same way, not when mac80211 changes
the beacon: a download close to a TBTT keeps beacons off the air. On an
RTL8821CU and an RTL8822CU a TBTT during the download sent no beacon or
the old one. On an RTL8822CE a TBTT up to about 100 us before the
download sent none and the next beacon stayed out too, and with a count
of 2 no CSA beacon went out. A step, the one that finishes the switch
too, that would run less than 5 ms after a TBTT or less than 10 ms
before one waits until 10 ms after that TBTT instead; with a beacon
interval of 20 ms or less there is no room for that and the steps are
not held. The switch completes up to one beacon interval later. The
replay after a hardware restart still downloads at once.
The USB chips raise no TBTT interrupt, so the TSF register is read. The
beaconing interface is always on port 0: rtw_core_port_switch() moves
an AP there, an IBSS runs alone.
Signed-off-by: Mehmet Fide <mehmet.fide@screeningeagle.com>
---
drivers/net/wireless/realtek/rtw88/fw.c | 70 ++++++++++++++++---
drivers/net/wireless/realtek/rtw88/mac80211.c | 9 ++-
drivers/net/wireless/realtek/rtw88/main.h | 1 -
drivers/net/wireless/realtek/rtw88/reg.h | 1 +
4 files changed, 66 insertions(+), 15 deletions(-)
diff --git a/drivers/net/wireless/realtek/rtw88/fw.c b/drivers/net/wireless/realtek/rtw88/fw.c
index 0910a9c7d7bc..755c35747559 100644
--- a/drivers/net/wireless/realtek/rtw88/fw.c
+++ b/drivers/net/wireless/realtek/rtw88/fw.c
@@ -3,6 +3,7 @@
*/
#include <linux/iopoll.h>
+#include <linux/math64.h>
#include "main.h"
#include "coex.h"
@@ -1824,16 +1825,54 @@ bool rtw_fw_csa_active(struct rtw_dev *rtwdev)
return !!rtwdev->csa_vif;
}
-/* paced from the first download: a late one does not delay the next */
+#define RTW_CSA_TBTT_MARGIN_US 10000
+
+static u64 rtw_fw_read_tsf(struct rtw_dev *rtwdev)
+{
+ u32 hi, lo, tmp;
+
+ hi = rtw_read32(rtwdev, REG_TSFTR + 4);
+ lo = rtw_read32(rtwdev, REG_TSFTR);
+ tmp = rtw_read32(rtwdev, REG_TSFTR + 4);
+ if (tmp != hi) {
+ hi = tmp;
+ lo = rtw_read32(rtwdev, REG_TSFTR);
+ }
+
+ return ((u64)hi << 32) | lo;
+}
+
+/* how long to wait so that a step does not run next to a TBTT */
+static u32 rtw_fw_csa_hold(struct rtw_dev *rtwdev, u32 interval)
+{
+ u32 rem;
+
+ if (interval <= 2 * RTW_CSA_TBTT_MARGIN_US)
+ return 0;
+
+ div_u64_rem(rtw_fw_read_tsf(rtwdev), interval, &rem);
+ if (rem < RTW_CSA_TBTT_MARGIN_US / 2)
+ return RTW_CSA_TBTT_MARGIN_US - rem;
+ if (interval - rem < RTW_CSA_TBTT_MARGIN_US)
+ return interval - rem + RTW_CSA_TBTT_MARGIN_US;
+
+ return 0;
+}
+
+/* after the first TBTT that can send what was downloaded last */
static void rtw_fw_csa_queue(struct rtw_dev *rtwdev, struct ieee80211_vif *vif)
{
u32 interval = ieee80211_tu_to_usec(vif->bss_conf.beacon_int);
- s64 delay;
+ u32 delay, rem;
+
+ div_u64_rem(rtw_fw_read_tsf(rtwdev), interval, &rem);
+ delay = interval - rem;
+ if (delay < RTW_CSA_TBTT_MARGIN_US)
+ delay += interval;
- rtwdev->csa_due = ktime_add_us(rtwdev->csa_due, interval);
- delay = ktime_us_delta(rtwdev->csa_due, ktime_get());
ieee80211_queue_delayed_work(rtwdev->hw, &rtwdev->csa_beacon_work,
- usecs_to_jiffies(max(delay, 0)));
+ usecs_to_jiffies(delay +
+ RTW_CSA_TBTT_MARGIN_US));
}
void rtw_fw_csa_start(struct rtw_dev *rtwdev, struct ieee80211_vif *vif,
@@ -1848,7 +1887,6 @@ void rtw_fw_csa_start(struct rtw_dev *rtwdev, struct ieee80211_vif *vif,
rtwdev->csa_vif = vif;
rtwdev->csa_retry = retry;
rtwdev->csa_count = ieee80211_beacon_cntdwn_is_complete(vif, 0) ? 1 : 0;
- rtwdev->csa_due = ktime_get();
rtw_fw_csa_queue(rtwdev, vif);
}
@@ -1884,6 +1922,7 @@ void rtw_fw_csa_beacon_work(struct work_struct *work)
struct rtw_dev *rtwdev = container_of(work, struct rtw_dev,
csa_beacon_work.work);
struct ieee80211_vif *vif;
+ u32 hold;
u8 count;
mutex_lock(&rtwdev->mutex);
@@ -1892,12 +1931,21 @@ void rtw_fw_csa_beacon_work(struct work_struct *work)
if (!vif || !vif->bss_conf.csa_active)
goto out;
- if (!rtwdev->csa_retry) {
- if (rtwdev->csa_count == 1) {
- ieee80211_csa_finish(vif, 0);
- goto out;
- }
+ hold = rtw_fw_csa_hold(rtwdev,
+ ieee80211_tu_to_usec(vif->bss_conf.beacon_int));
+ if (hold) {
+ ieee80211_queue_delayed_work(rtwdev->hw,
+ &rtwdev->csa_beacon_work,
+ usecs_to_jiffies(hold));
+ goto out;
+ }
+
+ if (!rtwdev->csa_retry && rtwdev->csa_count == 1) {
+ ieee80211_csa_finish(vif, 0);
+ goto out;
+ }
+ if (!rtwdev->csa_retry) {
count = ieee80211_beacon_update_cntdwn(vif, 0);
if (!count)
goto out;
diff --git a/drivers/net/wireless/realtek/rtw88/mac80211.c b/drivers/net/wireless/realtek/rtw88/mac80211.c
index 20969dd689df..b918e7041abe 100644
--- a/drivers/net/wireless/realtek/rtw88/mac80211.c
+++ b/drivers/net/wireless/realtek/rtw88/mac80211.c
@@ -392,7 +392,7 @@ static void rtw_ops_bss_info_changed(struct ieee80211_hw *hw,
struct rtw_coex *coex = &rtwdev->coex;
struct rtw_coex_stat *coex_stat = &coex->stat;
u32 config = 0;
- int ret;
+ int ret = 0;
mutex_lock(&rtwdev->mutex);
@@ -447,8 +447,11 @@ static void rtw_ops_bss_info_changed(struct ieee80211_hw *hw,
if (changed & BSS_CHANGED_BEACON) {
rtw_set_dtim_period(rtwdev, conf->dtim_period);
- ret = rtw_fw_download_rsvd_page(rtwdev);
- rtw_send_rsvd_page_h2c(rtwdev);
+ /* the countdown downloads its beacons after a TBTT */
+ if (!conf->csa_active || changed & BSS_CHANGED_BEACON_ENABLED) {
+ ret = rtw_fw_download_rsvd_page(rtwdev);
+ rtw_send_rsvd_page_h2c(rtwdev);
+ }
/*
* A beacon with CSA starts the countdown, also when a restart
* replays it. A beacon without CSA ends it.
diff --git a/drivers/net/wireless/realtek/rtw88/main.h b/drivers/net/wireless/realtek/rtw88/main.h
index 0444fd46028e..dc3f6d05ac44 100644
--- a/drivers/net/wireless/realtek/rtw88/main.h
+++ b/drivers/net/wireless/realtek/rtw88/main.h
@@ -2098,7 +2098,6 @@ struct rtw_dev {
struct delayed_work csa_beacon_work;
struct ieee80211_vif *csa_vif;
struct ieee80211_vif *csa_wow_vif;
- ktime_t csa_due;
u8 csa_count;
bool csa_retry;
diff --git a/drivers/net/wireless/realtek/rtw88/reg.h b/drivers/net/wireless/realtek/rtw88/reg.h
index afcdb66fdb9a..3ff4ae0885ef 100644
--- a/drivers/net/wireless/realtek/rtw88/reg.h
+++ b/drivers/net/wireless/realtek/rtw88/reg.h
@@ -506,6 +506,7 @@
#define REG_USTIME_TSF 0x055C
#define REG_BCN_MAX_ERR 0x055D
#define REG_RXTSF_OFFSET_CCK 0x055E
+#define REG_TSFTR 0x0560
#define REG_MISC_CTRL 0x0577
#define BIT_EN_FREE_CNT BIT(3)
#define BIT_DIS_SECOND_CCA (BIT(0) | BIT(1))
--
2.56.0
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH rtw-next v12 2/3] wifi: rtw88: support channel switch in AP mode
2026-11-17 23:26 ` [PATCH rtw-next v12 2/3] wifi: rtw88: support channel switch in AP mode Mehmet Fide
@ 2026-11-18 7:55 ` Mehmet Fide
2026-11-18 8:19 ` Luka Gejak
1 sibling, 0 replies; 11+ messages in thread
From: Mehmet Fide @ 2026-11-18 7:55 UTC (permalink / raw)
To: Ping-Ke Shih
Cc: Luka Gejak, Bitterblue Smith, linux-wireless, linux-kernel, mehmet.fide
Sashiko found a hole here: if the download of the count of 1 fails and
beaconing goes off and on before the retry, as for an off-channel
period, rtw_ops_bss_info_changed() restarts the countdown with retry
false, and the work finishes the switch without the count of 1 ever
reaching the firmware.
With a test build that fails that download and an off-channel period
of 40 ms during a countdown of 2, this happened in 9 of 20 switches on
an RTL8822CE and an RTL8822BU. Passing rtwdev->csa_retry there instead
of false keeps the retry: 0 of 20. v13 will have the fix, please do not
apply v12.
Mehmet
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH rtw-next v12 2/3] wifi: rtw88: support channel switch in AP mode
2026-11-17 23:26 ` [PATCH rtw-next v12 2/3] wifi: rtw88: support channel switch in AP mode Mehmet Fide
2026-11-18 7:55 ` Mehmet Fide
@ 2026-11-18 8:19 ` Luka Gejak
2026-11-18 8:33 ` Mehmet Fide
1 sibling, 1 reply; 11+ messages in thread
From: Luka Gejak @ 2026-11-18 8:19 UTC (permalink / raw)
To: Mehmet Fide, Ping-Ke Shih
Cc: Bitterblue Smith, linux-wireless, linux-kernel, mehmet.fide
Hi Mehmet,
One more thing in addition to sashiko's comment.
On November 18, 2026 12:26:23 AM GMT+01:00, Mehmet Fide
<mehmet.fide@gmail.com> wrote:
> @@ -493,11 +513,17 @@ static void rtw_ops_stop_ap(struct ieee80211_hw *hw,
> struct rtw_dev *rtwdev = hw->priv;
>
> mutex_lock(&rtwdev->mutex);
> + rtw_fw_csa_stop(rtwdev, vif);
> rtw_write32_clr(rtwdev, REG_TCR, BIT_TCR_UPDATE_HGQMD);
> rtw_write16(rtwdev, REG_ATIMWND, ATIMWND_DEFAULT);
> rtwdev->ap_active = false;
> - if (!rtw_core_check_sta_active(rtwdev))
> + if (!rtw_core_check_sta_active(rtwdev)) {
> rtw_clear_op_chan(rtwdev);
> + } else {
> + /* what a countdown may have held back */
> + rtw_fw_download_rsvd_page(rtwdev);
> + rtw_send_rsvd_page_h2c(rtwdev);
> + }
As far as I can see, this check can still miss the station.
rtw_core_check_sta_active() uses rtw_iterate_vifs(), whose collecting
callback skips an interface if its GFP_ATOMIC allocation fails.
If the station associated after the last countdown download, its page
update was deferred above. Skipping that station here leaves the
countdown cancelled without refreshing those templates or sending their
locations to the firmware. There is no next work to carry the update.
I think the presence check is better fixed in
rtw_core_check_sta_active(). Its callback only reads interface state, so
could it use an atomic interface iterator without allocating entries?
Best regards,
Luka Gejak
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH rtw-next v12 2/3] wifi: rtw88: support channel switch in AP mode
2026-11-18 8:19 ` Luka Gejak
@ 2026-11-18 8:33 ` Mehmet Fide
2026-11-18 9:14 ` Ping-Ke Shih
2026-11-18 9:14 ` Luka Gejak
0 siblings, 2 replies; 11+ messages in thread
From: Mehmet Fide @ 2026-11-18 8:33 UTC (permalink / raw)
To: Luka Gejak, Ping-Ke Shih
Cc: Bitterblue Smith, linux-wireless, linux-kernel, mehmet.fide
Hi Luka,
> I think the presence check is better fixed in
> rtw_core_check_sta_active(). Its callback only reads interface state, so
> could it use an atomic interface iterator without allocating entries?
Right, the callback does not sleep, so rtw_iterate_vifs_atomic() works
there. The check is older than this series: since commit 96fbb84de4ff
("wifi: rtw88: handle station mode concurrent scan with AP mode") a
failed allocation also makes rtw_clear_op_chan() drop the operating
channel of an associated station, on BSS_CHANGED_BSSID and in
rtw_ops_stop_ap().
Ping-Ke, Luka: would you take that as a separate fix for rtw-next, or as
a patch before this one in v13?
Mehmet
^ permalink raw reply [flat|nested] 11+ messages in thread
* RE: [PATCH rtw-next v12 2/3] wifi: rtw88: support channel switch in AP mode
2026-11-18 8:33 ` Mehmet Fide
@ 2026-11-18 9:14 ` Ping-Ke Shih
2026-11-18 9:55 ` Luka Gejak
2026-11-18 9:14 ` Luka Gejak
1 sibling, 1 reply; 11+ messages in thread
From: Ping-Ke Shih @ 2026-11-18 9:14 UTC (permalink / raw)
To: Mehmet Fide, Luka Gejak
Cc: Bitterblue Smith, linux-wireless, linux-kernel, mehmet.fide
Mehmet Fide <mehmet.fide@gmail.com> wrote:
> > I think the presence check is better fixed in
> > rtw_core_check_sta_active(). Its callback only reads interface state, so
> > could it use an atomic interface iterator without allocating entries?
>
> Right, the callback does not sleep, so rtw_iterate_vifs_atomic() works
> there. The check is older than this series: since commit 96fbb84de4ff
> ("wifi: rtw88: handle station mode concurrent scan with AP mode") a
> failed allocation also makes rtw_clear_op_chan() drop the operating
> channel of an associated station, on BSS_CHANGED_BSSID and in
> rtw_ops_stop_ap().
>
> Ping-Ke, Luka: would you take that as a separate fix for rtw-next, or as
> a patch before this one in v13?
I think rtw_core_check_sta_active() is used under wiphy lock, we can
migrate to use for_each_active_interface() with lockdep_assert_wiphy()
as a separate patch.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH rtw-next v12 2/3] wifi: rtw88: support channel switch in AP mode
2026-11-18 8:33 ` Mehmet Fide
2026-11-18 9:14 ` Ping-Ke Shih
@ 2026-11-18 9:14 ` Luka Gejak
1 sibling, 0 replies; 11+ messages in thread
From: Luka Gejak @ 2026-11-18 9:14 UTC (permalink / raw)
To: Mehmet Fide, Ping-Ke Shih
Cc: Bitterblue Smith, linux-wireless, linux-kernel, mehmet.fide
On November 18, 2026 9:33:28 AM GMT+01:00, Mehmet Fide
<mehmet.fide@gmail.com> wrote:
>Hi Luka,
>
>> I think the presence check is better fixed in
>> rtw_core_check_sta_active(). Its callback only reads interface state, so
>> could it use an atomic interface iterator without allocating entries?
>
>Right, the callback does not sleep, so rtw_iterate_vifs_atomic() works
>there. The check is older than this series: since commit 96fbb84de4ff
>("wifi: rtw88: handle station mode concurrent scan with AP mode") a
>failed allocation also makes rtw_clear_op_chan() drop the operating
>channel of an associated station, on BSS_CHANGED_BSSID and in
>rtw_ops_stop_ap().
>
>Ping-Ke, Luka: would you take that as a separate fix for rtw-next, or as
>a patch before this one in v13?
>
>Mehmet
>
I am ok with either, so as far as I am concerned do whatever is easier to
you.
Best regards,
Luka Gejak
^ permalink raw reply [flat|nested] 11+ messages in thread
* RE: [PATCH rtw-next v12 2/3] wifi: rtw88: support channel switch in AP mode
2026-11-18 9:14 ` Ping-Ke Shih
@ 2026-11-18 9:55 ` Luka Gejak
0 siblings, 0 replies; 11+ messages in thread
From: Luka Gejak @ 2026-11-18 9:55 UTC (permalink / raw)
To: Ping-Ke Shih, Mehmet Fide
Cc: Bitterblue Smith, linux-wireless, linux-kernel, mehmet.fide
On November 18, 2026 10:14:17 AM GMT+01:00, Ping-Ke Shih
<pkshih@realtek.com> wrote:
>Mehmet Fide <mehmet.fide@gmail.com> wrote:
>> > I think the presence check is better fixed in
>> > rtw_core_check_sta_active(). Its callback only reads interface state,
>so
>> > could it use an atomic interface iterator without allocating entries?
>>
>> Right, the callback does not sleep, so rtw_iterate_vifs_atomic() works
>> there. The check is older than this series: since commit 96fbb84de4ff
>> ("wifi: rtw88: handle station mode concurrent scan with AP mode") a
>> failed allocation also makes rtw_clear_op_chan() drop the operating
>> channel of an associated station, on BSS_CHANGED_BSSID and in
>> rtw_ops_stop_ap().
>>
>> Ping-Ke, Luka: would you take that as a separate fix for rtw-next, or as
>> a patch before this one in v13?
>
>I think rtw_core_check_sta_active() is used under wiphy lock, we can
>migrate to use for_each_active_interface() with lockdep_assert_wiphy()
>as a separate patch.
>
Works for me.
Best regards,
Luka Gejak
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH rtw-next v12 0/3] wifi: rtw88: channel switch in AP mode
2026-11-17 23:26 [PATCH rtw-next v12 0/3] wifi: rtw88: channel switch in AP mode Mehmet Fide
` (2 preceding siblings ...)
2026-11-17 23:26 ` [PATCH rtw-next v12 3/3] wifi: rtw88: time the countdown downloads from the TBTT Mehmet Fide
@ 2026-11-18 12:48 ` Luka Gejak
3 siblings, 0 replies; 11+ messages in thread
From: Luka Gejak @ 2026-11-18 12:48 UTC (permalink / raw)
To: Mehmet Fide, Ping-Ke Shih
Cc: Bitterblue Smith, linux-wireless, linux-kernel, mehmet.fide
On November 18, 2026 12:26:21 AM GMT+01:00, Mehmet Fide
<mehmet.fide@gmail.com> wrote:
>From: Mehmet Fide <mehmet.fide@screeningeagle.com>
>
>An rtw88 AP cannot change its channel: the driver does not announce
>channel switch support, so hostapd's CHAN_SWITCH is refused and the
>only way is to tear the AP down. The series fixes the beacon download
>the reserved page build makes twice, counts a switch down on top of
>the firmware's beacon page, and times the countdown downloads from the
>TBTT so that every count goes out on the air.
>
>v12 applies on top of patches 1-4 of the firmware recovery fixes [2];
>patch 5 of [2] is superseded by commit 3f2238709f5d ("wifi: rtw88:
>clear RTW_FLAG_RESTARTING on stop and start failure") in rtw-next.
>
>v12 was tested with [2] and the mac80211 patch [1] on top, [1] is in
>mainline now as commit 12f97c692dcb, on a kernel with PROVE_LOCKING,
>DEBUG_ATOMIC_SLEEP, kmemleak and KFENCE, on an RTL8821CU (two
>adapters), an RTL8822BU, an RTL8822CU (USB) and an RTL8822CE (PCIe)
>with hostapd as AP, the beacons sniffed from a second machine, on
>rtw-next fb51e39dfaea:
>
>- the regression suite on the five adapters on 2.4 and 5 GHz:
> beacons, association, power save, scans, a hardware restart,
> rebinding, a firmware crash on the RTL8822CE, and 300 switches with
> counts 2, 5 and 10. The AP switched in 300 of 300 and every count
> went out in 296; the other four were on 2.4 GHz on the RTL8822BU and
> the RTL8822CU, which lost 46 % and 2.4 % of their beacons in the
> beacon tests of the same run. One missing count was the single CSA
> beacon of a count of 2, and the station lost the AP. In 30 more
> switches with a count of 2 on that adapter every count went out, and
> in 29 of 30 with the v12 of before [2]. In two more switches with a
> count of 2 the station lost the AP although the sniffers heard its
> single CSA beacon; the same happens with v11. No lockdep report, and
> no kmemleak report from the drivers
>- a test build that fails the first download of a countdown on purpose,
> with counts 2 and 5 on the RTL8821CU, the RTL8822BU and the RTL8822CE:
> the AP switched in 30 of 30 and every count went out in 25. In 15
> more runs each, the v12 of before [2] and this one lost counts in 2
> of 15 each. With v11 a count of 2 switched without any CSA beacon in
> 5 of 5
>- the same build holding the first step back by 95 ms: the AP switched
> in 30 of 30 and every count went out in 27. With v11, held back by 90
> to 100 ms, a count of 2 switched without any CSA beacon in 10 of 12
>- an IBSS left during its countdown, without [1] and with a monitor
> interface keeping the radio up, on four adapters: the countdown work
> stops and a scan works; with v11 the work ran on and every scan was
> refused
>- a station interface associated first, an AP started next to it and
> stopped during a countdown of 50 on the RTL8822CE and the RTL8822CU:
> the station stayed associated in the 5 runs in which it had
> associated
>- an off-channel period of 300 ms during a countdown of 20 on the
> RTL8821CU: the AP switched in 3 of 3. The beacons after an off-channel
> period are partly missing also without the series
>
>Every count missing in the first three items fell on a TBTT at which
>neither sniffer heard any beacon, as happens on these adapters without
>a countdown too.
>
>The RTL8822BU and the RTL8822CE ran again on rtw-next badf4c3c7679:
>
>- the regression suite on 2.4 and 5 GHz with 36 switches: every
> count went out, lockdep stayed on, no kmemleak report from the
> drivers
>- a firmware crash during a countdown of 40 on the RTL8822CE, the AP
> alone and next to an associated station interface: no lockdep or
> DEBUG_ATOMIC_SLEEP report; the AP alone ended on its new channel
>- a firmware crash with the hardware restart held back by 4 s in a test
> build, the AP and its interface stopped in between: the restart flag
> was clear afterwards and the next crash was recovered, 2 of 2
>
>In IBSS a countdown leaves more beacons off the air where the channel
>is busy; the count goes on after each of them. With 20 s with and
>without a countdown taking turns on one channel, the beacons that no
>sniffer heard are, on 5 GHz, 1.9 % and 3.5 % of the countdown of an
>RTL8821CU and the RTL8822BU against 0.3 % and 0.2 % without one, and
>none on the RTL8822C; on 2.4 GHz 6.6 to 12.1 % against 2.7 to 7.2 % on
>the five adapters. An AP shows no such difference. The cause is the
>beacon function, which rtw_fw_write_data_rsvd_page() switches off for
>the download: left on for the count steps, the difference is gone on
>5 GHz, but one RTL8821CU AP then lost its station in 6 of 110
>switches with counts 5 and 10 on 2.4 GHz, and in none of 100 without
>the change, so the series leaves the download as it is. The TSF
>stands still for the download as well, 2.8 ms on the USB chips and
>0.3 ms on the RTL8822CE, so the beacons of a countdown are about
>105 ms apart on USB.
>
>Not run for v12: Windows stations. The WoWLAN paths are built but not
>run: after a suspend the PCIe card of the test board is inaccessible and
>the USB adapters are probed again. Without the series as well, an IBSS
>interface stops beaconing after a scan. Patch 1 changed only in its
>commit message since v6.
>
>v12:
>- 2/3: a failed download of a count is repeated before the next step,
> and the switch completes only after the count of 1 reached the
> firmware (Luka). The work steps with the count that
> ieee80211_beacon_update_cntdwn() returns and no longer calls
> ieee80211_beacon_cntdwn_is_complete(), which warned when the AP
> stopped in between (Sashiko)
>- 2/3: the work never clears csa_vif, and rtw_ops_stop_ap() downloads
> the page again whenever a station interface stays (Luka)
>- 2/3: the countdown stops while beaconing is disabled, for an IBSS
> that is left or an off-channel period, and starts again when it is
> enabled with the switch still announced (Sashiko)
>- 2/3: WoWLAN suspend keeps the interface of the countdown and resume
> starts it again, without iterating the interfaces (Luka)
>- 2/3: a failed download of the replay after a hardware restart is
> repeated before the next step
>- 3/3: each step reads the TSF after its download and the next one runs
> 10 ms after the first TBTT at least 10 ms away; no step runs less than
> 5 ms after or 10 ms before a TBTT, the one that finishes the switch
> included. A late step delays the switch instead of taking a count off
> the air (Luka)
>- 3/3: the commit message says which count the first CSA beacon
> carries (Sashiko)
>- 1/3: the commit message says why there is no Fixes tag and what
> mac80211 reports for the double fetch (Sashiko)
>- rebased on patches 1-4 of [2]
>
>v11:
>- 2/3: the channel_switch_beacon op is gone, the BSS_CHANGED_BEACON
> path starts every countdown (Luka)
>- 2/3: rtw_fw_csa_start() does nothing on a device that is not
> running
>- 2/3: only the countdown work advances the count. The beacon of the
> reserved page is fetched as a template while a switch is announced,
> so the replay after a firmware recovery and the page of the WoWLAN
> firmware repeat the count that is on the air
>- 2/3: an AP that stops in its countdown downloads the reserved page
> again if a station interface stays behind; the downloads the
> countdown held back were lost for it
>- 3/3: the first download shares the branch of a late one, and the
> comment says what the branch catches (Luka)
>- the beacon interval that stays at 100 TU on the air is fixed by a
> separate patch (Luka)
>- rebased on rtw-next
>
>v10:
>- 2/3: rtw_core_stop() clears csa_vif and cancels the countdown work
> again once it has the mutex back, for a switch started while the
> mutex was dropped (Luka)
>- 3/3: the first count is downloaded by the countdown work, 10 ms
> after the next TBTT, and no longer when mac80211 changes the beacon.
> My reply on v9 said v10 only drops the back-off; that is not enough
> on the RTL8822CE, where a TBTT shortly before the download sends no
> beacon and the next one stays out too, so a count of 2 went out
> without a CSA beacon (Luka). The switch completes up to one beacon
> interval later. Ping-Ke's Acked-by and Luka's Reviewed-by are
> dropped for the changed code
>- rebased on rtw-next
>
>v9:
>- 2/3: the countdown starts again after a WoWLAN resume that worked,
> which mac80211 follows with no replay (Luka); Ping-Ke's Acked-by is
> dropped for the new code
>- 3/3: Acked-by from Ping-Ke on v8, Reviewed-by from Luka
>- an IBSS left during its countdown and joined again kept csa_active;
> that is mac80211's, fixed by a separate patch [1] (Luka)
>
>v8:
>- 2/3: Acked-by from Ping-Ke
>- 3/3: the TSF read retries once instead of looping, rtw_fw_csa_queue()
> reads the TSF once also on start, the port 0 comment is gone, empty
> lines where asked (Ping-Ke)
>
>v7:
>- new patch 3: the countdown downloads are timed from the TSF, 10 ms
> after each TBTT, so a download that runs late by less than a beacon
> interval still reaches the firmware before the next beacon; one
> later than that is followed by its successor at once. Ping-Ke's
> question on v6: with the absolute due time a late download and its
> successor could land in one beacon period and leave a count out of
> the air
>- patch 3 takes a TBTT within the margin before the start as the one
> that sent the countdown template: a TBTT between the template
> download and the first TSF read made the stations see one count
> twice
>- patch 2 keeps csa_vif until the beacon after the switch: a TIM
> update before it fetched one beacon past count 1 and hit the WARN
> in ieee80211_beacon_update_cntdwn()
>- rebased on rtw-next
>
>v6:
>- the wiphy work patch of v5 is gone: the countdown work is an
> ieee80211 delayed work and csa_vif is driver state, both under the
> driver mutex, so rtw88 takes no wiphy lock anywhere (Ping-Ke)
>- rtw_core_stop() cancels the countdown work and clears csa_vif, which
> covers the IPS path and the firmware recovery; the wiphy_lock() in
> the recovery work is gone (Ping-Ke)
>- the BSS_CHANGED_BEACON path says why it starts the countdown, the
> replay after a hardware restart, and stops it when the beacon comes
> back without a switch announced (Ping-Ke)
>- the downloads are paced from the first one with an absolute due
> time. Queued after each download, they drifted by about 10 ms per
> beacon interval on the ordered mac80211 workqueue; on a count of 50
> the AP switched half a second after its station had, and the
> station re-associated
>
>v5:
>- 2/3 is new: update_beacon_work becomes a wiphy work, so that it can
> look at the channel switch state under the wiphy lock; it checks
> RTW_FLAG_RUNNING instead of being cancelled in rtw_core_stop(), which
> runs without the wiphy lock on the IPS path (Ping-Ke); reverted in v6
>- 3/3: rtw_fw_csa_active/start/stop() assert the wiphy lock (Ping-Ke);
> reverted in v6, they assert the driver mutex
>- 3/3: hw_scan() takes the mutex with guard() (Ping-Ke)
>- 3/3: a comment on the association download names the STA+AP
> combination it skips the download for (Ping-Ke)
>- the whole set ran on a PROVE_LOCKING kernel without a lockdep report:
> switches with counts 1 to 100, hostapd stopped and restarted during
> a countdown, scans during a countdown, a firmware crash during a
> countdown, three stop/idle/start cycles, IBSS, 50 switches with a
> station attached, and on the RTL8822CU a station interface
> associating while the AP interface counted down
>
>v4:
>- 1/2: Reviewed-by from Luka
>- 2/2: the countdown work is back in the device, initialised once,
> with csa_vif naming the interface; no interface iteration and no
> lookup through the reserved page any more (Ping-Ke)
>- 2/2: the countdown is cancelled before a firmware recovery restarts
> the hardware, instead of guarding the work with flags (Ping-Ke)
>- 2/2: the page download on association skips a running countdown,
> like the TIM update and the PG backup (Luka)
>- 2/2: the scan refusal comes before the scan offload test, so that
> firmware without scan offload does not fall back to a software scan
> during a countdown (Luka)
>
>v3:
>- 1/2: the beacon out-pointer is initialised in the caller (Luka)
>- 2/2: the countdown work lives in the interface, remove_interface
> cancels it unconditionally, the queue wrapper and the comments are
> gone (Ping-Ke)
>- 2/2: the TIM update and the PG backup on set_key skip the page
> download while a switch is announced; every beacon fetch advances
> the countdown (Luka)
>- 2/2: the commit message names the refused hardware scan (Ping-Ke)
>
>v2:
>- 2/2: a hardware scan is refused while a switch is announced
>- the rtw89 mention is gone from the cover
>
>[1]
>https://lore.kernel.org/linux-wireless/20261025193615.1123718-1-mehmet.fide@gmail.com/
>[2]
>https://lore.kernel.org/linux-wireless/20261117171003.1840491-1-mehmet.fide@gmail.com/
>
>Mehmet Fide (3):
> wifi: rtw88: download the beacon the reserved page was built with
> wifi: rtw88: support channel switch in AP mode
> wifi: rtw88: time the countdown downloads from the TBTT
>
> drivers/net/wireless/realtek/rtw88/fw.c | 182 ++++++++++++++++--
> drivers/net/wireless/realtek/rtw88/fw.h | 5 +
> drivers/net/wireless/realtek/rtw88/mac80211.c | 60 +++++-
> drivers/net/wireless/realtek/rtw88/main.c | 9 +-
> drivers/net/wireless/realtek/rtw88/main.h | 5 +
> drivers/net/wireless/realtek/rtw88/reg.h | 1 +
> 6 files changed, 237 insertions(+), 25 deletions(-)
>
>
>base-commit: badf4c3c7679871a50cff1150f66e63187201757
>prerequisite-patch-id: 61a489b0da7e1d0028cc1c72c0ecd1301f3b8ec7
>prerequisite-patch-id: 5040450eb00c500bda0b95bb35bd821721f149ee
>prerequisite-patch-id: 8c5c1393ce4b56fecf3238b21bd34fcdbae8769a
>prerequisite-patch-id: 6ecc624d0c38a71c64993f725622e02ae2ad1629
>--
>2.56.0
>
>
I forgot to mention, v12 doesn't apply to the rtw-next branch, so it needs
a rebase.
Best regards,
Luka Gejak
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2026-11-18 12:48 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-17 23:26 [PATCH rtw-next v12 0/3] wifi: rtw88: channel switch in AP mode Mehmet Fide
2026-11-17 23:26 ` [PATCH rtw-next v12 1/3] wifi: rtw88: download the beacon the reserved page was built with Mehmet Fide
2026-11-17 23:26 ` [PATCH rtw-next v12 2/3] wifi: rtw88: support channel switch in AP mode Mehmet Fide
2026-11-18 7:55 ` Mehmet Fide
2026-11-18 8:19 ` Luka Gejak
2026-11-18 8:33 ` Mehmet Fide
2026-11-18 9:14 ` Ping-Ke Shih
2026-11-18 9:55 ` Luka Gejak
2026-11-18 9:14 ` Luka Gejak
2026-11-17 23:26 ` [PATCH rtw-next v12 3/3] wifi: rtw88: time the countdown downloads from the TBTT Mehmet Fide
2026-11-18 12:48 ` [PATCH rtw-next v12 0/3] wifi: rtw88: channel switch in AP mode Luka Gejak
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®