From: Paolo Bonzini <pbonzini@redhat.com>
To: "Kang, Luwei" <luwei.kang@intel.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>
Cc: "tglx@linutronix.de" <tglx@linutronix.de>,
"mingo@redhat.com" <mingo@redhat.com>,
"hpa@zytor.com" <hpa@zytor.com>,
"x86@kernel.org" <x86@kernel.org>,
"rkrcmar@redhat.com" <rkrcmar@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"joro@8bytes.org" <joro@8bytes.org>
Subject: Re: [PATCH v5 11/11] KVM: x86: Disable Intel Processor Trace when VMXON in L1 guest
Date: Mon, 19 Mar 2018 10:05:15 +0100 [thread overview]
Message-ID: <6a7c53f0-8c47-0fe1-27f2-141a15ebdcff@redhat.com> (raw)
In-Reply-To: <82D7661F83C1A047AF7DC287873BF1E167EFC16F@SHSMSX101.ccr.corp.intel.com>
On 19/03/2018 08:31, Kang, Luwei wrote:
>>> + if (pt_mode == PT_MODE_HOST_GUEST) {
>> This would be vmx_pt_supported(), but I think it's better to remove that function and just test pt_mode ==
>> PT_MODE_HOST_GUEST everywhere (or !=).
> Hi Paolo,
> There have so many vmx_pt_supported() invoked in MSRs read/write (patch 9) patch and I think it can be replaced by pt_mode check.
> But I think this function need to be reserved in patch 5(cpuid emulation). What is your opinion?
Yes, the function pointer needs to stay.
Paolo
prev parent reply other threads:[~2018-03-19 9:05 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-04 12:07 [PATCH v5 00/11] Intel Processor Trace virtulization enabling Luwei Kang
2018-03-04 12:07 ` [PATCH v5 01/11] perf/x86/intel/pt: Move Intel-PT MSR bit definitions to a public header Luwei Kang
2018-03-04 12:07 ` [PATCH v5 02/11] perf/x86/intel/pt: Change pt_cap_get() to a public function Luwei Kang
2018-03-04 12:07 ` [PATCH v5 03/11] perf/x86/intel/pt: Introduce a new function to get the capability of Intel PT Luwei Kang
2018-03-16 17:28 ` Paolo Bonzini
2018-03-19 7:17 ` Kang, Luwei
2018-03-19 9:04 ` Paolo Bonzini
2018-03-04 12:07 ` [PATCH v5 04/11] KVM: x86: Add Intel Processor Trace virtualization mode Luwei Kang
2018-03-04 12:07 ` [PATCH v5 05/11] KVM: x86: Add Intel Processor Trace cpuid emulation Luwei Kang
2018-03-04 12:07 ` [PATCH v5 06/11] KVM: x86: Add Intel processor trace context for each vcpu Luwei Kang
2018-03-04 12:07 ` [PATCH v5 07/11] KVM: x86: Implement Intel Processor Trace context switch Luwei Kang
2018-03-04 12:07 ` [PATCH v5 08/11] KVM: x86: Introduce a function to initialize the PT configuration Luwei Kang
2018-03-04 12:07 ` [PATCH v5 09/11] KVM: x86: Implement Intel Processor Trace MSRs read/write Luwei Kang
2018-03-04 12:07 ` [PATCH v5 10/11] KVM: x86: Set intercept for Intel PT MSRs Luwei Kang
2018-03-04 12:07 ` [PATCH v5 11/11] KVM: x86: Disable Intel Processor Trace when VMXON in L1 guest Luwei Kang
2018-03-16 17:30 ` Paolo Bonzini
2018-03-19 7:31 ` Kang, Luwei
2018-03-19 9:05 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6a7c53f0-8c47-0fe1-27f2-141a15ebdcff@redhat.com \
--to=pbonzini@redhat.com \
--cc=hpa@zytor.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luwei.kang@intel.com \
--cc=mingo@redhat.com \
--cc=rkrcmar@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®