From: Paolo Bonzini <pbonzini@redhat.com>
To: Luwei Kang <luwei.kang@intel.com>, kvm@vger.kernel.org
Cc: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
x86@kernel.org, rkrcmar@redhat.com, linux-kernel@vger.kernel.org,
joro@8bytes.org
Subject: Re: [PATCH v5 03/11] perf/x86/intel/pt: Introduce a new function to get the capability of Intel PT
Date: Fri, 16 Mar 2018 18:28:03 +0100 [thread overview]
Message-ID: <98515f5f-9c8a-8e1a-4fef-c9a8a0e9e8f5@redhat.com> (raw)
In-Reply-To: <1520165241-15819-4-git-send-email-luwei.kang@intel.com>
On 04/03/2018 13:07, Luwei Kang wrote:
> +u32 pt_cap_get_ex(u32 *caps, enum pt_capabilities cap)
> +{
> + struct pt_cap_desc *cd = &pt_caps[cap];
> + u32 c = caps[cd->leaf * PT_CPUID_REGS_NUM + cd->reg];
> + unsigned int shift = __ffs(cd->mask);
> +
> + return (c & cd->mask) >> shift;
> +}
> +EXPORT_SYMBOL_GPL(pt_cap_get_ex);
> +
You should change pt_cap_get to use this function. Also, "_ex" is not a
very common suffix, so perhaps you can call it __pt_cap_get.
I don't have any other comments on patches 1-3, so when you resend we
can ask the x86 maintainers for approval.
Thanks,
Paolo
next prev parent reply other threads:[~2018-03-16 17:28 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-04 12:07 [PATCH v5 00/11] Intel Processor Trace virtulization enabling Luwei Kang
2018-03-04 12:07 ` [PATCH v5 01/11] perf/x86/intel/pt: Move Intel-PT MSR bit definitions to a public header Luwei Kang
2018-03-04 12:07 ` [PATCH v5 02/11] perf/x86/intel/pt: Change pt_cap_get() to a public function Luwei Kang
2018-03-04 12:07 ` [PATCH v5 03/11] perf/x86/intel/pt: Introduce a new function to get the capability of Intel PT Luwei Kang
2018-03-16 17:28 ` Paolo Bonzini [this message]
2018-03-19 7:17 ` Kang, Luwei
2018-03-19 9:04 ` Paolo Bonzini
2018-03-04 12:07 ` [PATCH v5 04/11] KVM: x86: Add Intel Processor Trace virtualization mode Luwei Kang
2018-03-04 12:07 ` [PATCH v5 05/11] KVM: x86: Add Intel Processor Trace cpuid emulation Luwei Kang
2018-03-04 12:07 ` [PATCH v5 06/11] KVM: x86: Add Intel processor trace context for each vcpu Luwei Kang
2018-03-04 12:07 ` [PATCH v5 07/11] KVM: x86: Implement Intel Processor Trace context switch Luwei Kang
2018-03-04 12:07 ` [PATCH v5 08/11] KVM: x86: Introduce a function to initialize the PT configuration Luwei Kang
2018-03-04 12:07 ` [PATCH v5 09/11] KVM: x86: Implement Intel Processor Trace MSRs read/write Luwei Kang
2018-03-04 12:07 ` [PATCH v5 10/11] KVM: x86: Set intercept for Intel PT MSRs Luwei Kang
2018-03-04 12:07 ` [PATCH v5 11/11] KVM: x86: Disable Intel Processor Trace when VMXON in L1 guest Luwei Kang
2018-03-16 17:30 ` Paolo Bonzini
2018-03-19 7:31 ` Kang, Luwei
2018-03-19 9:05 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98515f5f-9c8a-8e1a-4fef-c9a8a0e9e8f5@redhat.com \
--to=pbonzini@redhat.com \
--cc=hpa@zytor.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luwei.kang@intel.com \
--cc=mingo@redhat.com \
--cc=rkrcmar@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®