mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* Re: UFS writing request failure handling
@ 2018-02-13 15:18 Bean Huo (beanhuo)
  0 siblings, 0 replies; 3+ messages in thread
From: Bean Huo (beanhuo) @ 2018-02-13 15:18 UTC (permalink / raw)
  To: Bart Van Assche; +Cc: linux-kernel, linux-scsi

Hi Bart
Thanks for your answer.
I looked at SCSI core source codes these days, UFS also follows SCSI core error handling.
There is already re-issue behavior, and assign 5 retries for each UFS request if there is error.

>
>On 02/12/18 04:21, Bean Huo (beanhuo) wrote
>> I am looking at UFS error handling, but I didn't notice re-issues
>> requests with UTP error to the host controller. According UFS host
>> spec, "host software either completes the request that had the error
>> and requests still outstanding with error to higher level software, or
>> re-issues these requests to the host controller". For the latest Linux
>> UFS driver, it belongs to former one? If I am wrong, please correct
>> me.
>
>Hello Bean,
>
>I'm afraid that reissuing a failed write forever could cause an infinite loop that
>makes e.g. user space processes unkillable or that could cause an orderly
>system shutdown to hang. I'm not sure that we want such behavior.
>
>If you want to learn more about how the SCSI core handles failed writes,
>please have a look at scsi_decide_disposition(). A possible approach to
>modify the error handling behavior is to stack a dm driver on top of the SCSI
>core that implements the desired behavior.
>
>Bart.

^ permalink raw reply	[flat|nested] 3+ messages in thread
* UFS writing request failure handling
@ 2018-02-12 12:21 Bean Huo (beanhuo)
  2018-02-12 18:13 ` Bart Van Assche
  0 siblings, 1 reply; 3+ messages in thread
From: Bean Huo (beanhuo) @ 2018-02-12 12:21 UTC (permalink / raw)
  To: linux-scsi; +Cc: linux-kernel

Hi, 
I am looking at UFS error handling, but I didn't notice re-issues requests with UTP error to the host controller.
According UFS host spec, "host software either completes the request that had the error and requests still outstanding 
with error to higher level software, or re-issues these requests to the host controller".
For the latest Linux UFS driver, it belongs to former one? 
If I am wrong, please correct me.
Thanks!

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-02-13 15:18 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-13 15:18 UFS writing request failure handling Bean Huo (beanhuo)
  -- strict thread matches above, loose matches on Subject: below --
2018-02-12 12:21 Bean Huo (beanhuo)
2018-02-12 18:13 ` Bart Van Assche

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®