mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH ath-next] wifi: ath12k: remove skb->data check in ath12k_wmi_process_tpc_stats()
@ 2026-07-29  1:15 Jeff Johnson
  2026-07-30  1:50 ` Baochen Qiang
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Jeff Johnson @ 2026-07-29  1:15 UTC (permalink / raw)
  To: Jeff Johnson; +Cc: linux-wireless, ath12k, linux-kernel, Jeff Johnson

Currently, ath12k_wmi_process_tpc_stats() has a !skb->data check.  This
check is pointless since skb->data is accessed by ath12k_wmi_op_rx() in
order to dispatch the message to this function, therefore it is always
non-NULL.

Remove the pointless check and its associated warning message.

Compile tested only.

Assisted-by: Claude:claude-sonnet-4-6
Signed-off-by: Jeff Johnson <jeff.johnson@oss.qualcomm.com>
---
 drivers/net/wireless/ath/ath12k/wmi.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/drivers/net/wireless/ath/ath12k/wmi.c b/drivers/net/wireless/ath/ath12k/wmi.c
index 2b707ffc1a20..cd3040b8388c 100644
--- a/drivers/net/wireless/ath/ath12k/wmi.c
+++ b/drivers/net/wireless/ath/ath12k/wmi.c
@@ -9973,11 +9973,6 @@ static void ath12k_wmi_process_tpc_stats(struct ath12k_base *ab,
 	u32 event_count;
 	int ret;
 
-	if (!skb->data) {
-		ath12k_warn(ab, "No data present in tpc stats event\n");
-		return;
-	}
-
 	if (skb->len < (sizeof(*fixed_param) + TLV_HDR_SIZE)) {
 		ath12k_warn(ab, "TPC stats event size invalid\n");
 		return;

---
base-commit: 32f39e331f889a0424f7a0a82893f628e2705727
change-id: 20260726-ath12k_wmi_process_tpc_stats-skb-check-5530899ab197


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH ath-next] wifi: ath12k: remove skb->data check in ath12k_wmi_process_tpc_stats()
  2026-07-29  1:15 [PATCH ath-next] wifi: ath12k: remove skb->data check in ath12k_wmi_process_tpc_stats() Jeff Johnson
@ 2026-07-30  1:50 ` Baochen Qiang
  2026-08-05 11:17 ` Rameshkumar Sundaram
  2026-09-03 19:02 ` Jeff Johnson
  2 siblings, 0 replies; 4+ messages in thread
From: Baochen Qiang @ 2026-07-30  1:50 UTC (permalink / raw)
  To: Jeff Johnson, Jeff Johnson; +Cc: linux-wireless, ath12k, linux-kernel



On 7/29/2026 9:15 AM, Jeff Johnson wrote:
> Currently, ath12k_wmi_process_tpc_stats() has a !skb->data check.  This
> check is pointless since skb->data is accessed by ath12k_wmi_op_rx() in
> order to dispatch the message to this function, therefore it is always
> non-NULL.
> 
> Remove the pointless check and its associated warning message.
> 
> Compile tested only.
> 
> Assisted-by: Claude:claude-sonnet-4-6
> Signed-off-by: Jeff Johnson <jeff.johnson@oss.qualcomm.com>

Reviewed-by: Baochen Qiang <baochen.qiang@oss.qualcomm.com>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH ath-next] wifi: ath12k: remove skb->data check in ath12k_wmi_process_tpc_stats()
  2026-07-29  1:15 [PATCH ath-next] wifi: ath12k: remove skb->data check in ath12k_wmi_process_tpc_stats() Jeff Johnson
  2026-07-30  1:50 ` Baochen Qiang
@ 2026-08-05 11:17 ` Rameshkumar Sundaram
  2026-09-03 19:02 ` Jeff Johnson
  2 siblings, 0 replies; 4+ messages in thread
From: Rameshkumar Sundaram @ 2026-08-05 11:17 UTC (permalink / raw)
  To: Jeff Johnson, Jeff Johnson; +Cc: linux-wireless, ath12k, linux-kernel

On 7/29/2026 6:45 AM, Jeff Johnson wrote:
> Currently, ath12k_wmi_process_tpc_stats() has a !skb->data check.  This
> check is pointless since skb->data is accessed by ath12k_wmi_op_rx() in
> order to dispatch the message to this function, therefore it is always
> non-NULL.
> 
> Remove the pointless check and its associated warning message.
> 
> Compile tested only.
> 
> Assisted-by: Claude:claude-sonnet-4-6
> Signed-off-by: Jeff Johnson <jeff.johnson@oss.qualcomm.com>
Reviewed-by: Rameshkumar Sundaram <rameshkumar.sundaram@oss.qualcomm.com>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH ath-next] wifi: ath12k: remove skb->data check in ath12k_wmi_process_tpc_stats()
  2026-07-29  1:15 [PATCH ath-next] wifi: ath12k: remove skb->data check in ath12k_wmi_process_tpc_stats() Jeff Johnson
  2026-07-30  1:50 ` Baochen Qiang
  2026-08-05 11:17 ` Rameshkumar Sundaram
@ 2026-09-03 19:02 ` Jeff Johnson
  2 siblings, 0 replies; 4+ messages in thread
From: Jeff Johnson @ 2026-09-03 19:02 UTC (permalink / raw)
  To: Jeff Johnson, Jeff Johnson; +Cc: linux-wireless, ath12k, linux-kernel


On Tue, 28 Jul 2026 18:15:24 -0700, Jeff Johnson wrote:
> Currently, ath12k_wmi_process_tpc_stats() has a !skb->data check.  This
> check is pointless since skb->data is accessed by ath12k_wmi_op_rx() in
> order to dispatch the message to this function, therefore it is always
> non-NULL.
> 
> Remove the pointless check and its associated warning message.
> 
> [...]

Applied, thanks!

[1/1] wifi: ath12k: remove skb->data check in ath12k_wmi_process_tpc_stats()
      commit: bd3e260f496adb0123076a237e5e72598dee0404

Best regards,
-- 
Jeff Johnson <jeff.johnson@oss.qualcomm.com>


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2026-09-03 19:02 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-07-29  1:15 [PATCH ath-next] wifi: ath12k: remove skb->data check in ath12k_wmi_process_tpc_stats() Jeff Johnson
2026-07-30  1:50 ` Baochen Qiang
2026-08-05 11:17 ` Rameshkumar Sundaram
2026-09-03 19:02 ` Jeff Johnson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®