Re: [RFC PATCH v1 02/10] KVM: s390: Honor storage keys when accessing guest memory

[Janis Schoetterl-Glausch <scgl@linux.ibm.com>]

On 1/20/22 11:27, Christian Borntraeger wrote:
> 
> 
> Am 18.01.22 um 15:38 schrieb Janosch Frank:
> [...]
>> /*
>> We'll do an actual access via the mv instruction which will return access errors to us so we don't need to check here.
>> */
> 
> Be slightly more verbose I guess. Something like
> We'll do an actual access via the mv instruction which will return access errors to us so we don't need to check here.
> By using key 0 all checks are skipped and no performance overhead occurs.
> 
> ?

Yes, I'll also mention that we implement storage protection override by retrying.
> 
>>> +    rc = guest_range_to_gpas(vcpu, ga, ar, gpas, len, asce, mode, 0);