From: Reinette Chatre <reinette.chatre@intel.com>
To: Jinjie Ruan <ruanjinjie@huawei.com>, <tony.luck@intel.com>,
<ben.horgan@arm.com>, <james.morse@arm.com>,
<Dave.Martin@arm.com>, <babu.moger@amd.com>, <bp@alien8.de>,
<tglx@linutronix.de>, <dave.hansen@linux.intel.com>
Cc: <x86@kernel.org>, <hpa@zytor.com>, <fustini@kernel.org>,
<fenghuay@nvidia.com>, <peternewman@google.com>,
<yu.c.chen@intel.com>, <linux-kernel@vger.kernel.org>,
<patches@lists.linux.dev>
Subject: Re: [PATCH v2 5/5] fs/resctrl: Drop unnecessary parameter from resctrl_io_alloc_parse_line()
Date: Tue, 27 Oct 2026 07:36:57 -0700 [thread overview]
Message-ID: <6e0483f7-1b45-4c70-aa00-51e43a6d7305@intel.com> (raw)
In-Reply-To: <4b671902-3cee-436c-87fc-55ec1cb14782@huawei.com>
Hi Jinjie,
On 10/27/26 1:35 AM, Jinjie Ruan wrote:
> 在 2026/10/8 5:06, Reinette Chatre 写道:
>> resctrl_io_alloc_parse_line() parses a line written to the io_alloc_cbm file.
>> It receives both a schema and a pointer to the schema's resource. Its only
>> caller looks up the resource from the schema just to pass both.
>>
>> Passing the resource separately is redundant and allows a caller to pass a
>> resource that does not belong to the schema. parse_line(), which parses lines
>> written to the schemata file, already receives only the schema and determines
>> the resource from it.
>>
>> Pass only the schema to resctrl_io_alloc_parse_line() and have it determine
>> the resource itself, matching parse_line() and in preparation for passing
>> additional information when supporting multiple controls.
>>
>> No functional change.
>>
>> Signed-off-by: Reinette Chatre <reinette.chatre@intel.com>
>> Reviewed-by: Ben Horgan <ben.horgan@arm.com>
...
>
> LGTM
> Reviewed-by: Jinjie Ruan <ruanjinjie@huawei.com>
Thank you very much for reviewing this series.
Reinette
next prev parent reply other threads:[~2026-10-27 14:37 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-07 21:06 [PATCH v2 0/5] x86,fs/resctrl: Cleanups in preparation for multiple controls support Reinette Chatre
2026-10-07 21:06 ` [PATCH v2 1/5] x86,fs/resctrl: Remove unused non-linear bandwidth delay mapping Reinette Chatre
2026-10-27 8:07 ` Jinjie Ruan
2026-10-07 21:06 ` [PATCH v2 2/5] x86,fs/resctrl: Remove unnecessary non-linear MBA configuration check Reinette Chatre
2026-10-08 7:14 ` Chen Yu
2026-10-27 8:29 ` Jinjie Ruan
2026-10-07 21:06 ` [PATCH v2 3/5] x86,fs/resctrl: Move MSR_IA32_L{2,3}_QOS_CFG scope property to x86 resource Reinette Chatre
2026-10-18 17:40 ` Chen Yu
2026-10-19 23:06 ` Reinette Chatre
2026-10-20 6:05 ` Chen Yu
2026-10-20 21:01 ` Reinette Chatre
2026-10-07 21:06 ` [PATCH v2 4/5] fs/resctrl: Drop unnecessary is_mba_linear() helper Reinette Chatre
2026-10-27 8:34 ` Jinjie Ruan
2026-10-07 21:06 ` [PATCH v2 5/5] fs/resctrl: Drop unnecessary parameter from resctrl_io_alloc_parse_line() Reinette Chatre
2026-10-18 17:44 ` Chen Yu
2026-10-27 8:35 ` Jinjie Ruan
2026-10-27 14:36 ` Reinette Chatre [this message]
2026-10-08 16:12 ` [PATCH v2 0/5] x86,fs/resctrl: Cleanups in preparation for multiple controls support Luck, Tony
2026-10-08 22:48 ` Reinette Chatre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6e0483f7-1b45-4c70-aa00-51e43a6d7305@intel.com \
--to=reinette.chatre@intel.com \
--cc=Dave.Martin@arm.com \
--cc=babu.moger@amd.com \
--cc=ben.horgan@arm.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=fenghuay@nvidia.com \
--cc=fustini@kernel.org \
--cc=hpa@zytor.com \
--cc=james.morse@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@lists.linux.dev \
--cc=peternewman@google.com \
--cc=ruanjinjie@huawei.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
--cc=yu.c.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®