[PATCH v2] ASoC: qcom: audioreach: explicitly enable speaker protection modules

[PATCH v2] ASoC: qcom: audioreach: explicitly enable speaker protection modules

[Ravi Hothi]

Speaker protection and VI feedback modules are disabled by default.
Explicitly enable them when configuring speaker protection.

Fixes: 3e43a8c033c3 ("ASoC: qcom: audioreach: Add support for VI Sense module")
Fixes: 0db76f5b2235 ("ASoC: qcom: audioreach: Add support for Speaker Protection module")
Signed-off-by: Ravi Hothi <ravi.hothi@oss.qualcomm.com>
---
Changes in v2:
        - Added fixes tag suggested by Dmitry.
        - Link to v1: https://lore.kernel.org/all/20260325054408.1994556-1-ravi.hothi@oss.qualcomm.com/
---
 sound/soc/qcom/qdsp6/audioreach.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/sound/soc/qcom/qdsp6/audioreach.c b/sound/soc/qcom/qdsp6/audioreach.c
index 241c3b4479c6..ff8cd55b0d89 100644
--- a/sound/soc/qcom/qdsp6/audioreach.c
+++ b/sound/soc/qcom/qdsp6/audioreach.c
@@ -1365,9 +1365,14 @@ int audioreach_set_media_format(struct q6apm_graph *graph,
 	case MODULE_ID_SPEAKER_PROTECTION:
 		rc = audioreach_speaker_protection(graph, module,
 						   PARAM_ID_SP_OP_MODE_NORMAL);
+		if (!rc)
+			rc = audioreach_module_enable(graph, module, true);
+
 		break;
 	case MODULE_ID_SPEAKER_PROTECTION_VI:
 		rc = audioreach_speaker_protection_vi(graph, module, cfg);
+		if (!rc)
+			rc = audioreach_module_enable(graph, module, true);
 		break;
 
 	default:
-- 
2.34.1

Re: [PATCH v2] ASoC: qcom: audioreach: explicitly enable speaker protection modules

[Srinivas Kandagatla]

On 3/26/26 11:35 AM, Ravi Hothi wrote:
> Speaker protection and VI feedback modules are disabled by default.
> Explicitly enable them when configuring speaker protection.
> 
> Fixes: 3e43a8c033c3 ("ASoC: qcom: audioreach: Add support for VI Sense module")
> Fixes: 0db76f5b2235 ("ASoC: qcom: audioreach: Add support for Speaker Protection module")
> Signed-off-by: Ravi Hothi <ravi.hothi@oss.qualcomm.com>
> ---

lgtm,

Reviewed-by: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>


> Changes in v2:
>         - Added fixes tag suggested by Dmitry.
>         - Link to v1: https://lore.kernel.org/all/20260325054408.1994556-1-ravi.hothi@oss.qualcomm.com/
> ---
>  sound/soc/qcom/qdsp6/audioreach.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/sound/soc/qcom/qdsp6/audioreach.c b/sound/soc/qcom/qdsp6/audioreach.c
> index 241c3b4479c6..ff8cd55b0d89 100644
> --- a/sound/soc/qcom/qdsp6/audioreach.c
> +++ b/sound/soc/qcom/qdsp6/audioreach.c
> @@ -1365,9 +1365,14 @@ int audioreach_set_media_format(struct q6apm_graph *graph,
>  	case MODULE_ID_SPEAKER_PROTECTION:
>  		rc = audioreach_speaker_protection(graph, module,
>  						   PARAM_ID_SP_OP_MODE_NORMAL);
> +		if (!rc)
> +			rc = audioreach_module_enable(graph, module, true);
> +
>  		break;
>  	case MODULE_ID_SPEAKER_PROTECTION_VI:
>  		rc = audioreach_speaker_protection_vi(graph, module, cfg);
> +		if (!rc)
> +			rc = audioreach_module_enable(graph, module, true);
>  		break;
>  
>  	default:

Re: [PATCH v2] ASoC: qcom: audioreach: explicitly enable speaker protection modules

[Mark Brown]

On Thu, 26 Mar 2026 17:05:31 +0530, Ravi Hothi wrote:
> ASoC: qcom: audioreach: explicitly enable speaker protection modules

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-7.1

Thanks!

[1/1] ASoC: qcom: audioreach: explicitly enable speaker protection modules
      https://git.kernel.org/broonie/sound/c/b481eabe5a19

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark