Re: [PATCH v1 3/5] drm/panel: r61307/r69328: remove redundant checks

[Neil Armstrong <neil.armstrong@linaro.org>]

On 2/15/26 09:51, Svyatoslav Ryhel wrote:
> This is now done by the DRM framework itself.
> 
> Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com>
> ---
>   drivers/gpu/drm/panel/panel-renesas-r61307.c | 10 ----------
>   drivers/gpu/drm/panel/panel-renesas-r69328.c | 10 ----------
>   2 files changed, 20 deletions(-)
> 
> diff --git a/drivers/gpu/drm/panel/panel-renesas-r61307.c b/drivers/gpu/drm/panel/panel-renesas-r61307.c
> index 45afa44af114..2cc3bd66d6d4 100644
> --- a/drivers/gpu/drm/panel/panel-renesas-r61307.c
> +++ b/drivers/gpu/drm/panel/panel-renesas-r61307.c
> @@ -35,8 +35,6 @@ struct renesas_r61307 {
>   
>   	struct gpio_desc *reset_gpio;
>   
> -	bool prepared;
> -
>   	bool dig_cont_adj;
>   	bool inversion;
>   	u32 gamma;
> @@ -92,9 +90,6 @@ static int renesas_r61307_prepare(struct drm_panel *panel)
>   	struct device *dev = &priv->dsi->dev;
>   	int ret;
>   
> -	if (priv->prepared)
> -		return 0;
> -
>   	ret = regulator_enable(priv->vcc_supply);
>   	if (ret) {
>   		dev_err(dev, "failed to enable vcc power supply\n");
> @@ -113,7 +108,6 @@ static int renesas_r61307_prepare(struct drm_panel *panel)
>   
>   	renesas_r61307_reset(priv);
>   
> -	priv->prepared = true;
>   	return 0;
>   }
>   
> @@ -175,9 +169,6 @@ static int renesas_r61307_unprepare(struct drm_panel *panel)
>   {
>   	struct renesas_r61307 *priv = to_renesas_r61307(panel);
>   
> -	if (!priv->prepared)
> -		return 0;
> -
>   	usleep_range(10000, 11000);
>   
>   	gpiod_set_value_cansleep(priv->reset_gpio, 1);
> @@ -187,7 +178,6 @@ static int renesas_r61307_unprepare(struct drm_panel *panel)
>   	usleep_range(2000, 3000);
>   	regulator_disable(priv->vcc_supply);
>   
> -	priv->prepared = false;
>   	return 0;
>   }
>   
> diff --git a/drivers/gpu/drm/panel/panel-renesas-r69328.c b/drivers/gpu/drm/panel/panel-renesas-r69328.c
> index b40bfd702fac..b5fe127634ae 100644
> --- a/drivers/gpu/drm/panel/panel-renesas-r69328.c
> +++ b/drivers/gpu/drm/panel/panel-renesas-r69328.c
> @@ -33,8 +33,6 @@ struct renesas_r69328 {
>   	struct regulator *vdd_supply;
>   	struct regulator *vddio_supply;
>   	struct gpio_desc *reset_gpio;
> -
> -	bool prepared;
>   };
>   
>   static inline struct renesas_r69328 *to_renesas_r69328(struct drm_panel *panel)
> @@ -56,9 +54,6 @@ static int renesas_r69328_prepare(struct drm_panel *panel)
>   	struct device *dev = &priv->dsi->dev;
>   	int ret;
>   
> -	if (priv->prepared)
> -		return 0;
> -
>   	ret = regulator_enable(priv->vdd_supply);
>   	if (ret) {
>   		dev_err(dev, "failed to enable vdd power supply\n");
> @@ -77,7 +72,6 @@ static int renesas_r69328_prepare(struct drm_panel *panel)
>   
>   	renesas_r69328_reset(priv);
>   
> -	priv->prepared = true;
>   	return 0;
>   }
>   
> @@ -142,9 +136,6 @@ static int renesas_r69328_unprepare(struct drm_panel *panel)
>   {
>   	struct renesas_r69328 *priv = to_renesas_r69328(panel);
>   
> -	if (!priv->prepared)
> -		return 0;
> -
>   	gpiod_set_value_cansleep(priv->reset_gpio, 1);
>   
>   	usleep_range(5000, 6000);
> @@ -152,7 +143,6 @@ static int renesas_r69328_unprepare(struct drm_panel *panel)
>   	regulator_disable(priv->vddio_supply);
>   	regulator_disable(priv->vdd_supply);
>   
> -	priv->prepared = false;
>   	return 0;
>   }
>   

Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>

Thanks,
Neil