From: Neil Armstrong <neil.armstrong@linaro.org>
To: Svyatoslav Ryhel <clamor95@gmail.com>,
Jessica Zhang <jesszhan0024@gmail.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 2/5] drm/panel: r61307/r69328: convert to drm_connector_helper_get_modes_fixed
Date: Mon, 16 Feb 2026 17:14:05 +0100 [thread overview]
Message-ID: <c588c5b4-82ec-4d4c-a3f4-5f81c6fcebaf@linaro.org> (raw)
In-Reply-To: <20260215085140.20499-3-clamor95@gmail.com>
On 2/15/26 09:51, Svyatoslav Ryhel wrote:
> Switch to use of drm_connector_helper_get_modes_fixed helper for get_modes
> operation.
>
> Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com>
> ---
> drivers/gpu/drm/panel/Kconfig | 2 ++
> drivers/gpu/drm/panel/panel-renesas-r61307.c | 17 +++--------------
> drivers/gpu/drm/panel/panel-renesas-r69328.c | 17 +++--------------
> 3 files changed, 8 insertions(+), 28 deletions(-)
>
> diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig
> index 477c54c90b01..47de5f6a9143 100644
> --- a/drivers/gpu/drm/panel/Kconfig
> +++ b/drivers/gpu/drm/panel/Kconfig
> @@ -700,6 +700,7 @@ config DRM_PANEL_RENESAS_R61307
> depends on OF
> depends on DRM_MIPI_DSI
> depends on BACKLIGHT_CLASS_DEVICE
> + select VIDEOMODE_HELPERS
> help
> Say Y here if you want to enable support for KOE tx13d100vm0eaa
> IPS-LCD module with Renesas R69328 IC. The panel has a 1024x768
> @@ -713,6 +714,7 @@ config DRM_PANEL_RENESAS_R69328
> depends on OF
> depends on DRM_MIPI_DSI
> depends on BACKLIGHT_CLASS_DEVICE
> + select VIDEOMODE_HELPERS
> help
> Say Y here if you want to enable support for JDI dx12d100vm0eaa
> IPS-LCD module with Renesas R69328 IC. The panel has a 720x1280
> diff --git a/drivers/gpu/drm/panel/panel-renesas-r61307.c b/drivers/gpu/drm/panel/panel-renesas-r61307.c
> index 873ef856184b..45afa44af114 100644
> --- a/drivers/gpu/drm/panel/panel-renesas-r61307.c
> +++ b/drivers/gpu/drm/panel/panel-renesas-r61307.c
> @@ -14,6 +14,7 @@
> #include <drm/drm_mipi_dsi.h>
> #include <drm/drm_modes.h>
> #include <drm/drm_panel.h>
> +#include <drm/drm_probe_helper.h>
>
> #define R61307_MACP 0xb0 /* Manufacturer CMD Protect */
> #define R61307_MACP_ON 0x03
> @@ -202,25 +203,13 @@ static const struct drm_display_mode renesas_r61307_mode = {
> .vtotal = 1024 + 24 + 8 + 2,
> .width_mm = 76,
> .height_mm = 101,
> + .type = DRM_MODE_TYPE_DRIVER | DRM_MODE_TYPE_PREFERRED,
> };
>
> static int renesas_r61307_get_modes(struct drm_panel *panel,
> struct drm_connector *connector)
> {
> - struct drm_display_mode *mode;
> -
> - mode = drm_mode_duplicate(connector->dev, &renesas_r61307_mode);
> - if (!mode)
> - return -ENOMEM;
> -
> - drm_mode_set_name(mode);
> -
> - mode->type = DRM_MODE_TYPE_DRIVER | DRM_MODE_TYPE_PREFERRED;
> - connector->display_info.width_mm = mode->width_mm;
> - connector->display_info.height_mm = mode->height_mm;
> - drm_mode_probed_add(connector, mode);
> -
> - return 1;
> + return drm_connector_helper_get_modes_fixed(connector, &renesas_r61307_mode);
> }
>
> static const struct drm_panel_funcs renesas_r61307_panel_funcs = {
> diff --git a/drivers/gpu/drm/panel/panel-renesas-r69328.c b/drivers/gpu/drm/panel/panel-renesas-r69328.c
> index 46287ab04c30..b40bfd702fac 100644
> --- a/drivers/gpu/drm/panel/panel-renesas-r69328.c
> +++ b/drivers/gpu/drm/panel/panel-renesas-r69328.c
> @@ -14,6 +14,7 @@
> #include <drm/drm_mipi_dsi.h>
> #include <drm/drm_modes.h>
> #include <drm/drm_panel.h>
> +#include <drm/drm_probe_helper.h>
>
> #define R69328_MACP 0xb0 /* Manufacturer Access CMD Protect */
> #define R69328_MACP_ON 0x03
> @@ -167,25 +168,13 @@ static const struct drm_display_mode renesas_r69328_mode = {
> .vtotal = 1280 + 6 + 3 + 1,
> .width_mm = 59,
> .height_mm = 105,
> + .type = DRM_MODE_TYPE_DRIVER | DRM_MODE_TYPE_PREFERRED,
> };
>
> static int renesas_r69328_get_modes(struct drm_panel *panel,
> struct drm_connector *connector)
> {
> - struct drm_display_mode *mode;
> -
> - mode = drm_mode_duplicate(connector->dev, &renesas_r69328_mode);
> - if (!mode)
> - return -ENOMEM;
> -
> - drm_mode_set_name(mode);
> -
> - mode->type = DRM_MODE_TYPE_DRIVER | DRM_MODE_TYPE_PREFERRED;
> - connector->display_info.width_mm = mode->width_mm;
> - connector->display_info.height_mm = mode->height_mm;
> - drm_mode_probed_add(connector, mode);
> -
> - return 1;
> + return drm_connector_helper_get_modes_fixed(connector, &renesas_r69328_mode);
> }
>
> static const struct drm_panel_funcs renesas_r69328_panel_funcs = {
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Thanks,
Neil
next prev parent reply other threads:[~2026-02-16 16:14 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-15 8:51 [PATCH v1 0/5] drm/panel: r61307/r69328: minor updates Svyatoslav Ryhel
2026-02-15 8:51 ` [PATCH v1 1/5] drm/panel: r61307: align with schema property Svyatoslav Ryhel
2026-02-16 16:13 ` Neil Armstrong
2026-02-15 8:51 ` [PATCH v1 2/5] drm/panel: r61307/r69328: convert to drm_connector_helper_get_modes_fixed Svyatoslav Ryhel
2026-02-16 16:14 ` Neil Armstrong [this message]
2026-02-15 8:51 ` [PATCH v1 3/5] drm/panel: r61307/r69328: remove redundant checks Svyatoslav Ryhel
2026-02-16 16:14 ` Neil Armstrong
2026-02-15 8:51 ` [PATCH v1 4/5] drm/panel: r61307/r69328: return accumulated errors Svyatoslav Ryhel
2026-02-16 16:15 ` Neil Armstrong
2026-02-15 8:51 ` [PATCH v1 5/5] drm/panel: r61307/r69328: convert to devm_mipi_dsi_attach Svyatoslav Ryhel
2026-02-16 16:16 ` Neil Armstrong
2026-03-10 13:28 ` [PATCH v1 0/5] drm/panel: r61307/r69328: minor updates Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c588c5b4-82ec-4d4c-a3f4-5f81c6fcebaf@linaro.org \
--to=neil.armstrong@linaro.org \
--cc=airlied@gmail.com \
--cc=clamor95@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jesszhan0024@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®