mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH V3] arm64: dts: qcom: arduino-imola: fix faulty spidev node
@ 2026-02-13 10:10 Riccardo Mereu
  2026-02-13 10:40 ` Konrad Dybcio
  2026-03-18 13:50 ` Bjorn Andersson
  0 siblings, 2 replies; 3+ messages in thread
From: Riccardo Mereu @ 2026-02-13 10:10 UTC (permalink / raw)
  To: lee, robh, krzk+dt, conor+dt, andersson, konradybcio, sboyd
  Cc: linux-arm-msm, devicetree, linux-kernel, alexey.klimov,
	srinivas.kandagatla, m.facchin, akucheri, ndechesn,
	Riccardo Mereu

From: Riccardo Mereu <r.mereu@arduino.cc>

CS pin added on pinctrl0 property is causing spidev to return -ENODEV
since that GPIO is already part of spi5 pinmuxing.

Fixes: 3f745bc0f11f ("arm64: dts: qcom: qrb2210: add dts for Arduino unoq")
Signed-off-by: Riccardo Mereu <r.mereu@arduino.cc>
---

Changes since V2:
	- Changed spidev@0 nodename to mcu@0.
	- Changed properties order in same node to match DTS coding
	  style.

 arch/arm64/boot/dts/qcom/qrb2210-arduino-imola.dts | 12 ++----------
 1 file changed, 2 insertions(+), 10 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/qrb2210-arduino-imola.dts b/arch/arm64/boot/dts/qcom/qrb2210-arduino-imola.dts
index 197ab6eb1666..5ab605cc56c8 100644
--- a/arch/arm64/boot/dts/qcom/qrb2210-arduino-imola.dts
+++ b/arch/arm64/boot/dts/qcom/qrb2210-arduino-imola.dts
@@ -325,21 +325,13 @@ &sdhc_1 {
 &spi5 {
 	status = "okay";
 
-	spidev@0 {
-		reg = <0>;
+	mcu@0 {
 		compatible = "arduino,unoq-mcu";
-		pinctrl-0 = <&spidev_cs>;
-		pinctrl-names = "default";
+		reg = <0>;
 	};
 };
 
 &tlmm {
-	spidev_cs: spidev-cs-state {
-		pins = "gpio17";
-		function = "gpio";
-		drive-strength = <16>;
-	};
-
 	jmisc_gpio18: jmisc-gpio18-state {
 		pins = "gpio18";
 		function = "gpio";
-- 
2.53.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH V3] arm64: dts: qcom: arduino-imola: fix faulty spidev node
  2026-02-13 10:10 [PATCH V3] arm64: dts: qcom: arduino-imola: fix faulty spidev node Riccardo Mereu
@ 2026-02-13 10:40 ` Konrad Dybcio
  2026-03-18 13:50 ` Bjorn Andersson
  1 sibling, 0 replies; 3+ messages in thread
From: Konrad Dybcio @ 2026-02-13 10:40 UTC (permalink / raw)
  To: Riccardo Mereu, lee, robh, krzk+dt, conor+dt, andersson,
	konradybcio, sboyd
  Cc: linux-arm-msm, devicetree, linux-kernel, alexey.klimov,
	srinivas.kandagatla, m.facchin, akucheri, ndechesn,
	Riccardo Mereu

On 2/13/26 11:10 AM, Riccardo Mereu wrote:
> From: Riccardo Mereu <r.mereu@arduino.cc>
> 
> CS pin added on pinctrl0 property is causing spidev to return -ENODEV
> since that GPIO is already part of spi5 pinmuxing.
> 
> Fixes: 3f745bc0f11f ("arm64: dts: qcom: qrb2210: add dts for Arduino unoq")
> Signed-off-by: Riccardo Mereu <r.mereu@arduino.cc>
> ---

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH V3] arm64: dts: qcom: arduino-imola: fix faulty spidev node
  2026-02-13 10:10 [PATCH V3] arm64: dts: qcom: arduino-imola: fix faulty spidev node Riccardo Mereu
  2026-02-13 10:40 ` Konrad Dybcio
@ 2026-03-18 13:50 ` Bjorn Andersson
  1 sibling, 0 replies; 3+ messages in thread
From: Bjorn Andersson @ 2026-03-18 13:50 UTC (permalink / raw)
  To: lee, robh, krzk+dt, conor+dt, konradybcio, sboyd, Riccardo Mereu
  Cc: linux-arm-msm, devicetree, linux-kernel, alexey.klimov,
	srinivas.kandagatla, m.facchin, akucheri, ndechesn,
	Riccardo Mereu


On Fri, 13 Feb 2026 11:10:02 +0100, Riccardo Mereu wrote:
> CS pin added on pinctrl0 property is causing spidev to return -ENODEV
> since that GPIO is already part of spi5 pinmuxing.
> 
> 

Applied, thanks!

[1/1] arm64: dts: qcom: arduino-imola: fix faulty spidev node
      commit: 84d8976426072ea1a559ab1aaeff6bdc16248813

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-03-18 13:51 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-02-13 10:10 [PATCH V3] arm64: dts: qcom: arduino-imola: fix faulty spidev node Riccardo Mereu
2026-02-13 10:40 ` Konrad Dybcio
2026-03-18 13:50 ` Bjorn Andersson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®