From: Jayesh Choudhary <j-choudhary@ti.com>
To: Devarsh Thakkar <devarsht@ti.com>, <jyri.sarha@iki.fi>,
<maarten.lankhorst@linux.intel.com>, <mripard@kernel.org>,
<tzimmermann@suse.de>, <dri-devel@lists.freedesktop.org>,
<tomi.valkeinen@ideasonboard.com>, <mwalle@kernel.org>
Cc: <airlied@gmail.com>, <simona@ffwll.ch>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 0/3] Decouple max_pclk check from constant display feats
Date: Wed, 2 Jul 2025 12:31:55 +0530 [thread overview]
Message-ID: <71b4bd21-573e-4b48-a57f-6496e97d2eff@ti.com> (raw)
In-Reply-To: <a0489fea-8c06-4c89-a530-8be691f4705d@ti.com>
Hello Devarsh,
On 01/07/25 19:00, Devarsh Thakkar wrote:
> On 01/07/25 15:25, Jayesh Choudhary wrote:
>> In an effort to make the existing compatibles more usable, we are
>> removing the max_pclk_khz form dispc_features structure and doing the
>> correspondig checks using "curr_max_pclk[]".
>>
>> Changes are fully backwards compatible.
>>
>> After integration of OLDI support[0], we need additional patches in
>> oldi to identify the VP that has OLDI. We have to do this since
>> OLDI driver owns the VP clock (its serial clock) and we cannot perform
>> clock operations on those VP clock from tidss driver. This issue was
>> also reported upstream when DSI fixes[1] had some clock related calls
>> in tidss driver. When "clk_round_rate()" is called, ideally it should
>> have gone to "sci_clk_determine_rate()" to query DM but it doesn't since
>> clock is owned by OLDI not tidss.
>>
>
> As series is fixing above issue (abnormal behaviour while calling
> clk_round_rate from tidss for VP clock being used by OLDI), can we add
> "Fixes tag" for the patches?
This seems like a preemptive fix. So I was not sure what to add.
If it should be added then which commit?
7246e0929945 ("drm/tidss: Add OLDI bridge support") ?
Warm Regards,
Jayesh
>
> Regards
> Devarsh
next prev parent reply other threads:[~2025-07-02 7:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-01 9:55 Jayesh Choudhary
2025-07-01 9:55 ` [PATCH v3 1/3] drm/tidss: oldi: Add property to identify OLDI supported VP Jayesh Choudhary
2025-07-01 12:04 ` Devarsh Thakkar
2025-07-01 9:55 ` [PATCH v3 2/3] drm/tidss: Remove max_pclk_khz from tidss display features Jayesh Choudhary
2025-07-01 13:12 ` Devarsh Thakkar
2025-07-02 6:35 ` Jayesh Choudhary
2025-07-01 9:55 ` [PATCH v3 3/3] drm/tidss: oldi: Add atomic_check hook for oldi bridge Jayesh Choudhary
2025-07-01 13:52 ` Devarsh Thakkar
2025-07-02 6:21 ` Jayesh Choudhary
2025-07-01 13:30 ` [PATCH v3 0/3] Decouple max_pclk check from constant display feats Devarsh Thakkar
2025-07-02 7:01 ` Jayesh Choudhary [this message]
2025-07-02 8:37 ` Devarsh Thakkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=71b4bd21-573e-4b48-a57f-6496e97d2eff@ti.com \
--to=j-choudhary@ti.com \
--cc=airlied@gmail.com \
--cc=devarsht@ti.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jyri.sarha@iki.fi \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=mwalle@kernel.org \
--cc=simona@ffwll.ch \
--cc=tomi.valkeinen@ideasonboard.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®