* [PATCH] arm64: dts: qcom: qcm6490-idp: Update protected clocks list
@ 2025-02-06 10:13 Taniya Das
2025-02-26 4:42 ` Bjorn Andersson
2025-03-17 2:55 ` Bjorn Andersson
0 siblings, 2 replies; 13+ messages in thread
From: Taniya Das @ 2025-02-06 10:13 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: Ajit Pandey, Imran Shaik, Jagadeesh Kona, linux-arm-msm,
devicetree, linux-kernel, Taniya Das
Certain clocks are not accessible on QCM6490-IDP board,
thus mark them as protected.
Signed-off-by: Taniya Das <quic_tdas@quicinc.com>
---
Mark few clocks as protected on IDP of QCM6490.
This patchset is separated out from the series[1] to remove dependency from
the LPASS reset.
[1]: https://lore.kernel.org/all/20240816-qcm6490-lpass-reset-v1-0-a11f33cad3c5@quicinc.com/
---
arch/arm64/boot/dts/qcom/qcm6490-idp.dts | 21 +++++++++++++++++++++
1 file changed, 21 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
index 9209efcc49b57a853c4dd55ac52cd4dc98d7fe86..346b9a377e611cd3e32cf00d44e87b363bada07a 100644
--- a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
+++ b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
@@ -759,3 +759,24 @@ &wifi {
status = "okay";
};
+
+&gcc {
+ protected-clocks = <GCC_AGGRE_NOC_PCIE_1_AXI_CLK> ,<GCC_PCIE_1_AUX_CLK>,
+ <GCC_PCIE_1_AUX_CLK_SRC>, <GCC_PCIE_1_CFG_AHB_CLK>,
+ <GCC_PCIE_1_MSTR_AXI_CLK>, <GCC_PCIE_1_PHY_RCHNG_CLK_SRC>,
+ <GCC_PCIE_1_PIPE_CLK>, <GCC_PCIE_1_PIPE_CLK_SRC>,
+ <GCC_PCIE_1_SLV_AXI_CLK>, <GCC_PCIE_1_SLV_Q2A_AXI_CLK>,
+ <GCC_QSPI_CNOC_PERIPH_AHB_CLK>, <GCC_QSPI_CORE_CLK>,
+ <GCC_QSPI_CORE_CLK_SRC>,<GCC_USB30_SEC_MASTER_CLK>,
+ <GCC_USB30_SEC_MASTER_CLK_SRC>, <GCC_USB30_SEC_MOCK_UTMI_CLK>,
+ <GCC_USB30_SEC_MOCK_UTMI_CLK_SRC>,
+ <GCC_USB30_SEC_MOCK_UTMI_POSTDIV_CLK_SRC>, <GCC_USB30_SEC_SLEEP_CLK>,
+ <GCC_USB3_SEC_PHY_AUX_CLK>, <GCC_USB3_SEC_PHY_AUX_CLK_SRC>,
+ <GCC_USB3_SEC_PHY_COM_AUX_CLK>, <GCC_USB3_SEC_PHY_PIPE_CLK>,
+ <GCC_USB3_SEC_PHY_PIPE_CLK_SRC>, <GCC_CFG_NOC_LPASS_CLK>,
+ <GCC_MSS_GPLL0_MAIN_DIV_CLK_SRC>, <GCC_MSS_CFG_AHB_CLK>,
+ <GCC_MSS_OFFLINE_AXI_CLK>, <GCC_MSS_SNOC_AXI_CLK>,
+ <GCC_MSS_Q6_MEMNOC_AXI_CLK>, <GCC_MSS_Q6SS_BOOT_CLK_SRC>,
+ <GCC_SEC_CTRL_CLK_SRC>, <GCC_WPSS_AHB_CLK>,
+ <GCC_WPSS_AHB_BDG_MST_CLK>, <GCC_WPSS_RSCP_CLK>;
+};
---
base-commit: 808eb958781e4ebb6e9c0962af2e856767e20f45
change-id: 20250206-protected_clock_qcm6490-4019e6a61d0b
Best regards,
--
Taniya Das <quic_tdas@quicinc.com>
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [PATCH] arm64: dts: qcom: qcm6490-idp: Update protected clocks list
2025-02-06 10:13 [PATCH] arm64: dts: qcom: qcm6490-idp: Update protected clocks list Taniya Das
@ 2025-02-26 4:42 ` Bjorn Andersson
2025-02-26 5:01 ` Trilok Soni
2025-02-27 4:12 ` Taniya Das
2025-03-17 2:55 ` Bjorn Andersson
1 sibling, 2 replies; 13+ messages in thread
From: Bjorn Andersson @ 2025-02-26 4:42 UTC (permalink / raw)
To: Taniya Das
Cc: Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Ajit Pandey, Imran Shaik, Jagadeesh Kona, linux-arm-msm,
devicetree, linux-kernel
On Thu, Feb 06, 2025 at 03:43:21PM +0530, Taniya Das wrote:
> Certain clocks are not accessible on QCM6490-IDP board,
> thus mark them as protected.
>
> Signed-off-by: Taniya Das <quic_tdas@quicinc.com>
> ---
> Mark few clocks as protected on IDP of QCM6490.
>
> This patchset is separated out from the series[1] to remove dependency from
> the LPASS reset.
> [1]: https://lore.kernel.org/all/20240816-qcm6490-lpass-reset-v1-0-a11f33cad3c5@quicinc.com/
> ---
> arch/arm64/boot/dts/qcom/qcm6490-idp.dts | 21 +++++++++++++++++++++
I merged the patch adding this board in November 2023, are you saying
that for the last 15 months no one has actually booted it!?
> 1 file changed, 21 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
> index 9209efcc49b57a853c4dd55ac52cd4dc98d7fe86..346b9a377e611cd3e32cf00d44e87b363bada07a 100644
> --- a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
> +++ b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
> @@ -759,3 +759,24 @@ &wifi {
>
> status = "okay";
> };
> +
> +&gcc {
As you know, we sort nodes by address (if they have one), then
alphabetically. So this does not belong here.
Regards,
Bjorn
> + protected-clocks = <GCC_AGGRE_NOC_PCIE_1_AXI_CLK> ,<GCC_PCIE_1_AUX_CLK>,
> + <GCC_PCIE_1_AUX_CLK_SRC>, <GCC_PCIE_1_CFG_AHB_CLK>,
> + <GCC_PCIE_1_MSTR_AXI_CLK>, <GCC_PCIE_1_PHY_RCHNG_CLK_SRC>,
> + <GCC_PCIE_1_PIPE_CLK>, <GCC_PCIE_1_PIPE_CLK_SRC>,
> + <GCC_PCIE_1_SLV_AXI_CLK>, <GCC_PCIE_1_SLV_Q2A_AXI_CLK>,
> + <GCC_QSPI_CNOC_PERIPH_AHB_CLK>, <GCC_QSPI_CORE_CLK>,
> + <GCC_QSPI_CORE_CLK_SRC>,<GCC_USB30_SEC_MASTER_CLK>,
> + <GCC_USB30_SEC_MASTER_CLK_SRC>, <GCC_USB30_SEC_MOCK_UTMI_CLK>,
> + <GCC_USB30_SEC_MOCK_UTMI_CLK_SRC>,
> + <GCC_USB30_SEC_MOCK_UTMI_POSTDIV_CLK_SRC>, <GCC_USB30_SEC_SLEEP_CLK>,
> + <GCC_USB3_SEC_PHY_AUX_CLK>, <GCC_USB3_SEC_PHY_AUX_CLK_SRC>,
> + <GCC_USB3_SEC_PHY_COM_AUX_CLK>, <GCC_USB3_SEC_PHY_PIPE_CLK>,
> + <GCC_USB3_SEC_PHY_PIPE_CLK_SRC>, <GCC_CFG_NOC_LPASS_CLK>,
> + <GCC_MSS_GPLL0_MAIN_DIV_CLK_SRC>, <GCC_MSS_CFG_AHB_CLK>,
> + <GCC_MSS_OFFLINE_AXI_CLK>, <GCC_MSS_SNOC_AXI_CLK>,
> + <GCC_MSS_Q6_MEMNOC_AXI_CLK>, <GCC_MSS_Q6SS_BOOT_CLK_SRC>,
> + <GCC_SEC_CTRL_CLK_SRC>, <GCC_WPSS_AHB_CLK>,
> + <GCC_WPSS_AHB_BDG_MST_CLK>, <GCC_WPSS_RSCP_CLK>;
> +};
>
> ---
> base-commit: 808eb958781e4ebb6e9c0962af2e856767e20f45
> change-id: 20250206-protected_clock_qcm6490-4019e6a61d0b
>
> Best regards,
> --
> Taniya Das <quic_tdas@quicinc.com>
>
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [PATCH] arm64: dts: qcom: qcm6490-idp: Update protected clocks list
2025-02-26 4:42 ` Bjorn Andersson
@ 2025-02-26 5:01 ` Trilok Soni
2025-02-26 17:55 ` Konrad Dybcio
2025-02-27 4:12 ` Taniya Das
1 sibling, 1 reply; 13+ messages in thread
From: Trilok Soni @ 2025-02-26 5:01 UTC (permalink / raw)
To: Bjorn Andersson, Taniya Das
Cc: Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Ajit Pandey, Imran Shaik, Jagadeesh Kona, linux-arm-msm,
devicetree, linux-kernel
On 2/25/2025 8:42 PM, Bjorn Andersson wrote:
> On Thu, Feb 06, 2025 at 03:43:21PM +0530, Taniya Das wrote:
>> Certain clocks are not accessible on QCM6490-IDP board,
>> thus mark them as protected.
>>
>> Signed-off-by: Taniya Das <quic_tdas@quicinc.com>
>> ---
>> Mark few clocks as protected on IDP of QCM6490.
>>
>> This patchset is separated out from the series[1] to remove dependency from
>> the LPASS reset.
>> [1]: https://lore.kernel.org/all/20240816-qcm6490-lpass-reset-v1-0-a11f33cad3c5@quicinc.com/
>> ---
>> arch/arm64/boot/dts/qcom/qcm6490-idp.dts | 21 +++++++++++++++++++++
>
> I merged the patch adding this board in November 2023, are you saying
> that for the last 15 months no one has actually booted it!?
Should we just delete these boards? I prefer to not have platforms which
are not maintained.
--
---Trilok Soni
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] arm64: dts: qcom: qcm6490-idp: Update protected clocks list
2025-02-26 5:01 ` Trilok Soni
@ 2025-02-26 17:55 ` Konrad Dybcio
2025-02-27 4:11 ` Taniya Das
0 siblings, 1 reply; 13+ messages in thread
From: Konrad Dybcio @ 2025-02-26 17:55 UTC (permalink / raw)
To: Trilok Soni, Bjorn Andersson, Taniya Das
Cc: Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Ajit Pandey, Imran Shaik, Jagadeesh Kona, linux-arm-msm,
devicetree, linux-kernel
On 26.02.2025 6:01 AM, Trilok Soni wrote:
> On 2/25/2025 8:42 PM, Bjorn Andersson wrote:
>> On Thu, Feb 06, 2025 at 03:43:21PM +0530, Taniya Das wrote:
>>> Certain clocks are not accessible on QCM6490-IDP board,
>>> thus mark them as protected.
>>>
>>> Signed-off-by: Taniya Das <quic_tdas@quicinc.com>
>>> ---
>>> Mark few clocks as protected on IDP of QCM6490.
>>>
>>> This patchset is separated out from the series[1] to remove dependency from
>>> the LPASS reset.
>>> [1]: https://lore.kernel.org/all/20240816-qcm6490-lpass-reset-v1-0-a11f33cad3c5@quicinc.com/
>>> ---
>>> arch/arm64/boot/dts/qcom/qcm6490-idp.dts | 21 +++++++++++++++++++++
>>
>> I merged the patch adding this board in November 2023, are you saying
>> that for the last 15 months no one has actually booted it!?
>
> Should we just delete these boards? I prefer to not have platforms which
> are not maintained.
I think there's enough RB3Gen2s in the wild now to get rid of this one..
Unless anyone has a real use for it, but it doesn't seem like that's the
case given the lack of activity
Konrad
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] arm64: dts: qcom: qcm6490-idp: Update protected clocks list
2025-02-26 17:55 ` Konrad Dybcio
@ 2025-02-27 4:11 ` Taniya Das
0 siblings, 0 replies; 13+ messages in thread
From: Taniya Das @ 2025-02-27 4:11 UTC (permalink / raw)
To: Konrad Dybcio, Trilok Soni, Bjorn Andersson
Cc: Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Ajit Pandey, Imran Shaik, Jagadeesh Kona, linux-arm-msm,
devicetree, linux-kernel
On 2/26/2025 11:25 PM, Konrad Dybcio wrote:
> On 26.02.2025 6:01 AM, Trilok Soni wrote:
>> On 2/25/2025 8:42 PM, Bjorn Andersson wrote:
>>> On Thu, Feb 06, 2025 at 03:43:21PM +0530, Taniya Das wrote:
>>>> Certain clocks are not accessible on QCM6490-IDP board,
>>>> thus mark them as protected.
>>>>
>>>> Signed-off-by: Taniya Das <quic_tdas@quicinc.com>
>>>> ---
>>>> Mark few clocks as protected on IDP of QCM6490.
>>>>
>>>> This patchset is separated out from the series[1] to remove dependency from
>>>> the LPASS reset.
>>>> [1]: https://lore.kernel.org/all/20240816-qcm6490-lpass-reset-v1-0-a11f33cad3c5@quicinc.com/
>>>> ---
>>>> arch/arm64/boot/dts/qcom/qcm6490-idp.dts | 21 +++++++++++++++++++++
>>>
>>> I merged the patch adding this board in November 2023, are you saying
>>> that for the last 15 months no one has actually booted it!?
>>
>> Should we just delete these boards? I prefer to not have platforms which
>> are not maintained.
>
> I think there's enough RB3Gen2s in the wild now to get rid of this one..
> Unless anyone has a real use for it, but it doesn't seem like that's the
> case given the lack of activity
>
At least there were requests for me to get this board boot up and that
is where this patch comes. I agree if they are not supported, should be
removed.
> Konrad
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] arm64: dts: qcom: qcm6490-idp: Update protected clocks list
2025-02-26 4:42 ` Bjorn Andersson
2025-02-26 5:01 ` Trilok Soni
@ 2025-02-27 4:12 ` Taniya Das
2025-02-27 4:20 ` Dmitry Baryshkov
1 sibling, 1 reply; 13+ messages in thread
From: Taniya Das @ 2025-02-27 4:12 UTC (permalink / raw)
To: Bjorn Andersson
Cc: Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Ajit Pandey, Imran Shaik, Jagadeesh Kona, linux-arm-msm,
devicetree, linux-kernel
On 2/26/2025 10:12 AM, Bjorn Andersson wrote:
> On Thu, Feb 06, 2025 at 03:43:21PM +0530, Taniya Das wrote:
>> Certain clocks are not accessible on QCM6490-IDP board,
>> thus mark them as protected.
>>
>> Signed-off-by: Taniya Das <quic_tdas@quicinc.com>
>> ---
>> Mark few clocks as protected on IDP of QCM6490.
>>
>> This patchset is separated out from the series[1] to remove dependency from
>> the LPASS reset.
>> [1]: https://lore.kernel.org/all/20240816-qcm6490-lpass-reset-v1-0-a11f33cad3c5@quicinc.com/
>> ---
>> arch/arm64/boot/dts/qcom/qcm6490-idp.dts | 21 +++++++++++++++++++++
>
> I merged the patch adding this board in November 2023, are you saying
> that for the last 15 months no one has actually booted it!?
>
I am not sure, I had got request to help boot the board which was not
due to these clocks.
>> 1 file changed, 21 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
>> index 9209efcc49b57a853c4dd55ac52cd4dc98d7fe86..346b9a377e611cd3e32cf00d44e87b363bada07a 100644
>> --- a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
>> +++ b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
>> @@ -759,3 +759,24 @@ &wifi {
>>
>> status = "okay";
>> };
>> +
>> +&gcc {
>
> As you know, we sort nodes by address (if they have one), then
> alphabetically. So this does not belong here.
>
> Regards,
> Bjorn
>
>> + protected-clocks = <GCC_AGGRE_NOC_PCIE_1_AXI_CLK> ,<GCC_PCIE_1_AUX_CLK>,
>> + <GCC_PCIE_1_AUX_CLK_SRC>, <GCC_PCIE_1_CFG_AHB_CLK>,
>> + <GCC_PCIE_1_MSTR_AXI_CLK>, <GCC_PCIE_1_PHY_RCHNG_CLK_SRC>,
>> + <GCC_PCIE_1_PIPE_CLK>, <GCC_PCIE_1_PIPE_CLK_SRC>,
>> + <GCC_PCIE_1_SLV_AXI_CLK>, <GCC_PCIE_1_SLV_Q2A_AXI_CLK>,
>> + <GCC_QSPI_CNOC_PERIPH_AHB_CLK>, <GCC_QSPI_CORE_CLK>,
>> + <GCC_QSPI_CORE_CLK_SRC>,<GCC_USB30_SEC_MASTER_CLK>,
>> + <GCC_USB30_SEC_MASTER_CLK_SRC>, <GCC_USB30_SEC_MOCK_UTMI_CLK>,
>> + <GCC_USB30_SEC_MOCK_UTMI_CLK_SRC>,
>> + <GCC_USB30_SEC_MOCK_UTMI_POSTDIV_CLK_SRC>, <GCC_USB30_SEC_SLEEP_CLK>,
>> + <GCC_USB3_SEC_PHY_AUX_CLK>, <GCC_USB3_SEC_PHY_AUX_CLK_SRC>,
>> + <GCC_USB3_SEC_PHY_COM_AUX_CLK>, <GCC_USB3_SEC_PHY_PIPE_CLK>,
>> + <GCC_USB3_SEC_PHY_PIPE_CLK_SRC>, <GCC_CFG_NOC_LPASS_CLK>,
>> + <GCC_MSS_GPLL0_MAIN_DIV_CLK_SRC>, <GCC_MSS_CFG_AHB_CLK>,
>> + <GCC_MSS_OFFLINE_AXI_CLK>, <GCC_MSS_SNOC_AXI_CLK>,
>> + <GCC_MSS_Q6_MEMNOC_AXI_CLK>, <GCC_MSS_Q6SS_BOOT_CLK_SRC>,
>> + <GCC_SEC_CTRL_CLK_SRC>, <GCC_WPSS_AHB_CLK>,
>> + <GCC_WPSS_AHB_BDG_MST_CLK>, <GCC_WPSS_RSCP_CLK>;
>> +};
>>
>> ---
>> base-commit: 808eb958781e4ebb6e9c0962af2e856767e20f45
>> change-id: 20250206-protected_clock_qcm6490-4019e6a61d0b
>>
>> Best regards,
>> --
>> Taniya Das <quic_tdas@quicinc.com>
>>
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [PATCH] arm64: dts: qcom: qcm6490-idp: Update protected clocks list
2025-02-27 4:12 ` Taniya Das
@ 2025-02-27 4:20 ` Dmitry Baryshkov
2025-02-27 4:26 ` Taniya Das
0 siblings, 1 reply; 13+ messages in thread
From: Dmitry Baryshkov @ 2025-02-27 4:20 UTC (permalink / raw)
To: Taniya Das
Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Ajit Pandey, Imran Shaik, Jagadeesh Kona,
linux-arm-msm, devicetree, linux-kernel
On Thu, Feb 27, 2025 at 09:42:39AM +0530, Taniya Das wrote:
>
>
> On 2/26/2025 10:12 AM, Bjorn Andersson wrote:
> > On Thu, Feb 06, 2025 at 03:43:21PM +0530, Taniya Das wrote:
> >> Certain clocks are not accessible on QCM6490-IDP board,
> >> thus mark them as protected.
> >>
> >> Signed-off-by: Taniya Das <quic_tdas@quicinc.com>
> >> ---
> >> Mark few clocks as protected on IDP of QCM6490.
> >>
> >> This patchset is separated out from the series[1] to remove dependency from
> >> the LPASS reset.
> >> [1]: https://lore.kernel.org/all/20240816-qcm6490-lpass-reset-v1-0-a11f33cad3c5@quicinc.com/
> >> ---
> >> arch/arm64/boot/dts/qcom/qcm6490-idp.dts | 21 +++++++++++++++++++++
> >
> > I merged the patch adding this board in November 2023, are you saying
> > that for the last 15 months no one has actually booted it!?
> >
>
> I am not sure, I had got request to help boot the board which was not
> due to these clocks.
So, was the original submission in November 2023 broken or was it broken
by a later firmware upgrade which started to protect those clocks?
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] arm64: dts: qcom: qcm6490-idp: Update protected clocks list
2025-02-27 4:20 ` Dmitry Baryshkov
@ 2025-02-27 4:26 ` Taniya Das
2025-02-27 4:32 ` Dmitry Baryshkov
2025-03-04 4:51 ` Bjorn Andersson
0 siblings, 2 replies; 13+ messages in thread
From: Taniya Das @ 2025-02-27 4:26 UTC (permalink / raw)
To: Dmitry Baryshkov
Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Ajit Pandey, Imran Shaik, Jagadeesh Kona,
linux-arm-msm, devicetree, linux-kernel
On 2/27/2025 9:50 AM, Dmitry Baryshkov wrote:
> On Thu, Feb 27, 2025 at 09:42:39AM +0530, Taniya Das wrote:
>>
>>
>> On 2/26/2025 10:12 AM, Bjorn Andersson wrote:
>>> On Thu, Feb 06, 2025 at 03:43:21PM +0530, Taniya Das wrote:
>>>> Certain clocks are not accessible on QCM6490-IDP board,
>>>> thus mark them as protected.
>>>>
>>>> Signed-off-by: Taniya Das <quic_tdas@quicinc.com>
>>>> ---
>>>> Mark few clocks as protected on IDP of QCM6490.
>>>>
>>>> This patchset is separated out from the series[1] to remove dependency from
>>>> the LPASS reset.
>>>> [1]: https://lore.kernel.org/all/20240816-qcm6490-lpass-reset-v1-0-a11f33cad3c5@quicinc.com/
>>>> ---
>>>> arch/arm64/boot/dts/qcom/qcm6490-idp.dts | 21 +++++++++++++++++++++
>>>
>>> I merged the patch adding this board in November 2023, are you saying
>>> that for the last 15 months no one has actually booted it!?
>>>
>>
>> I am not sure, I had got request to help boot the board which was not
>> due to these clocks.
>
> So, was the original submission in November 2023 broken or was it broken
> by a later firmware upgrade which started to protect those clocks?
>
That's a fair question, probably the later broke it.
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] arm64: dts: qcom: qcm6490-idp: Update protected clocks list
2025-02-27 4:26 ` Taniya Das
@ 2025-02-27 4:32 ` Dmitry Baryshkov
2025-02-27 4:33 ` Taniya Das
2025-03-04 4:51 ` Bjorn Andersson
1 sibling, 1 reply; 13+ messages in thread
From: Dmitry Baryshkov @ 2025-02-27 4:32 UTC (permalink / raw)
To: Taniya Das
Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Ajit Pandey, Imran Shaik, Jagadeesh Kona,
linux-arm-msm, devicetree, linux-kernel
On Thu, Feb 27, 2025 at 09:56:27AM +0530, Taniya Das wrote:
>
>
> On 2/27/2025 9:50 AM, Dmitry Baryshkov wrote:
> > On Thu, Feb 27, 2025 at 09:42:39AM +0530, Taniya Das wrote:
> >>
> >>
> >> On 2/26/2025 10:12 AM, Bjorn Andersson wrote:
> >>> On Thu, Feb 06, 2025 at 03:43:21PM +0530, Taniya Das wrote:
> >>>> Certain clocks are not accessible on QCM6490-IDP board,
> >>>> thus mark them as protected.
> >>>>
> >>>> Signed-off-by: Taniya Das <quic_tdas@quicinc.com>
> >>>> ---
> >>>> Mark few clocks as protected on IDP of QCM6490.
> >>>>
> >>>> This patchset is separated out from the series[1] to remove dependency from
> >>>> the LPASS reset.
> >>>> [1]: https://lore.kernel.org/all/20240816-qcm6490-lpass-reset-v1-0-a11f33cad3c5@quicinc.com/
> >>>> ---
> >>>> arch/arm64/boot/dts/qcom/qcm6490-idp.dts | 21 +++++++++++++++++++++
> >>>
> >>> I merged the patch adding this board in November 2023, are you saying
> >>> that for the last 15 months no one has actually booted it!?
> >>>
> >>
> >> I am not sure, I had got request to help boot the board which was not
> >> due to these clocks.
> >
> > So, was the original submission in November 2023 broken or was it broken
> > by a later firmware upgrade which started to protect those clocks?
> >
> That's a fair question, probably the later broke it.
Could you please document it this way? This would have removed possible
questions by Bjorn.
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] arm64: dts: qcom: qcm6490-idp: Update protected clocks list
2025-02-27 4:32 ` Dmitry Baryshkov
@ 2025-02-27 4:33 ` Taniya Das
0 siblings, 0 replies; 13+ messages in thread
From: Taniya Das @ 2025-02-27 4:33 UTC (permalink / raw)
To: Dmitry Baryshkov
Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Ajit Pandey, Imran Shaik, Jagadeesh Kona,
linux-arm-msm, devicetree, linux-kernel
On 2/27/2025 10:02 AM, Dmitry Baryshkov wrote:
> On Thu, Feb 27, 2025 at 09:56:27AM +0530, Taniya Das wrote:
>>
>>
>> On 2/27/2025 9:50 AM, Dmitry Baryshkov wrote:
>>> On Thu, Feb 27, 2025 at 09:42:39AM +0530, Taniya Das wrote:
>>>>
>>>>
>>>> On 2/26/2025 10:12 AM, Bjorn Andersson wrote:
>>>>> On Thu, Feb 06, 2025 at 03:43:21PM +0530, Taniya Das wrote:
>>>>>> Certain clocks are not accessible on QCM6490-IDP board,
>>>>>> thus mark them as protected.
>>>>>>
>>>>>> Signed-off-by: Taniya Das <quic_tdas@quicinc.com>
>>>>>> ---
>>>>>> Mark few clocks as protected on IDP of QCM6490.
>>>>>>
>>>>>> This patchset is separated out from the series[1] to remove dependency from
>>>>>> the LPASS reset.
>>>>>> [1]: https://lore.kernel.org/all/20240816-qcm6490-lpass-reset-v1-0-a11f33cad3c5@quicinc.com/
>>>>>> ---
>>>>>> arch/arm64/boot/dts/qcom/qcm6490-idp.dts | 21 +++++++++++++++++++++
>>>>>
>>>>> I merged the patch adding this board in November 2023, are you saying
>>>>> that for the last 15 months no one has actually booted it!?
>>>>>
>>>>
>>>> I am not sure, I had got request to help boot the board which was not
>>>> due to these clocks.
>>>
>>> So, was the original submission in November 2023 broken or was it broken
>>> by a later firmware upgrade which started to protect those clocks?
>>>
>> That's a fair question, probably the later broke it.
>
> Could you please document it this way? This would have removed possible
> questions by Bjorn.
>
Sure, will take care and resubmit.
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] arm64: dts: qcom: qcm6490-idp: Update protected clocks list
2025-02-27 4:26 ` Taniya Das
2025-02-27 4:32 ` Dmitry Baryshkov
@ 2025-03-04 4:51 ` Bjorn Andersson
1 sibling, 0 replies; 13+ messages in thread
From: Bjorn Andersson @ 2025-03-04 4:51 UTC (permalink / raw)
To: Taniya Das
Cc: Dmitry Baryshkov, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Ajit Pandey, Imran Shaik,
Jagadeesh Kona, linux-arm-msm, devicetree, linux-kernel
On Thu, Feb 27, 2025 at 09:56:27AM +0530, Taniya Das wrote:
>
>
> On 2/27/2025 9:50 AM, Dmitry Baryshkov wrote:
> > On Thu, Feb 27, 2025 at 09:42:39AM +0530, Taniya Das wrote:
> >>
> >>
> >> On 2/26/2025 10:12 AM, Bjorn Andersson wrote:
> >>> On Thu, Feb 06, 2025 at 03:43:21PM +0530, Taniya Das wrote:
> >>>> Certain clocks are not accessible on QCM6490-IDP board,
> >>>> thus mark them as protected.
> >>>>
> >>>> Signed-off-by: Taniya Das <quic_tdas@quicinc.com>
> >>>> ---
> >>>> Mark few clocks as protected on IDP of QCM6490.
> >>>>
> >>>> This patchset is separated out from the series[1] to remove dependency from
> >>>> the LPASS reset.
> >>>> [1]: https://lore.kernel.org/all/20240816-qcm6490-lpass-reset-v1-0-a11f33cad3c5@quicinc.com/
> >>>> ---
> >>>> arch/arm64/boot/dts/qcom/qcm6490-idp.dts | 21 +++++++++++++++++++++
> >>>
> >>> I merged the patch adding this board in November 2023, are you saying
> >>> that for the last 15 months no one has actually booted it!?
> >>>
> >>
> >> I am not sure, I had got request to help boot the board which was not
> >> due to these clocks.
> >
> > So, was the original submission in November 2023 broken or was it broken
> > by a later firmware upgrade which started to protect those clocks?
> >
> That's a fair question, probably the later broke it.
Given that the now introduced list of protected clocks exactly matches
the initial (incorrect) set for rb3gen2 I would be very surprised if
someone since then changed the IDP firmware to protect all those clocks.
More likely IDP was either not tested in a clean upstream build or
possibly only tested with no-ac firmware.
Regards,
Bjorn
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] arm64: dts: qcom: qcm6490-idp: Update protected clocks list
2025-02-06 10:13 [PATCH] arm64: dts: qcom: qcm6490-idp: Update protected clocks list Taniya Das
2025-02-26 4:42 ` Bjorn Andersson
@ 2025-03-17 2:55 ` Bjorn Andersson
2025-03-17 11:35 ` Dmitry Baryshkov
1 sibling, 1 reply; 13+ messages in thread
From: Bjorn Andersson @ 2025-03-17 2:55 UTC (permalink / raw)
To: Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Taniya Das
Cc: Ajit Pandey, Imran Shaik, Jagadeesh Kona, linux-arm-msm,
devicetree, linux-kernel
On Thu, 06 Feb 2025 15:43:21 +0530, Taniya Das wrote:
> Certain clocks are not accessible on QCM6490-IDP board,
> thus mark them as protected.
>
>
Applied, thanks!
[1/1] arm64: dts: qcom: qcm6490-idp: Update protected clocks list
commit: d40da533a701ef9e22f89e5ceee1ab48150daa30
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [PATCH] arm64: dts: qcom: qcm6490-idp: Update protected clocks list
2025-03-17 2:55 ` Bjorn Andersson
@ 2025-03-17 11:35 ` Dmitry Baryshkov
0 siblings, 0 replies; 13+ messages in thread
From: Dmitry Baryshkov @ 2025-03-17 11:35 UTC (permalink / raw)
To: Bjorn Andersson
Cc: Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Taniya Das, Ajit Pandey, Imran Shaik, Jagadeesh Kona,
linux-arm-msm, devicetree, linux-kernel
On Sun, Mar 16, 2025 at 09:55:57PM -0500, Bjorn Andersson wrote:
>
> On Thu, 06 Feb 2025 15:43:21 +0530, Taniya Das wrote:
> > Certain clocks are not accessible on QCM6490-IDP board,
> > thus mark them as protected.
> >
> >
>
> Applied, thanks!
>
> [1/1] arm64: dts: qcom: qcm6490-idp: Update protected clocks list
> commit: d40da533a701ef9e22f89e5ceee1ab48150daa30
I thought that you wrote that the list of clocks is incorrect...
>
> Best regards,
> --
> Bjorn Andersson <andersson@kernel.org>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2025-03-17 11:35 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-02-06 10:13 [PATCH] arm64: dts: qcom: qcm6490-idp: Update protected clocks list Taniya Das
2025-02-26 4:42 ` Bjorn Andersson
2025-02-26 5:01 ` Trilok Soni
2025-02-26 17:55 ` Konrad Dybcio
2025-02-27 4:11 ` Taniya Das
2025-02-27 4:12 ` Taniya Das
2025-02-27 4:20 ` Dmitry Baryshkov
2025-02-27 4:26 ` Taniya Das
2025-02-27 4:32 ` Dmitry Baryshkov
2025-02-27 4:33 ` Taniya Das
2025-03-04 4:51 ` Bjorn Andersson
2025-03-17 2:55 ` Bjorn Andersson
2025-03-17 11:35 ` Dmitry Baryshkov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®