From: pHilipp Zabel <philipp.zabel@gmail.com>
To: Paul Mundt <lethal@linux-sh.org>, Ian Molton <ian@mnementh.co.uk>,
Magnus Damm <magnus.damm@gmail.com>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
Guennadi Liakhovetski <g.liakhovetski@gmx.de>,
linux-kernel@vger.kernel.org, Pierre Ossman <drzeus@drzeus.cx>,
Magnus Damm <damm@opensource.se>
Subject: Re: MMC: Make the configuration memory resource optional
Date: Wed, 29 Jul 2009 22:55:31 +0200 [thread overview]
Message-ID: <74d0deb30907291355n39df7db0v1d7afc93917adc14@mail.gmail.com> (raw)
In-Reply-To: <20090729201702.GA28202@linux-sh.org>
On Wed, Jul 29, 2009 at 10:17 PM, Paul Mundt<lethal@linux-sh.org> wrote:
> On Wed, Jul 29, 2009 at 02:51:36PM +0100, Ian Molton wrote:
>> Magnus Damm wrote:
>> >Note that I don't need clocklib to get the tmio_mmc driver working for
>> >my platform. It's something _you_ need for the MFD chips. But you seem
>> >to want me to fix it for you even though I don't have any particular
>> >need for it.
>>
>> Actually, the tmio-mmc driver works perfectly on the MFD chips right
>> now. These are the chips it was written to handle.
>>
> And these patches are fixing up the mmc driver to support the non-MFD
> case. If you want to fix up the MFD driver to expose a similar interface
> to the mmc one as what we are doing with the clock framework, that is
> fine, but is likewise an unrelated change.
>
> Lets evaluate the clock options we have today:
>
> 1) clock framework
> 2) clkdev
2) is nothing more than an implementation detail of 1). How clk_get
looks up the struct clk internally should not be of any concern to the
consumer.
> 3) clocklib
>
> #1 is what these patches are written for, and the only standard in-tree
> interface that we have cross platform today. #2 could be generalized, but
> that needs discussion by itself, as it was never proposed as a standard
> interface and never submitted to l-k for review. #3 is not in the kernel
> today and it's not clear that it ever will be.
Yes, 3) is unlikely to happen in the near future.
[...]
> If you can show what is wrong with how the clock framework is being used
> in the patch that Guennadi posted, we will certainly rework it as
> necessary. However, I will not at this point be merging clkdev in to my
> architecture tree, and clocklib I have never supported. These are things
> that can be done and supported incrementally, but making these
> prerequisites is simply blocking progress, especially when there is no
> consensus on the clkdev/clocklib parts.
Providing the clock consumer ID via platform data is wrong. As I
understand it, that ID should be either NULL if the clock can be
determined from the struct device pointer (i.e. if it's the only clock
provided to that device), or it should be used to distinguish the
device's clock input pins (in the tmio-mmc case that would be 'hclk'
or 'clk32' if I remember the datasheet correctly).
>> Can we keep it technical now, please?
[...]
regards
Philipp
next prev parent reply other threads:[~2009-07-29 20:55 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-17 11:10 Guennadi Liakhovetski
2009-07-17 14:19 ` Magnus Damm
2009-07-17 14:34 ` [PATCH] " Guennadi Liakhovetski
2009-07-17 17:38 ` Ian Molton
2009-07-23 10:29 ` Magnus Damm
2009-07-28 13:55 ` Ian Molton
2009-07-29 2:48 ` Magnus Damm
2009-07-29 10:24 ` Ian Molton
2009-07-29 11:58 ` Mark Brown
2009-07-29 12:27 ` Magnus Damm
2009-07-29 12:35 ` Paul Mundt
2009-07-29 12:42 ` Mark Brown
2009-07-29 12:51 ` Magnus Damm
2009-07-29 12:58 ` Ian Molton
2009-07-29 13:08 ` Magnus Damm
2009-07-29 13:51 ` Ian Molton
2009-07-29 20:17 ` Paul Mundt
2009-07-29 20:55 ` pHilipp Zabel [this message]
2009-07-29 21:03 ` Paul Mundt
2009-07-30 9:59 ` Ian Molton
2009-07-30 10:56 ` Guennadi Liakhovetski
2009-07-30 19:21 ` Ian Molton
2009-07-31 6:55 ` Guennadi Liakhovetski
2009-08-03 18:51 ` Ian Molton
2009-08-05 13:33 ` Guennadi Liakhovetski
2009-08-05 14:10 ` Ian Molton
2009-08-03 2:52 ` Magnus Damm
2009-08-04 18:21 ` Ian Molton
2009-08-05 2:08 ` Magnus Damm
2009-08-05 12:07 ` Ian Molton
2009-08-05 13:34 ` Ian Molton
2009-08-05 19:44 ` Guennadi Liakhovetski
2009-08-05 22:34 ` Ian Molton
2009-08-05 22:53 ` Guennadi Liakhovetski
2009-08-05 23:06 ` Ian Molton
2009-08-18 8:40 ` Magnus Damm
2009-08-09 19:10 ` MMC / MFD / Clocks Ian Molton
2009-08-10 3:48 ` Magnus Damm
2009-08-05 14:02 ` Example idea for how to solve the clock/cnf problem Ian Molton
2009-08-05 22:43 ` Ian Molton
2009-09-02 10:44 ` Magnus Damm
2009-07-30 19:33 ` MMC: Make the configuration memory resource optional Ian Molton
2009-07-29 13:11 ` Mark Brown
2009-07-29 12:59 ` Mark Brown
2009-07-29 12:37 ` Ian Molton
2009-07-29 7:31 ` Paul Mundt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=74d0deb30907291355n39df7db0v1d7afc93917adc14@mail.gmail.com \
--to=philipp.zabel@gmail.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=damm@opensource.se \
--cc=drzeus@drzeus.cx \
--cc=g.liakhovetski@gmx.de \
--cc=ian@mnementh.co.uk \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=magnus.damm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®