mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
To: Ian Molton <ian@mnementh.co.uk>
Cc: pHilipp Zabel <philipp.zabel@gmail.com>,
	Paul Mundt <lethal@linux-sh.org>,
	Magnus Damm <magnus.damm@gmail.com>,
	Mark Brown <broonie@opensource.wolfsonmicro.com>,
	linux-kernel@vger.kernel.org, Pierre Ossman <drzeus@drzeus.cx>,
	Magnus Damm <damm@opensource.se>
Subject: Re: MMC: Make the configuration memory resource optional
Date: Fri, 31 Jul 2009 08:55:30 +0200 (CEST)	[thread overview]
Message-ID: <Pine.LNX.4.64.0907310853470.4541@axis700.grange> (raw)
In-Reply-To: <4A71F2A5.4060206@mnementh.co.uk>

On Thu, 30 Jul 2009, Ian Molton wrote:

> Guennadi Liakhovetski wrote:
> 
> > While you're at it, please, consider swapping the two lines in
> > tmio_mmc_probe():
> > 
> > -	tmio_mmc_clk_stop(host);
> > 	reset(host);
> > +	tmio_mmc_clk_stop(host);
> > 
> > Otherwise, I think, reset causes problems trying to access the controller
> > with disabled clock. At least this is needed on SuperH.
> 
> Interesting. I'll see what the result of this is on TMIO - This sequence was
> garnered from the WinCE driver for the chip.
> 
> I cant see _why_ this should be a problem, as this disables the card clock,
> not HCLK. Could you debug further in tmio_mmc_clk_stop() please and see if
> reordering only one of the two IO accesses cures this?

Not sure I understood the "reordering only one of the two IO accesses" 
correctly, but I swapped the two sd_ctrl_write16() calls in 
tmio_mmc_clk_stop() and no, it didn't cure the problem.

Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/

  reply	other threads:[~2009-07-31  6:55 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-17 11:10 Guennadi Liakhovetski
2009-07-17 14:19 ` Magnus Damm
2009-07-17 14:34   ` [PATCH] " Guennadi Liakhovetski
2009-07-17 17:38     ` Ian Molton
2009-07-23 10:29     ` Magnus Damm
2009-07-28 13:55 ` Ian Molton
2009-07-29  2:48   ` Magnus Damm
2009-07-29 10:24     ` Ian Molton
2009-07-29 11:58     ` Mark Brown
2009-07-29 12:27       ` Magnus Damm
2009-07-29 12:35         ` Paul Mundt
2009-07-29 12:42         ` Mark Brown
2009-07-29 12:51           ` Magnus Damm
2009-07-29 12:58             ` Ian Molton
2009-07-29 13:08               ` Magnus Damm
2009-07-29 13:51                 ` Ian Molton
2009-07-29 20:17                   ` Paul Mundt
2009-07-29 20:55                     ` pHilipp Zabel
2009-07-29 21:03                       ` Paul Mundt
2009-07-30  9:59                       ` Ian Molton
2009-07-30 10:56                         ` Guennadi Liakhovetski
2009-07-30 19:21                           ` Ian Molton
2009-07-31  6:55                             ` Guennadi Liakhovetski [this message]
2009-08-03 18:51                               ` Ian Molton
2009-08-05 13:33                                 ` Guennadi Liakhovetski
2009-08-05 14:10                                   ` Ian Molton
2009-08-03  2:52                             ` Magnus Damm
2009-08-04 18:21                               ` Ian Molton
2009-08-05  2:08                                 ` Magnus Damm
2009-08-05 12:07                                   ` Ian Molton
2009-08-05 13:34                                   ` Ian Molton
2009-08-05 19:44                                     ` Guennadi Liakhovetski
2009-08-05 22:34                                       ` Ian Molton
2009-08-05 22:53                                         ` Guennadi Liakhovetski
2009-08-05 23:06                                           ` Ian Molton
2009-08-18  8:40                                             ` Magnus Damm
2009-08-09 19:10                                       ` MMC / MFD / Clocks Ian Molton
2009-08-10  3:48                                         ` Magnus Damm
2009-08-05 14:02                                   ` Example idea for how to solve the clock/cnf problem Ian Molton
2009-08-05 22:43                                     ` Ian Molton
2009-09-02 10:44                                       ` Magnus Damm
2009-07-30 19:33                           ` MMC: Make the configuration memory resource optional Ian Molton
2009-07-29 13:11               ` Mark Brown
2009-07-29 12:59             ` Mark Brown
2009-07-29 12:37       ` Ian Molton
2009-07-29  7:31   ` Paul Mundt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0907310853470.4541@axis700.grange \
    --to=g.liakhovetski@gmx.de \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=damm@opensource.se \
    --cc=drzeus@drzeus.cx \
    --cc=ian@mnementh.co.uk \
    --cc=lethal@linux-sh.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=philipp.zabel@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®