mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH 00/16] Staging: rtl8192e: Cleanup even more camelcase variable names
@ 2024-09-08 19:26 Tree Davies
  2024-09-08 19:26 ` [PATCH 01/16] Staging: rtl8192e: Rename variable pReorderEntry Tree Davies
                   ` (16 more replies)
  0 siblings, 17 replies; 18+ messages in thread
From: Tree Davies @ 2024-09-08 19:26 UTC (permalink / raw)
  To: gregkh, philipp.g.hortmann, anjan
  Cc: linux-staging, linux-kernel, Tree Davies

This series performs variable renames
~ Tree

Tree Davies (16):
  Staging: rtl8192e: Rename variable pReorderEntry
  Staging: rtl8192e: Rename variable SeqNum
  Staging: rtl8192e: Rename variable SignalStrength
  Staging: rtl8192e: Rename variable pFrame
  Staging: rtl8192e: Rename variable bPacketToSelf
  Staging: rtl8192e: Rename variable Para1
  Staging: rtl8192e: Rename variable Para2
  Staging: rtl8192e: Rename variable ScanOperationBackupHandler
  Staging: rtl8192e: Rename variable Operation
  Staging: rtl8192e: Rename variable bAssoc
  Staging: rtl8192e: Rename variable SignalQuality
  Staging: rtl8192e: Rename variable isEncrypt
  Staging: rtl8192e: Rename variable nStuckCount
  Staging: rtl8192e: Rename variable bAddNewTs
  Staging: rtl8192e: Rename variable RxBufShift
  Staging: rtl8192e: Rename variable RxDrvInfoSize

 .../staging/rtl8192e/rtl8192e/r8190P_def.h    |   2 +-
 .../staging/rtl8192e/rtl8192e/r8192E_dev.c    |  40 +++---
 .../staging/rtl8192e/rtl8192e/r8192E_phy.c    |  22 ++--
 .../staging/rtl8192e/rtl8192e/r8192E_phy.h    |   4 +-
 drivers/staging/rtl8192e/rtl8192e/rtl_core.c  |  14 +--
 drivers/staging/rtl8192e/rtl8192e/rtl_wx.c    |   4 +-
 drivers/staging/rtl8192e/rtl819x_HTProc.c     |   4 +-
 drivers/staging/rtl8192e/rtl819x_TSProc.c     |  30 ++---
 drivers/staging/rtl8192e/rtllib.h             |  32 ++---
 drivers/staging/rtl8192e/rtllib_rx.c          | 116 +++++++++---------
 drivers/staging/rtl8192e/rtllib_softmac_wx.c  |   4 +-
 11 files changed, 136 insertions(+), 136 deletions(-)

-- 
2.30.2


^ permalink raw reply	[flat|nested] 18+ messages in thread

* [PATCH 01/16] Staging: rtl8192e: Rename variable pReorderEntry
  2024-09-08 19:26 [PATCH 00/16] Staging: rtl8192e: Cleanup even more camelcase variable names Tree Davies
@ 2024-09-08 19:26 ` Tree Davies
  2024-09-08 19:26 ` [PATCH 02/16] Staging: rtl8192e: Rename variable SeqNum Tree Davies
                   ` (15 subsequent siblings)
  16 siblings, 0 replies; 18+ messages in thread
From: Tree Davies @ 2024-09-08 19:26 UTC (permalink / raw)
  To: gregkh, philipp.g.hortmann, anjan
  Cc: linux-staging, linux-kernel, Tree Davies

Rename variable pReorderEntry to reorder_entry
to fix checkpatch warning Avoid CamelCase.

Signed-off-by: Tree Davies <tdavies@darkphysics.net>
---
 drivers/staging/rtl8192e/rtl819x_TSProc.c | 20 +++++------
 drivers/staging/rtl8192e/rtllib_rx.c      | 44 +++++++++++------------
 2 files changed, 32 insertions(+), 32 deletions(-)

diff --git a/drivers/staging/rtl8192e/rtl819x_TSProc.c b/drivers/staging/rtl8192e/rtl819x_TSProc.c
index ed6a488bc7ac..abdae7e36588 100644
--- a/drivers/staging/rtl8192e/rtl819x_TSProc.c
+++ b/drivers/staging/rtl8192e/rtl819x_TSProc.c
@@ -14,7 +14,7 @@ static void RxPktPendingTimeout(struct timer_list *t)
 	struct rtllib_device *ieee = container_of(ts, struct rtllib_device,
 						  rx_ts_records[ts->num]);
 
-	struct rx_reorder_entry *pReorderEntry = NULL;
+	struct rx_reorder_entry *reorder_entry = NULL;
 
 	unsigned long flags = 0;
 	u8 index = 0;
@@ -23,31 +23,31 @@ static void RxPktPendingTimeout(struct timer_list *t)
 	spin_lock_irqsave(&(ieee->reorder_spinlock), flags);
 	if (ts->rx_timeout_indicate_seq != 0xffff) {
 		while (!list_empty(&ts->rx_pending_pkt_list)) {
-			pReorderEntry = (struct rx_reorder_entry *)
+			reorder_entry = (struct rx_reorder_entry *)
 					list_entry(ts->rx_pending_pkt_list.prev,
 					struct rx_reorder_entry, list);
 			if (index == 0)
-				ts->rx_indicate_seq = pReorderEntry->SeqNum;
+				ts->rx_indicate_seq = reorder_entry->SeqNum;
 
-			if (SN_LESS(pReorderEntry->SeqNum,
+			if (SN_LESS(reorder_entry->SeqNum,
 				    ts->rx_indicate_seq) ||
-			    SN_EQUAL(pReorderEntry->SeqNum,
+			    SN_EQUAL(reorder_entry->SeqNum,
 				     ts->rx_indicate_seq)) {
-				list_del_init(&pReorderEntry->list);
+				list_del_init(&reorder_entry->list);
 
-				if (SN_EQUAL(pReorderEntry->SeqNum,
+				if (SN_EQUAL(reorder_entry->SeqNum,
 				    ts->rx_indicate_seq))
 					ts->rx_indicate_seq =
 					      (ts->rx_indicate_seq + 1) % 4096;
 
 				netdev_dbg(ieee->dev,
 					   "%s(): Indicate SeqNum: %d\n",
-					   __func__, pReorderEntry->SeqNum);
+					   __func__, reorder_entry->SeqNum);
 				ieee->stats_IndicateArray[index] =
-							 pReorderEntry->prxb;
+							 reorder_entry->prxb;
 				index++;
 
-				list_add_tail(&pReorderEntry->list,
+				list_add_tail(&reorder_entry->list,
 					      &ieee->RxReorder_Unused_List);
 			} else {
 				pkt_in_buf = true;
diff --git a/drivers/staging/rtl8192e/rtllib_rx.c b/drivers/staging/rtl8192e/rtllib_rx.c
index d7d59761e0f4..cba4b244f808 100644
--- a/drivers/staging/rtl8192e/rtllib_rx.c
+++ b/drivers/staging/rtl8192e/rtllib_rx.c
@@ -403,26 +403,26 @@ static int is_duplicate_packet(struct rtllib_device *ieee,
 }
 
 static bool add_reorder_entry(struct rx_ts_record *ts,
-			      struct rx_reorder_entry *pReorderEntry)
+			      struct rx_reorder_entry *reorder_entry)
 {
 	struct list_head *list = &ts->rx_pending_pkt_list;
 
 	while (list->next != &ts->rx_pending_pkt_list) {
-		if (SN_LESS(pReorderEntry->SeqNum, ((struct rx_reorder_entry *)
+		if (SN_LESS(reorder_entry->SeqNum, ((struct rx_reorder_entry *)
 		    list_entry(list->next, struct rx_reorder_entry,
 		    list))->SeqNum))
 			list = list->next;
-		else if (SN_EQUAL(pReorderEntry->SeqNum,
+		else if (SN_EQUAL(reorder_entry->SeqNum,
 			((struct rx_reorder_entry *)list_entry(list->next,
 			struct rx_reorder_entry, list))->SeqNum))
 			return false;
 		else
 			break;
 	}
-	pReorderEntry->list.next = list->next;
-	pReorderEntry->list.next->prev = &pReorderEntry->list;
-	pReorderEntry->list.prev = list;
-	list->next = &pReorderEntry->list;
+	reorder_entry->list.next = list->next;
+	reorder_entry->list.next->prev = &reorder_entry->list;
+	reorder_entry->list.prev = list;
+	list->next = &reorder_entry->list;
 
 	return true;
 }
@@ -524,7 +524,7 @@ static void rx_reorder_indicate_packet(struct rtllib_device *ieee,
 				       struct rx_ts_record *ts, u16 SeqNum)
 {
 	struct rt_hi_throughput *ht_info = ieee->ht_info;
-	struct rx_reorder_entry *pReorderEntry = NULL;
+	struct rx_reorder_entry *reorder_entry = NULL;
 	u8 win_size = ht_info->rx_reorder_win_size;
 	u16 win_end = 0;
 	u8 index = 0;
@@ -598,25 +598,25 @@ static void rx_reorder_indicate_packet(struct rtllib_device *ieee,
 	} else {
 		/* Current packet is going to be inserted into pending list.*/
 		if (!list_empty(&ieee->RxReorder_Unused_List)) {
-			pReorderEntry = (struct rx_reorder_entry *)
+			reorder_entry = (struct rx_reorder_entry *)
 					list_entry(ieee->RxReorder_Unused_List.next,
 					struct rx_reorder_entry, list);
-			list_del_init(&pReorderEntry->list);
+			list_del_init(&reorder_entry->list);
 
 			/* Make a reorder entry and insert
 			 * into a the packet list.
 			 */
-			pReorderEntry->SeqNum = SeqNum;
-			pReorderEntry->prxb = prxb;
+			reorder_entry->SeqNum = SeqNum;
+			reorder_entry->prxb = prxb;
 
-			if (!add_reorder_entry(ts, pReorderEntry)) {
+			if (!add_reorder_entry(ts, reorder_entry)) {
 				int i;
 
 				netdev_dbg(ieee->dev,
 					   "%s(): Duplicate packet is dropped. IndicateSeq: %d, NewSeq: %d\n",
 					   __func__, ts->rx_indicate_seq,
 					   SeqNum);
-				list_add_tail(&pReorderEntry->list,
+				list_add_tail(&reorder_entry->list,
 					      &ieee->RxReorder_Unused_List);
 
 				for (i = 0; i < prxb->nr_subframes; i++)
@@ -653,12 +653,12 @@ static void rx_reorder_indicate_packet(struct rtllib_device *ieee,
 		netdev_dbg(ieee->dev, "%s(): start RREORDER indicate\n",
 			   __func__);
 
-		pReorderEntry = (struct rx_reorder_entry *)
+		reorder_entry = (struct rx_reorder_entry *)
 					list_entry(ts->rx_pending_pkt_list.prev,
 						   struct rx_reorder_entry,
 						   list);
-		if (SN_LESS(pReorderEntry->SeqNum, ts->rx_indicate_seq) ||
-		    SN_EQUAL(pReorderEntry->SeqNum, ts->rx_indicate_seq)) {
+		if (SN_LESS(reorder_entry->SeqNum, ts->rx_indicate_seq) ||
+		    SN_EQUAL(reorder_entry->SeqNum, ts->rx_indicate_seq)) {
 			/* This protect struct buffer from overflow. */
 			if (index >= REORDER_WIN_SIZE) {
 				netdev_err(ieee->dev,
@@ -668,18 +668,18 @@ static void rx_reorder_indicate_packet(struct rtllib_device *ieee,
 				break;
 			}
 
-			list_del_init(&pReorderEntry->list);
+			list_del_init(&reorder_entry->list);
 
-			if (SN_EQUAL(pReorderEntry->SeqNum, ts->rx_indicate_seq))
+			if (SN_EQUAL(reorder_entry->SeqNum, ts->rx_indicate_seq))
 				ts->rx_indicate_seq = (ts->rx_indicate_seq + 1) %
 						     4096;
 
-			ieee->prxb_indicate_array[index] = pReorderEntry->prxb;
+			ieee->prxb_indicate_array[index] = reorder_entry->prxb;
 			netdev_dbg(ieee->dev, "%s(): Indicate SeqNum %d!\n",
-				   __func__, pReorderEntry->SeqNum);
+				   __func__, reorder_entry->SeqNum);
 			index++;
 
-			list_add_tail(&pReorderEntry->list,
+			list_add_tail(&reorder_entry->list,
 				      &ieee->RxReorder_Unused_List);
 		} else {
 			pkt_in_buf = true;
-- 
2.30.2


^ permalink raw reply	[flat|nested] 18+ messages in thread

* [PATCH 02/16] Staging: rtl8192e: Rename variable SeqNum
  2024-09-08 19:26 [PATCH 00/16] Staging: rtl8192e: Cleanup even more camelcase variable names Tree Davies
  2024-09-08 19:26 ` [PATCH 01/16] Staging: rtl8192e: Rename variable pReorderEntry Tree Davies
@ 2024-09-08 19:26 ` Tree Davies
  2024-09-08 19:26 ` [PATCH 03/16] Staging: rtl8192e: Rename variable SignalStrength Tree Davies
                   ` (14 subsequent siblings)
  16 siblings, 0 replies; 18+ messages in thread
From: Tree Davies @ 2024-09-08 19:26 UTC (permalink / raw)
  To: gregkh, philipp.g.hortmann, anjan
  Cc: linux-staging, linux-kernel, Tree Davies

Rename variable SeqNum to seq_num
to fix checkpatch warning Avoid CamelCase.

Signed-off-by: Tree Davies <tdavies@darkphysics.net>
---
 drivers/staging/rtl8192e/rtl819x_TSProc.c | 16 ++---
 drivers/staging/rtl8192e/rtllib.h         |  2 +-
 drivers/staging/rtl8192e/rtllib_rx.c      | 78 +++++++++++------------
 3 files changed, 48 insertions(+), 48 deletions(-)

diff --git a/drivers/staging/rtl8192e/rtl819x_TSProc.c b/drivers/staging/rtl8192e/rtl819x_TSProc.c
index abdae7e36588..18b717a7409c 100644
--- a/drivers/staging/rtl8192e/rtl819x_TSProc.c
+++ b/drivers/staging/rtl8192e/rtl819x_TSProc.c
@@ -27,22 +27,22 @@ static void RxPktPendingTimeout(struct timer_list *t)
 					list_entry(ts->rx_pending_pkt_list.prev,
 					struct rx_reorder_entry, list);
 			if (index == 0)
-				ts->rx_indicate_seq = reorder_entry->SeqNum;
+				ts->rx_indicate_seq = reorder_entry->seq_num;
 
-			if (SN_LESS(reorder_entry->SeqNum,
+			if (SN_LESS(reorder_entry->seq_num,
 				    ts->rx_indicate_seq) ||
-			    SN_EQUAL(reorder_entry->SeqNum,
+			    SN_EQUAL(reorder_entry->seq_num,
 				     ts->rx_indicate_seq)) {
 				list_del_init(&reorder_entry->list);
 
-				if (SN_EQUAL(reorder_entry->SeqNum,
+				if (SN_EQUAL(reorder_entry->seq_num,
 				    ts->rx_indicate_seq))
 					ts->rx_indicate_seq =
 					      (ts->rx_indicate_seq + 1) % 4096;
 
 				netdev_dbg(ieee->dev,
-					   "%s(): Indicate SeqNum: %d\n",
-					   __func__, reorder_entry->SeqNum);
+					   "%s(): Indicate seq_num: %d\n",
+					   __func__, reorder_entry->seq_num);
 				ieee->stats_IndicateArray[index] =
 							 reorder_entry->prxb;
 				index++;
@@ -336,8 +336,8 @@ static void RemoveTsEntry(struct rtllib_device *ieee,
 			pRxReorderEntry = (struct rx_reorder_entry *)
 					list_entry(ts->rx_pending_pkt_list.prev,
 					struct rx_reorder_entry, list);
-			netdev_dbg(ieee->dev,  "%s(): Delete SeqNum %d!\n",
-				   __func__, pRxReorderEntry->SeqNum);
+			netdev_dbg(ieee->dev,  "%s(): Delete seq_num %d!\n",
+				   __func__, pRxReorderEntry->seq_num);
 			list_del_init(&pRxReorderEntry->list);
 			{
 				int i = 0;
diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h
index 4762cb52261a..b033e8345b0a 100644
--- a/drivers/staging/rtl8192e/rtllib.h
+++ b/drivers/staging/rtl8192e/rtllib.h
@@ -1015,7 +1015,7 @@ struct bandwidth_autoswitch {
 #define REORDER_ENTRY_NUM	128
 struct rx_reorder_entry {
 	struct list_head	list;
-	u16			SeqNum;
+	u16			seq_num;
 	struct rtllib_rxb *prxb;
 };
 
diff --git a/drivers/staging/rtl8192e/rtllib_rx.c b/drivers/staging/rtl8192e/rtllib_rx.c
index cba4b244f808..86beac9dd3a5 100644
--- a/drivers/staging/rtl8192e/rtllib_rx.c
+++ b/drivers/staging/rtl8192e/rtllib_rx.c
@@ -408,13 +408,13 @@ static bool add_reorder_entry(struct rx_ts_record *ts,
 	struct list_head *list = &ts->rx_pending_pkt_list;
 
 	while (list->next != &ts->rx_pending_pkt_list) {
-		if (SN_LESS(reorder_entry->SeqNum, ((struct rx_reorder_entry *)
+		if (SN_LESS(reorder_entry->seq_num, ((struct rx_reorder_entry *)
 		    list_entry(list->next, struct rx_reorder_entry,
-		    list))->SeqNum))
+		    list))->seq_num))
 			list = list->next;
-		else if (SN_EQUAL(reorder_entry->SeqNum,
+		else if (SN_EQUAL(reorder_entry->seq_num,
 			((struct rx_reorder_entry *)list_entry(list->next,
-			struct rx_reorder_entry, list))->SeqNum))
+			struct rx_reorder_entry, list))->seq_num))
 			return false;
 		else
 			break;
@@ -504,8 +504,8 @@ void rtllib_flush_rx_ts_pending_pkts(struct rtllib_device *ieee,
 		pRxReorderEntry = (struct rx_reorder_entry *)
 				  list_entry(ts->rx_pending_pkt_list.prev,
 					     struct rx_reorder_entry, list);
-		netdev_dbg(ieee->dev, "%s(): Indicate SeqNum %d!\n", __func__,
-			   pRxReorderEntry->SeqNum);
+		netdev_dbg(ieee->dev, "%s(): Indicate seq_num %d!\n", __func__,
+			   pRxReorderEntry->seq_num);
 		list_del_init(&pRxReorderEntry->list);
 
 		ieee->rfd_array[rfd_cnt] = pRxReorderEntry->prxb;
@@ -521,7 +521,7 @@ void rtllib_flush_rx_ts_pending_pkts(struct rtllib_device *ieee,
 
 static void rx_reorder_indicate_packet(struct rtllib_device *ieee,
 				       struct rtllib_rxb *prxb,
-				       struct rx_ts_record *ts, u16 SeqNum)
+				       struct rx_ts_record *ts, u16 seq_num)
 {
 	struct rt_hi_throughput *ht_info = ieee->ht_info;
 	struct rx_reorder_entry *reorder_entry = NULL;
@@ -533,20 +533,20 @@ static void rx_reorder_indicate_packet(struct rtllib_device *ieee,
 
 	netdev_dbg(ieee->dev,
 		   "%s(): Seq is %d, ts->rx_indicate_seq is %d, win_size is %d\n",
-		   __func__, SeqNum, ts->rx_indicate_seq, win_size);
+		   __func__, seq_num, ts->rx_indicate_seq, win_size);
 
 	spin_lock_irqsave(&(ieee->reorder_spinlock), flags);
 
 	win_end = (ts->rx_indicate_seq + win_size - 1) % 4096;
 	/* Rx Reorder initialize condition.*/
 	if (ts->rx_indicate_seq == 0xffff)
-		ts->rx_indicate_seq = SeqNum;
+		ts->rx_indicate_seq = seq_num;
 
-	/* Drop out the packet which SeqNum is smaller than WinStart */
-	if (SN_LESS(SeqNum, ts->rx_indicate_seq)) {
+	/* Drop out the packet which seq_num is smaller than WinStart */
+	if (SN_LESS(seq_num, ts->rx_indicate_seq)) {
 		netdev_dbg(ieee->dev,
 			   "Packet Drop! IndicateSeq: %d, NewSeq: %d\n",
-			   ts->rx_indicate_seq, SeqNum);
+			   ts->rx_indicate_seq, seq_num);
 		ht_info->rx_reorder_drop_counter++;
 		{
 			int i;
@@ -561,38 +561,38 @@ static void rx_reorder_indicate_packet(struct rtllib_device *ieee,
 	}
 
 	/* Sliding window manipulation. Conditions includes:
-	 * 1. Incoming SeqNum is equal to WinStart =>Window shift 1
-	 * 2. Incoming SeqNum is larger than the win_end => Window shift N
+	 * 1. Incoming seq_num is equal to WinStart =>Window shift 1
+	 * 2. Incoming seq_num is larger than the win_end => Window shift N
 	 */
-	if (SN_EQUAL(SeqNum, ts->rx_indicate_seq)) {
+	if (SN_EQUAL(seq_num, ts->rx_indicate_seq)) {
 		ts->rx_indicate_seq = (ts->rx_indicate_seq + 1) % 4096;
 		match_win_start = true;
-	} else if (SN_LESS(win_end, SeqNum)) {
-		if (SeqNum >= (win_size - 1))
-			ts->rx_indicate_seq = SeqNum + 1 - win_size;
+	} else if (SN_LESS(win_end, seq_num)) {
+		if (seq_num >= (win_size - 1))
+			ts->rx_indicate_seq = seq_num + 1 - win_size;
 		else
 			ts->rx_indicate_seq = 4095 -
-					     (win_size - (SeqNum + 1)) + 1;
+					     (win_size - (seq_num + 1)) + 1;
 		netdev_dbg(ieee->dev,
 			   "Window Shift! IndicateSeq: %d, NewSeq: %d\n",
-			   ts->rx_indicate_seq, SeqNum);
+			   ts->rx_indicate_seq, seq_num);
 	}
 
 	/* Indication process.
 	 * After Packet dropping and Sliding Window shifting as above, we can
-	 * now just indicate the packets with the SeqNum smaller than latest
+	 * now just indicate the packets with the seq_num smaller than latest
 	 * WinStart and struct buffer other packets.
 	 *
 	 * For Rx Reorder condition:
-	 * 1. All packets with SeqNum smaller than WinStart => Indicate
-	 * 2. All packets with SeqNum larger than or equal to
+	 * 1. All packets with seq_num smaller than WinStart => Indicate
+	 * 2. All packets with seq_num larger than or equal to
 	 *	 WinStart => Buffer it.
 	 */
 	if (match_win_start) {
 		/* Current packet is going to be indicated.*/
 		netdev_dbg(ieee->dev,
 			   "Packets indication! IndicateSeq: %d, NewSeq: %d\n",
-			   ts->rx_indicate_seq, SeqNum);
+			   ts->rx_indicate_seq, seq_num);
 		ieee->prxb_indicate_array[0] = prxb;
 		index = 1;
 	} else {
@@ -606,7 +606,7 @@ static void rx_reorder_indicate_packet(struct rtllib_device *ieee,
 			/* Make a reorder entry and insert
 			 * into a the packet list.
 			 */
-			reorder_entry->SeqNum = SeqNum;
+			reorder_entry->seq_num = seq_num;
 			reorder_entry->prxb = prxb;
 
 			if (!add_reorder_entry(ts, reorder_entry)) {
@@ -615,7 +615,7 @@ static void rx_reorder_indicate_packet(struct rtllib_device *ieee,
 				netdev_dbg(ieee->dev,
 					   "%s(): Duplicate packet is dropped. IndicateSeq: %d, NewSeq: %d\n",
 					   __func__, ts->rx_indicate_seq,
-					   SeqNum);
+					   seq_num);
 				list_add_tail(&reorder_entry->list,
 					      &ieee->RxReorder_Unused_List);
 
@@ -626,7 +626,7 @@ static void rx_reorder_indicate_packet(struct rtllib_device *ieee,
 			} else {
 				netdev_dbg(ieee->dev,
 					   "Pkt insert into struct buffer. IndicateSeq: %d, NewSeq: %d\n",
-					   ts->rx_indicate_seq, SeqNum);
+					   ts->rx_indicate_seq, seq_num);
 			}
 		} else {
 			/* Packets are dropped if there are not enough reorder
@@ -657,8 +657,8 @@ static void rx_reorder_indicate_packet(struct rtllib_device *ieee,
 					list_entry(ts->rx_pending_pkt_list.prev,
 						   struct rx_reorder_entry,
 						   list);
-		if (SN_LESS(reorder_entry->SeqNum, ts->rx_indicate_seq) ||
-		    SN_EQUAL(reorder_entry->SeqNum, ts->rx_indicate_seq)) {
+		if (SN_LESS(reorder_entry->seq_num, ts->rx_indicate_seq) ||
+		    SN_EQUAL(reorder_entry->seq_num, ts->rx_indicate_seq)) {
 			/* This protect struct buffer from overflow. */
 			if (index >= REORDER_WIN_SIZE) {
 				netdev_err(ieee->dev,
@@ -670,13 +670,13 @@ static void rx_reorder_indicate_packet(struct rtllib_device *ieee,
 
 			list_del_init(&reorder_entry->list);
 
-			if (SN_EQUAL(reorder_entry->SeqNum, ts->rx_indicate_seq))
+			if (SN_EQUAL(reorder_entry->seq_num, ts->rx_indicate_seq))
 				ts->rx_indicate_seq = (ts->rx_indicate_seq + 1) %
 						     4096;
 
 			ieee->prxb_indicate_array[index] = reorder_entry->prxb;
-			netdev_dbg(ieee->dev, "%s(): Indicate SeqNum %d!\n",
-				   __func__, reorder_entry->SeqNum);
+			netdev_dbg(ieee->dev, "%s(): Indicate seq_num %d!\n",
+				   __func__, reorder_entry->seq_num);
 			index++;
 
 			list_add_tail(&reorder_entry->list,
@@ -731,10 +731,10 @@ static u8 parse_subframe(struct rtllib_device *ieee, struct sk_buff *skb,
 	bool		is_aggregate_frame = false;
 	u16		subframe_len;
 	u8		pad_len = 0;
-	u16		SeqNum = 0;
+	u16		seq_num = 0;
 	struct sk_buff *sub_skb;
 	/* just for debug purpose */
-	SeqNum = WLAN_GET_SEQ_SEQ(le16_to_cpu(hdr->seq_ctrl));
+	seq_num = WLAN_GET_SEQ_SEQ(le16_to_cpu(hdr->seq_ctrl));
 	if ((RTLLIB_QOS_HAS_SEQ(fc)) &&
 	   (((union frameqos *)(skb->data + RTLLIB_3ADDR_LEN))->field.reserved))
 		is_aggregate_frame = true;
@@ -796,8 +796,8 @@ static u8 parse_subframe(struct rtllib_device *ieee, struct sk_buff *skb,
 				    "nRemain_Length is %d and subframe_len is : %d\n",
 				    skb->len, subframe_len);
 			netdev_info(ieee->dev,
-				    "The Packet SeqNum is %d\n",
-				    SeqNum);
+				    "The Packet seq_num is %d\n",
+				    seq_num);
 			return 0;
 		}
 
@@ -1227,7 +1227,7 @@ static int rtllib_rx_infra_adhoc(struct rtllib_device *ieee, struct sk_buff *skb
 	struct lib80211_crypt_data *crypt = NULL;
 	struct rtllib_rxb *rxb = NULL;
 	struct rx_ts_record *ts = NULL;
-	u16 fc, sc, SeqNum = 0;
+	u16 fc, sc, seq_num = 0;
 	u8 type, stype, multicast = 0, unicast = 0, nr_subframes = 0, TID = 0;
 	u8 dst[ETH_ALEN];
 	u8 src[ETH_ALEN];
@@ -1321,7 +1321,7 @@ static int rtllib_rx_infra_adhoc(struct rtllib_device *ieee, struct sk_buff *skb
 	if (ieee->current_network.qos_data.active && is_qos_data_frame(skb->data)
 		&& !is_multicast_ether_addr(hdr->addr1)) {
 		TID = frame_qos_tid(skb->data);
-		SeqNum = WLAN_GET_SEQ_SEQ(sc);
+		seq_num = WLAN_GET_SEQ_SEQ(sc);
 		rtllib_get_ts(ieee, (struct ts_common_info **)&ts, hdr->addr2, TID,
 		      RX_DIR, true);
 		if (TID != 0 && TID != 3)
@@ -1362,7 +1362,7 @@ static int rtllib_rx_infra_adhoc(struct rtllib_device *ieee, struct sk_buff *skb
 	if (!ieee->ht_info->cur_rx_reorder_enable || !ts)
 		rtllib_rx_indicate_pkt_legacy(ieee, rx_stats, rxb, dst, src);
 	else
-		rx_reorder_indicate_packet(ieee, rxb, ts, SeqNum);
+		rx_reorder_indicate_packet(ieee, rxb, ts, seq_num);
 
 	dev_kfree_skb(skb);
 
-- 
2.30.2


^ permalink raw reply	[flat|nested] 18+ messages in thread

* [PATCH 03/16] Staging: rtl8192e: Rename variable SignalStrength
  2024-09-08 19:26 [PATCH 00/16] Staging: rtl8192e: Cleanup even more camelcase variable names Tree Davies
  2024-09-08 19:26 ` [PATCH 01/16] Staging: rtl8192e: Rename variable pReorderEntry Tree Davies
  2024-09-08 19:26 ` [PATCH 02/16] Staging: rtl8192e: Rename variable SeqNum Tree Davies
@ 2024-09-08 19:26 ` Tree Davies
  2024-09-08 19:26 ` [PATCH 04/16] Staging: rtl8192e: Rename variable pFrame Tree Davies
                   ` (13 subsequent siblings)
  16 siblings, 0 replies; 18+ messages in thread
From: Tree Davies @ 2024-09-08 19:26 UTC (permalink / raw)
  To: gregkh, philipp.g.hortmann, anjan
  Cc: linux-staging, linux-kernel, Tree Davies

Rename variable SignalStrength to signal_strength
to fix checkpatch warning Avoid CamelCase.

Signed-off-by: Tree Davies <tdavies@darkphysics.net>
---
 drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 8 ++++----
 drivers/staging/rtl8192e/rtllib.h              | 4 ++--
 drivers/staging/rtl8192e/rtllib_rx.c           | 8 ++++----
 3 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
index f5a46754d65f..a8bb2d3f7e9d 100644
--- a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
+++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
@@ -1319,12 +1319,12 @@ static void _rtl92e_query_rxphystatus(struct r8192_priv *priv,
 	}
 
 	if (is_cck_rate) {
-		pstats->SignalStrength = precord_stats->SignalStrength =
+		pstats->signal_strength = precord_stats->signal_strength =
 					 _rtl92e_signal_scale_mapping(priv, (long)pwdb_all);
 
 	} else {
 		if (rf_rx_num != 0)
-			pstats->SignalStrength = precord_stats->SignalStrength =
+			pstats->signal_strength = precord_stats->signal_strength =
 					 _rtl92e_signal_scale_mapping(priv,
 					 (long)(total_rssi /= rf_rx_num));
 	}
@@ -1352,10 +1352,10 @@ static void _rtl92e_process_phyinfo(struct r8192_priv *priv, u8 *buffer,
 		last_rssi = priv->stats.slide_signal_strength[slide_rssi_index];
 		priv->stats.slide_rssi_total -= last_rssi;
 	}
-	priv->stats.slide_rssi_total += prev_st->SignalStrength;
+	priv->stats.slide_rssi_total += prev_st->signal_strength;
 
 	priv->stats.slide_signal_strength[slide_rssi_index++] =
-					 prev_st->SignalStrength;
+					 prev_st->signal_strength;
 	if (slide_rssi_index >= PHY_RSSI_SLID_WIN_MAX)
 		slide_rssi_index = 0;
 
diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h
index b033e8345b0a..9f812cedd1b3 100644
--- a/drivers/staging/rtl8192e/rtllib.h
+++ b/drivers/staging/rtl8192e/rtllib.h
@@ -466,7 +466,7 @@ struct rtllib_rx_stats {
 	u16 Length;
 	u8  SignalQuality;
 	s32 RecvSignalPower;
-	u8  SignalStrength;
+	u8  signal_strength;
 	u16 hw_error:1;
 	u16 bCRC:1;
 	u16 bICV:1;
@@ -951,7 +951,7 @@ struct rtllib_network {
 	bool unknown_cap_exist;
 	bool	berp_info_valid;
 	bool buseprotection;
-	u8 SignalStrength;
+	u8 signal_strength;
 	u8 RSSI;
 	struct list_head list;
 };
diff --git a/drivers/staging/rtl8192e/rtllib_rx.c b/drivers/staging/rtl8192e/rtllib_rx.c
index 86beac9dd3a5..8fe224a83dd6 100644
--- a/drivers/staging/rtl8192e/rtllib_rx.c
+++ b/drivers/staging/rtl8192e/rtllib_rx.c
@@ -2177,8 +2177,8 @@ static inline int rtllib_network_init(
 	network->marvell_cap_exist = false;
 	network->airgo_cap_exist = false;
 	network->turbo_enable = 0;
-	network->SignalStrength = stats->SignalStrength;
-	network->RSSI = stats->SignalStrength;
+	network->signal_strength = stats->signal_strength;
+	network->RSSI = stats->signal_strength;
 	network->country_ie_len = 0;
 	memset(network->country_ie_buf, 0, MAX_IE_LEN);
 	ht_initialize_bss_desc(&network->bssht);
@@ -2215,7 +2215,7 @@ static inline int rtllib_network_init(
 	}
 	if (rtllib_is_empty_essid(network->ssid, network->ssid_len))
 		network->flags |= NETWORK_EMPTY_ESSID;
-	stats->signal = 30 + (stats->SignalStrength * 70) / 100;
+	stats->signal = 30 + (stats->signal_strength * 70) / 100;
 	stats->noise = rtllib_translate_todbm((u8)(100 - stats->signal)) - 25;
 
 	memcpy(&network->stats, stats, sizeof(network->stats));
@@ -2334,7 +2334,7 @@ static inline void update_network(struct rtllib_device *ieee,
 	   src->wmm_param[3].ac_aci_acm_aifsn)
 		memcpy(dst->wmm_param, src->wmm_param, WME_AC_PRAM_LEN);
 
-	dst->SignalStrength = src->SignalStrength;
+	dst->signal_strength = src->signal_strength;
 	dst->RSSI = src->RSSI;
 	dst->turbo_enable = src->turbo_enable;
 
-- 
2.30.2


^ permalink raw reply	[flat|nested] 18+ messages in thread

* [PATCH 04/16] Staging: rtl8192e: Rename variable pFrame
  2024-09-08 19:26 [PATCH 00/16] Staging: rtl8192e: Cleanup even more camelcase variable names Tree Davies
                   ` (2 preceding siblings ...)
  2024-09-08 19:26 ` [PATCH 03/16] Staging: rtl8192e: Rename variable SignalStrength Tree Davies
@ 2024-09-08 19:26 ` Tree Davies
  2024-09-08 19:26 ` [PATCH 05/16] Staging: rtl8192e: Rename variable bPacketToSelf Tree Davies
                   ` (12 subsequent siblings)
  16 siblings, 0 replies; 18+ messages in thread
From: Tree Davies @ 2024-09-08 19:26 UTC (permalink / raw)
  To: gregkh, philipp.g.hortmann, anjan
  Cc: linux-staging, linux-kernel, Tree Davies

Rename variable pFrame to frame
to fix checkpatch warning Avoid CamelCase.

Signed-off-by: Tree Davies <tdavies@darkphysics.net>
---
 drivers/staging/rtl8192e/rtl819x_HTProc.c | 4 ++--
 drivers/staging/rtl8192e/rtllib.h         | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rtl8192e/rtl819x_HTProc.c
index 188e1fd9554d..9c9c0bc0cfde 100644
--- a/drivers/staging/rtl8192e/rtl819x_HTProc.c
+++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c
@@ -622,10 +622,10 @@ void HT_update_self_and_peer_setting(struct rtllib_device *ieee,
 }
 EXPORT_SYMBOL(HT_update_self_and_peer_setting);
 
-u8 ht_c_check(struct rtllib_device *ieee, u8 *pFrame)
+u8 ht_c_check(struct rtllib_device *ieee, u8 *frame)
 {
 	if (ieee->ht_info->current_ht_support) {
-		if ((is_qos_data_frame(pFrame) && frame_order(pFrame)) == 1) {
+		if ((is_qos_data_frame(frame) && frame_order(frame)) == 1) {
 			netdev_dbg(ieee->dev, "HT CONTROL FILED EXIST!!\n");
 			return true;
 		}
diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h
index 9f812cedd1b3..95e1c81bf132 100644
--- a/drivers/staging/rtl8192e/rtllib.h
+++ b/drivers/staging/rtl8192e/rtllib.h
@@ -1740,7 +1740,7 @@ u8 ht_get_highest_mcs_rate(struct rtllib_device *ieee, u8 *pMCSRateSet,
 		       u8 *pMCSFilter);
 extern u8 MCS_FILTER_ALL[];
 extern u16 MCS_DATA_RATE[2][2][77];
-u8 ht_c_check(struct rtllib_device *ieee, u8 *pFrame);
+u8 ht_c_check(struct rtllib_device *ieee, u8 *frame);
 void ht_reset_iot_setting(struct rt_hi_throughput *ht_info);
 bool is_ht_half_nmode_aps(struct rtllib_device *ieee);
 u16  tx_count_to_data_rate(struct rtllib_device *ieee, u8 nDataRate);
-- 
2.30.2


^ permalink raw reply	[flat|nested] 18+ messages in thread

* [PATCH 05/16] Staging: rtl8192e: Rename variable bPacketToSelf
  2024-09-08 19:26 [PATCH 00/16] Staging: rtl8192e: Cleanup even more camelcase variable names Tree Davies
                   ` (3 preceding siblings ...)
  2024-09-08 19:26 ` [PATCH 04/16] Staging: rtl8192e: Rename variable pFrame Tree Davies
@ 2024-09-08 19:26 ` Tree Davies
  2024-09-08 19:26 ` [PATCH 06/16] Staging: rtl8192e: Rename variable Para1 Tree Davies
                   ` (11 subsequent siblings)
  16 siblings, 0 replies; 18+ messages in thread
From: Tree Davies @ 2024-09-08 19:26 UTC (permalink / raw)
  To: gregkh, philipp.g.hortmann, anjan
  Cc: linux-staging, linux-kernel, Tree Davies

Rename variable bPacketToSelf to packet_to_self
to fix checkpatch warning Avoid CamelCase.

Signed-off-by: Tree Davies <tdavies@darkphysics.net>
---
 drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 10 +++++-----
 drivers/staging/rtl8192e/rtllib.h              |  2 +-
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
index a8bb2d3f7e9d..078e36962197 100644
--- a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
+++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
@@ -1172,7 +1172,7 @@ static void _rtl92e_query_rxphystatus(struct r8192_priv *priv,
 	memset(precord_stats, 0, sizeof(struct rtllib_rx_stats));
 	pstats->bPacketMatchBSSID = precord_stats->bPacketMatchBSSID =
 				    bpacket_match_bssid;
-	pstats->bPacketToSelf = precord_stats->bPacketToSelf = bpacket_toself;
+	pstats->packet_to_self = precord_stats->packet_to_self = bpacket_toself;
 	pstats->bIsCCK = precord_stats->bIsCCK = is_cck_rate;
 	pstats->bPacketBeacon = precord_stats->bPacketBeacon = bPacketBeacon;
 	pstats->bToSelfBA = precord_stats->bToSelfBA = bToSelfBA;
@@ -1370,7 +1370,7 @@ static void _rtl92e_process_phyinfo(struct r8192_priv *priv, u8 *buffer,
 	if (!bcheck)
 		return;
 
-	if (!prev_st->bIsCCK && prev_st->bPacketToSelf) {
+	if (!prev_st->bIsCCK && prev_st->packet_to_self) {
 		for (rfpath = RF90_PATH_A; rfpath < priv->num_total_rf_path; rfpath++) {
 			if (priv->stats.rx_rssi_percentage[rfpath] == 0) {
 				priv->stats.rx_rssi_percentage[rfpath] =
@@ -1416,7 +1416,7 @@ static void _rtl92e_process_phyinfo(struct r8192_priv *priv, u8 *buffer,
 		if (prev_st->RxPWDBAll >= 3)
 			prev_st->RxPWDBAll -= 3;
 	}
-	if (prev_st->bPacketToSelf || prev_st->bPacketBeacon ||
+	if (prev_st->packet_to_self || prev_st->bPacketBeacon ||
 	    prev_st->bToSelfBA) {
 		if (priv->undecorated_smoothed_pwdb < 0)
 			priv->undecorated_smoothed_pwdb = prev_st->RxPWDBAll;
@@ -1437,7 +1437,7 @@ static void _rtl92e_process_phyinfo(struct r8192_priv *priv, u8 *buffer,
 	}
 
 	if (prev_st->SignalQuality != 0) {
-		if (prev_st->bPacketToSelf || prev_st->bPacketBeacon ||
+		if (prev_st->packet_to_self || prev_st->bPacketBeacon ||
 		    prev_st->bToSelfBA) {
 			if (slide_evm_statistics++ >= PHY_RSSI_SLID_WIN_MAX) {
 				slide_evm_statistics = PHY_RSSI_SLID_WIN_MAX;
@@ -1458,7 +1458,7 @@ static void _rtl92e_process_phyinfo(struct r8192_priv *priv, u8 *buffer,
 			priv->stats.last_signal_strength_inpercent = tmp_val;
 		}
 
-		if (prev_st->bPacketToSelf ||
+		if (prev_st->packet_to_self ||
 		    prev_st->bPacketBeacon ||
 		    prev_st->bToSelfBA) {
 			for (ij = 0; ij < 2; ij++) {
diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h
index 95e1c81bf132..f444e85a6264 100644
--- a/drivers/staging/rtl8192e/rtllib.h
+++ b/drivers/staging/rtl8192e/rtllib.h
@@ -484,7 +484,7 @@ struct rtllib_rx_stats {
 	s8    RxMIMOSignalQuality[2];
 	bool  bPacketMatchBSSID;
 	bool  bIsCCK;
-	bool  bPacketToSelf;
+	bool  packet_to_self;
 	bool   bPacketBeacon;
 	bool   bToSelfBA;
 };
-- 
2.30.2


^ permalink raw reply	[flat|nested] 18+ messages in thread

* [PATCH 06/16] Staging: rtl8192e: Rename variable Para1
  2024-09-08 19:26 [PATCH 00/16] Staging: rtl8192e: Cleanup even more camelcase variable names Tree Davies
                   ` (4 preceding siblings ...)
  2024-09-08 19:26 ` [PATCH 05/16] Staging: rtl8192e: Rename variable bPacketToSelf Tree Davies
@ 2024-09-08 19:26 ` Tree Davies
  2024-09-08 19:26 ` [PATCH 07/16] Staging: rtl8192e: Rename variable Para2 Tree Davies
                   ` (10 subsequent siblings)
  16 siblings, 0 replies; 18+ messages in thread
From: Tree Davies @ 2024-09-08 19:26 UTC (permalink / raw)
  To: gregkh, philipp.g.hortmann, anjan
  Cc: linux-staging, linux-kernel, Tree Davies

Rename variable Para1 to para1
to fix checkpatch warning Avoid CamelCase.

Signed-off-by: Tree Davies <tdavies@darkphysics.net>
---
 drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c | 12 ++++++------
 drivers/staging/rtl8192e/rtllib.h              |  2 +-
 2 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c
index 059b1f478a6c..797ae6896d62 100644
--- a/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c
+++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c
@@ -510,7 +510,7 @@ static u8 _rtl92e_phy_set_sw_chnl_cmd_array(struct net_device *dev,
 					    struct sw_chnl_cmd *CmdTable,
 					    u32 CmdTableIdx, u32 CmdTableSz,
 					    enum sw_chnl_cmd_id cmd_id,
-					    u32 Para1, u32 Para2, u32 ms_delay)
+					    u32 para1, u32 Para2, u32 ms_delay)
 {
 	struct sw_chnl_cmd *pCmd;
 
@@ -525,7 +525,7 @@ static u8 _rtl92e_phy_set_sw_chnl_cmd_array(struct net_device *dev,
 
 	pCmd = CmdTable + CmdTableIdx;
 	pCmd->cmd_id = cmd_id;
-	pCmd->Para1 = Para1;
+	pCmd->para1 = para1;
 	pCmd->Para2 = Para2;
 	pCmd->ms_delay = ms_delay;
 
@@ -618,15 +618,15 @@ static u8 _rtl92e_phy_switch_channel_step(struct net_device *dev, u8 channel,
 								   channel);
 				break;
 			case cmd_id_write_port_ulong:
-				rtl92e_writel(dev, CurrentCmd->Para1,
+				rtl92e_writel(dev, CurrentCmd->para1,
 					      CurrentCmd->Para2);
 				break;
 			case cmd_id_write_port_ushort:
-				rtl92e_writew(dev, CurrentCmd->Para1,
+				rtl92e_writew(dev, CurrentCmd->para1,
 					      CurrentCmd->Para2);
 				break;
 			case cmd_id_write_port_uchar:
-				rtl92e_writeb(dev, CurrentCmd->Para1,
+				rtl92e_writeb(dev, CurrentCmd->para1,
 					      CurrentCmd->Para2);
 				break;
 			case cmd_id_rf_write_reg:
@@ -634,7 +634,7 @@ static u8 _rtl92e_phy_switch_channel_step(struct net_device *dev, u8 channel,
 				     priv->num_total_rf_path; eRFPath++)
 					rtl92e_set_rf_reg(dev,
 						 (enum rf90_radio_path)eRFPath,
-						 CurrentCmd->Para1, bMask12Bits,
+						 CurrentCmd->para1, bMask12Bits,
 						 CurrentCmd->Para2 << 7);
 				break;
 			default:
diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h
index f444e85a6264..1e119192ad38 100644
--- a/drivers/staging/rtl8192e/rtllib.h
+++ b/drivers/staging/rtl8192e/rtllib.h
@@ -164,7 +164,7 @@ enum sw_chnl_cmd_id {
 
 struct sw_chnl_cmd {
 	enum sw_chnl_cmd_id cmd_id;
-	u32			Para1;
+	u32			para1;
 	u32			Para2;
 	u32			ms_delay;
 };
-- 
2.30.2


^ permalink raw reply	[flat|nested] 18+ messages in thread

* [PATCH 07/16] Staging: rtl8192e: Rename variable Para2
  2024-09-08 19:26 [PATCH 00/16] Staging: rtl8192e: Cleanup even more camelcase variable names Tree Davies
                   ` (5 preceding siblings ...)
  2024-09-08 19:26 ` [PATCH 06/16] Staging: rtl8192e: Rename variable Para1 Tree Davies
@ 2024-09-08 19:26 ` Tree Davies
  2024-09-08 19:26 ` [PATCH 08/16] Staging: rtl8192e: Rename variable ScanOperationBackupHandler Tree Davies
                   ` (9 subsequent siblings)
  16 siblings, 0 replies; 18+ messages in thread
From: Tree Davies @ 2024-09-08 19:26 UTC (permalink / raw)
  To: gregkh, philipp.g.hortmann, anjan
  Cc: linux-staging, linux-kernel, Tree Davies

Rename variable Para2 to para2
to fix checkpatch warning Avoid CamelCase.

Signed-off-by: Tree Davies <tdavies@darkphysics.net>
---
 drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c | 12 ++++++------
 drivers/staging/rtl8192e/rtllib.h              |  2 +-
 2 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c
index 797ae6896d62..fbe624e235df 100644
--- a/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c
+++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c
@@ -510,7 +510,7 @@ static u8 _rtl92e_phy_set_sw_chnl_cmd_array(struct net_device *dev,
 					    struct sw_chnl_cmd *CmdTable,
 					    u32 CmdTableIdx, u32 CmdTableSz,
 					    enum sw_chnl_cmd_id cmd_id,
-					    u32 para1, u32 Para2, u32 ms_delay)
+					    u32 para1, u32 para2, u32 ms_delay)
 {
 	struct sw_chnl_cmd *pCmd;
 
@@ -526,7 +526,7 @@ static u8 _rtl92e_phy_set_sw_chnl_cmd_array(struct net_device *dev,
 	pCmd = CmdTable + CmdTableIdx;
 	pCmd->cmd_id = cmd_id;
 	pCmd->para1 = para1;
-	pCmd->Para2 = Para2;
+	pCmd->para2 = para2;
 	pCmd->ms_delay = ms_delay;
 
 	return true;
@@ -619,15 +619,15 @@ static u8 _rtl92e_phy_switch_channel_step(struct net_device *dev, u8 channel,
 				break;
 			case cmd_id_write_port_ulong:
 				rtl92e_writel(dev, CurrentCmd->para1,
-					      CurrentCmd->Para2);
+					      CurrentCmd->para2);
 				break;
 			case cmd_id_write_port_ushort:
 				rtl92e_writew(dev, CurrentCmd->para1,
-					      CurrentCmd->Para2);
+					      CurrentCmd->para2);
 				break;
 			case cmd_id_write_port_uchar:
 				rtl92e_writeb(dev, CurrentCmd->para1,
-					      CurrentCmd->Para2);
+					      CurrentCmd->para2);
 				break;
 			case cmd_id_rf_write_reg:
 				for (eRFPath = 0; eRFPath <
@@ -635,7 +635,7 @@ static u8 _rtl92e_phy_switch_channel_step(struct net_device *dev, u8 channel,
 					rtl92e_set_rf_reg(dev,
 						 (enum rf90_radio_path)eRFPath,
 						 CurrentCmd->para1, bMask12Bits,
-						 CurrentCmd->Para2 << 7);
+						 CurrentCmd->para2 << 7);
 				break;
 			default:
 				break;
diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h
index 1e119192ad38..d63044607fb5 100644
--- a/drivers/staging/rtl8192e/rtllib.h
+++ b/drivers/staging/rtl8192e/rtllib.h
@@ -165,7 +165,7 @@ enum sw_chnl_cmd_id {
 struct sw_chnl_cmd {
 	enum sw_chnl_cmd_id cmd_id;
 	u32			para1;
-	u32			Para2;
+	u32			para2;
 	u32			ms_delay;
 };
 
-- 
2.30.2


^ permalink raw reply	[flat|nested] 18+ messages in thread

* [PATCH 08/16] Staging: rtl8192e: Rename variable ScanOperationBackupHandler
  2024-09-08 19:26 [PATCH 00/16] Staging: rtl8192e: Cleanup even more camelcase variable names Tree Davies
                   ` (6 preceding siblings ...)
  2024-09-08 19:26 ` [PATCH 07/16] Staging: rtl8192e: Rename variable Para2 Tree Davies
@ 2024-09-08 19:26 ` Tree Davies
  2024-09-08 19:26 ` [PATCH 09/16] Staging: rtl8192e: Rename variable Operation Tree Davies
                   ` (8 subsequent siblings)
  16 siblings, 0 replies; 18+ messages in thread
From: Tree Davies @ 2024-09-08 19:26 UTC (permalink / raw)
  To: gregkh, philipp.g.hortmann, anjan
  Cc: linux-staging, linux-kernel, Tree Davies

Rename variable ScanOperationBackupHandler to
scan_operation_backup_handler to fix checkpatch warning
Avoid CamelCase.

Signed-off-by: Tree Davies <tdavies@darkphysics.net>
---
 drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 2 +-
 drivers/staging/rtl8192e/rtl8192e/rtl_wx.c   | 4 ++--
 drivers/staging/rtl8192e/rtllib.h            | 2 +-
 drivers/staging/rtl8192e/rtllib_softmac_wx.c | 4 ++--
 4 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c
index 744588a27302..a5980253183e 100644
--- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c
+++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c
@@ -665,7 +665,7 @@ static void _rtl92e_init_priv_handler(struct net_device *dev)
 	priv->rtllib->init_gain_handler = rtl92e_init_gain;
 	priv->rtllib->rtllib_ips_leave_wq = rtl92e_rtllib_ips_leave_wq;
 	priv->rtllib->rtllib_ips_leave = rtl92e_rtllib_ips_leave;
-	priv->rtllib->ScanOperationBackupHandler = rtl92e_scan_op_backup;
+	priv->rtllib->scan_operation_backup_handler = rtl92e_scan_op_backup;
 }
 
 static void _rtl92e_init_priv_variable(struct net_device *dev)
diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c b/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c
index a054592a7364..fe3a42a4fcd5 100644
--- a/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c
+++ b/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c
@@ -288,11 +288,11 @@ static int _rtl92e_wx_set_scan(struct net_device *dev,
 		if (priv->rtllib->rf_power_state != rf_off) {
 			priv->rtllib->actscanning = true;
 
-			ieee->ScanOperationBackupHandler(ieee->dev, SCAN_OPT_BACKUP);
+			ieee->scan_operation_backup_handler(ieee->dev, SCAN_OPT_BACKUP);
 
 			rtllib_start_scan_syncro(priv->rtllib);
 
-			ieee->ScanOperationBackupHandler(ieee->dev, SCAN_OPT_RESTORE);
+			ieee->scan_operation_backup_handler(ieee->dev, SCAN_OPT_RESTORE);
 		}
 		ret = 0;
 	} else {
diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h
index d63044607fb5..ee5de93a90c1 100644
--- a/drivers/staging/rtl8192e/rtllib.h
+++ b/drivers/staging/rtl8192e/rtllib.h
@@ -1461,7 +1461,7 @@ struct rtllib_device {
 	bool (*get_half_nmode_support_by_aps_handler)(struct net_device *dev);
 	u8   (*rtllib_ap_sec_type)(struct rtllib_device *ieee);
 	void (*init_gain_handler)(struct net_device *dev, u8 Operation);
-	void (*ScanOperationBackupHandler)(struct net_device *dev,
+	void (*scan_operation_backup_handler)(struct net_device *dev,
 					   u8 Operation);
 	void (*set_hw_reg_handler)(struct net_device *dev, u8 variable, u8 *val);
 
diff --git a/drivers/staging/rtl8192e/rtllib_softmac_wx.c b/drivers/staging/rtl8192e/rtllib_softmac_wx.c
index 11542aea4a20..c59686d68a33 100644
--- a/drivers/staging/rtl8192e/rtllib_softmac_wx.c
+++ b/drivers/staging/rtl8192e/rtllib_softmac_wx.c
@@ -314,7 +314,7 @@ void rtllib_wx_sync_scan_wq(void *data)
 	/* wait for ps packet to be kicked out successfully */
 	msleep(50);
 
-	ieee->ScanOperationBackupHandler(ieee->dev, SCAN_OPT_BACKUP);
+	ieee->scan_operation_backup_handler(ieee->dev, SCAN_OPT_BACKUP);
 
 	if (ieee->ht_info->current_ht_support && ieee->ht_info->enable_ht &&
 	    ieee->ht_info->cur_bw_40mhz) {
@@ -339,7 +339,7 @@ void rtllib_wx_sync_scan_wq(void *data)
 		ieee->set_chan(ieee->dev, chan);
 	}
 
-	ieee->ScanOperationBackupHandler(ieee->dev, SCAN_OPT_RESTORE);
+	ieee->scan_operation_backup_handler(ieee->dev, SCAN_OPT_RESTORE);
 
 	ieee->link_state = MAC80211_LINKED;
 	ieee->link_change(ieee->dev);
-- 
2.30.2


^ permalink raw reply	[flat|nested] 18+ messages in thread

* [PATCH 09/16] Staging: rtl8192e: Rename variable Operation
  2024-09-08 19:26 [PATCH 00/16] Staging: rtl8192e: Cleanup even more camelcase variable names Tree Davies
                   ` (7 preceding siblings ...)
  2024-09-08 19:26 ` [PATCH 08/16] Staging: rtl8192e: Rename variable ScanOperationBackupHandler Tree Davies
@ 2024-09-08 19:26 ` Tree Davies
  2024-09-08 19:26 ` [PATCH 10/16] Staging: rtl8192e: Rename variable bAssoc Tree Davies
                   ` (7 subsequent siblings)
  16 siblings, 0 replies; 18+ messages in thread
From: Tree Davies @ 2024-09-08 19:26 UTC (permalink / raw)
  To: gregkh, philipp.g.hortmann, anjan
  Cc: linux-staging, linux-kernel, Tree Davies

Rename variable Operation to operation
to fix checkpatch warning Avoid CamelCase.

Signed-off-by: Tree Davies <tdavies@darkphysics.net>
---
 drivers/staging/rtl8192e/rtl8192e/r8192E_phy.h | 4 ++--
 drivers/staging/rtl8192e/rtllib.h              | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.h b/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.h
index c928bc2b218b..956dfbdd5b68 100644
--- a/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.h
+++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.h
@@ -43,13 +43,13 @@ void rtl92e_set_channel(struct net_device *dev, u8 channel);
 void rtl92e_set_bw_mode(struct net_device *dev,
 			enum ht_channel_width bandwidth,
 			enum ht_extchnl_offset Offset);
-void rtl92e_init_gain(struct net_device *dev, u8 Operation);
+void rtl92e_init_gain(struct net_device *dev, u8 operation);
 
 void rtl92e_set_rf_off(struct net_device *dev);
 
 bool rtl92e_set_rf_power_state(struct net_device *dev,
 			       enum rt_rf_power_state rf_power_state);
 
-void rtl92e_scan_op_backup(struct net_device *dev, u8 Operation);
+void rtl92e_scan_op_backup(struct net_device *dev, u8 operation);
 
 #endif
diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h
index ee5de93a90c1..3621f27b083b 100644
--- a/drivers/staging/rtl8192e/rtllib.h
+++ b/drivers/staging/rtl8192e/rtllib.h
@@ -1460,9 +1460,9 @@ struct rtllib_device {
 	void (*set_wireless_mode)(struct net_device *dev, u8 wireless_mode);
 	bool (*get_half_nmode_support_by_aps_handler)(struct net_device *dev);
 	u8   (*rtllib_ap_sec_type)(struct rtllib_device *ieee);
-	void (*init_gain_handler)(struct net_device *dev, u8 Operation);
+	void (*init_gain_handler)(struct net_device *dev, u8 operation);
 	void (*scan_operation_backup_handler)(struct net_device *dev,
-					   u8 Operation);
+					   u8 operation);
 	void (*set_hw_reg_handler)(struct net_device *dev, u8 variable, u8 *val);
 
 	void (*allow_all_dest_addr_handler)(struct net_device *dev,
-- 
2.30.2


^ permalink raw reply	[flat|nested] 18+ messages in thread

* [PATCH 10/16] Staging: rtl8192e: Rename variable bAssoc
  2024-09-08 19:26 [PATCH 00/16] Staging: rtl8192e: Cleanup even more camelcase variable names Tree Davies
                   ` (8 preceding siblings ...)
  2024-09-08 19:26 ` [PATCH 09/16] Staging: rtl8192e: Rename variable Operation Tree Davies
@ 2024-09-08 19:26 ` Tree Davies
  2024-09-08 19:26 ` [PATCH 11/16] Staging: rtl8192e: Rename variable SignalQuality Tree Davies
                   ` (6 subsequent siblings)
  16 siblings, 0 replies; 18+ messages in thread
From: Tree Davies @ 2024-09-08 19:26 UTC (permalink / raw)
  To: gregkh, philipp.g.hortmann, anjan
  Cc: linux-staging, linux-kernel, Tree Davies

Rename variable bAssoc to assoc
to fix checkpatch warning Avoid CamelCase.

Signed-off-by: Tree Davies <tdavies@darkphysics.net>
---
 drivers/staging/rtl8192e/rtllib.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h
index 3621f27b083b..b599309b70ff 100644
--- a/drivers/staging/rtl8192e/rtllib.h
+++ b/drivers/staging/rtl8192e/rtllib.h
@@ -1726,7 +1726,7 @@ void ht_set_connect_bw_mode(struct rtllib_device *ieee,
 void ht_update_default_setting(struct rtllib_device *ieee);
 void ht_construct_capability_element(struct rtllib_device *ieee,
 				  u8 *pos_ht_cap, u8 *len,
-				  u8 isEncrypt, bool bAssoc);
+				  u8 isEncrypt, bool assoc);
 void ht_construct_rt2rt_agg_element(struct rtllib_device *ieee,
 				u8 *posRT2RTAgg, u8 *len);
 void ht_on_assoc_rsp(struct rtllib_device *ieee);
-- 
2.30.2


^ permalink raw reply	[flat|nested] 18+ messages in thread

* [PATCH 11/16] Staging: rtl8192e: Rename variable SignalQuality
  2024-09-08 19:26 [PATCH 00/16] Staging: rtl8192e: Cleanup even more camelcase variable names Tree Davies
                   ` (9 preceding siblings ...)
  2024-09-08 19:26 ` [PATCH 10/16] Staging: rtl8192e: Rename variable bAssoc Tree Davies
@ 2024-09-08 19:26 ` Tree Davies
  2024-09-08 19:26 ` [PATCH 12/16] Staging: rtl8192e: Rename variable isEncrypt Tree Davies
                   ` (5 subsequent siblings)
  16 siblings, 0 replies; 18+ messages in thread
From: Tree Davies @ 2024-09-08 19:26 UTC (permalink / raw)
  To: gregkh, philipp.g.hortmann, anjan
  Cc: linux-staging, linux-kernel, Tree Davies

Rename variable SignalQuality to signal_quality
to fix checkpatch warning Avoid CamelCase.

Signed-off-by: Tree Davies <tdavies@darkphysics.net>
---
 drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 14 +++++++-------
 drivers/staging/rtl8192e/rtllib.h              |  2 +-
 2 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
index 078e36962197..eab6bbf9f3bf 100644
--- a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
+++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
@@ -1264,8 +1264,8 @@ static void _rtl92e_query_rxphystatus(struct r8192_priv *priv,
 				else
 					sq = ((64 - sq) * 100) / 44;
 			}
-			pstats->SignalQuality = sq;
-			precord_stats->SignalQuality = sq;
+			pstats->signal_quality = sq;
+			precord_stats->signal_quality = sq;
 			pstats->RxMIMOSignalQuality[0] = sq;
 			precord_stats->RxMIMOSignalQuality[0] = sq;
 			pstats->RxMIMOSignalQuality[1] = -1;
@@ -1309,8 +1309,8 @@ static void _rtl92e_query_rxphystatus(struct r8192_priv *priv,
 			evm = rtl92e_evm_db_to_percent(rx_evmX);
 			if (bpacket_match_bssid) {
 				if (i == 0) {
-					pstats->SignalQuality = evm & 0xff;
-					precord_stats->SignalQuality = evm & 0xff;
+					pstats->signal_quality = evm & 0xff;
+					precord_stats->signal_quality = evm & 0xff;
 				}
 				pstats->RxMIMOSignalQuality[i] = evm & 0xff;
 				precord_stats->RxMIMOSignalQuality[i] = evm & 0xff;
@@ -1436,7 +1436,7 @@ static void _rtl92e_process_phyinfo(struct r8192_priv *priv, u8 *buffer,
 		rtl92e_update_rx_statistics(priv, prev_st);
 	}
 
-	if (prev_st->SignalQuality != 0) {
+	if (prev_st->signal_quality != 0) {
 		if (prev_st->packet_to_self || prev_st->bPacketBeacon ||
 		    prev_st->bToSelfBA) {
 			if (slide_evm_statistics++ >= PHY_RSSI_SLID_WIN_MAX) {
@@ -1446,10 +1446,10 @@ static void _rtl92e_process_phyinfo(struct r8192_priv *priv, u8 *buffer,
 				priv->stats.slide_evm_total -= last_evm;
 			}
 
-			priv->stats.slide_evm_total += prev_st->SignalQuality;
+			priv->stats.slide_evm_total += prev_st->signal_quality;
 
 			priv->stats.slide_evm[slide_evm_index++] =
-						 prev_st->SignalQuality;
+						 prev_st->signal_quality;
 			if (slide_evm_index >= PHY_RSSI_SLID_WIN_MAX)
 				slide_evm_index = 0;
 
diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h
index b599309b70ff..76792268629d 100644
--- a/drivers/staging/rtl8192e/rtllib.h
+++ b/drivers/staging/rtl8192e/rtllib.h
@@ -464,7 +464,7 @@ struct rtllib_rx_stats {
 	u8  mask;
 	u16 len;
 	u16 Length;
-	u8  SignalQuality;
+	u8  signal_quality;
 	s32 RecvSignalPower;
 	u8  signal_strength;
 	u16 hw_error:1;
-- 
2.30.2


^ permalink raw reply	[flat|nested] 18+ messages in thread

* [PATCH 12/16] Staging: rtl8192e: Rename variable isEncrypt
  2024-09-08 19:26 [PATCH 00/16] Staging: rtl8192e: Cleanup even more camelcase variable names Tree Davies
                   ` (10 preceding siblings ...)
  2024-09-08 19:26 ` [PATCH 11/16] Staging: rtl8192e: Rename variable SignalQuality Tree Davies
@ 2024-09-08 19:26 ` Tree Davies
  2024-09-08 19:26 ` [PATCH 13/16] Staging: rtl8192e: Rename variable nStuckCount Tree Davies
                   ` (4 subsequent siblings)
  16 siblings, 0 replies; 18+ messages in thread
From: Tree Davies @ 2024-09-08 19:26 UTC (permalink / raw)
  To: gregkh, philipp.g.hortmann, anjan
  Cc: linux-staging, linux-kernel, Tree Davies

Rename variable isEncrypt to is_encrypt
to fix checkpatch warning Avoid CamelCase.

Signed-off-by: Tree Davies <tdavies@darkphysics.net>
---
 drivers/staging/rtl8192e/rtllib.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h
index 76792268629d..5ff3fab72589 100644
--- a/drivers/staging/rtl8192e/rtllib.h
+++ b/drivers/staging/rtl8192e/rtllib.h
@@ -1726,7 +1726,7 @@ void ht_set_connect_bw_mode(struct rtllib_device *ieee,
 void ht_update_default_setting(struct rtllib_device *ieee);
 void ht_construct_capability_element(struct rtllib_device *ieee,
 				  u8 *pos_ht_cap, u8 *len,
-				  u8 isEncrypt, bool assoc);
+				  u8 is_encrypt, bool assoc);
 void ht_construct_rt2rt_agg_element(struct rtllib_device *ieee,
 				u8 *posRT2RTAgg, u8 *len);
 void ht_on_assoc_rsp(struct rtllib_device *ieee);
-- 
2.30.2


^ permalink raw reply	[flat|nested] 18+ messages in thread

* [PATCH 13/16] Staging: rtl8192e: Rename variable nStuckCount
  2024-09-08 19:26 [PATCH 00/16] Staging: rtl8192e: Cleanup even more camelcase variable names Tree Davies
                   ` (11 preceding siblings ...)
  2024-09-08 19:26 ` [PATCH 12/16] Staging: rtl8192e: Rename variable isEncrypt Tree Davies
@ 2024-09-08 19:26 ` Tree Davies
  2024-09-08 19:26 ` [PATCH 14/16] Staging: rtl8192e: Rename variable bAddNewTs Tree Davies
                   ` (3 subsequent siblings)
  16 siblings, 0 replies; 18+ messages in thread
From: Tree Davies @ 2024-09-08 19:26 UTC (permalink / raw)
  To: gregkh, philipp.g.hortmann, anjan
  Cc: linux-staging, linux-kernel, Tree Davies

Rename variable nStuckCount to stuck_count
to fix checkpatch warning Avoid CamelCase.

Signed-off-by: Tree Davies <tdavies@darkphysics.net>
---
 drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 8 ++++----
 drivers/staging/rtl8192e/rtllib.h            | 2 +-
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c
index a5980253183e..5a4113c97b1c 100644
--- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c
+++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c
@@ -860,13 +860,13 @@ static enum reset_type _rtl92e_tx_check_stuck(struct net_device *dev)
 			skb = __skb_peek(&ring->queue);
 			tcb_desc = (struct cb_desc *)(skb->cb +
 				    MAX_DEV_ADDR_SIZE);
-			tcb_desc->nStuckCount++;
+			tcb_desc->stuck_count++;
 			bCheckFwTxCnt = true;
-			if (tcb_desc->nStuckCount > 1)
+			if (tcb_desc->stuck_count > 1)
 				netdev_info(dev,
-					    "%s: QueueID=%d tcb_desc->nStuckCount=%d\n",
+					    "%s: QueueID=%d tcb_desc->stuck_count=%d\n",
 					    __func__, QueueID,
-					    tcb_desc->nStuckCount);
+					    tcb_desc->stuck_count);
 		}
 	}
 	spin_unlock_irqrestore(&priv->irq_th_lock, flags);
diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h
index 5ff3fab72589..540ab4e34e70 100644
--- a/drivers/staging/rtl8192e/rtllib.h
+++ b/drivers/staging/rtl8192e/rtllib.h
@@ -107,7 +107,7 @@ struct cb_desc {
 	u8 tx_use_drv_assinged_rate:1;
 	u8 hw_sec:1;
 
-	u8 nStuckCount;
+	u8 stuck_count;
 
 	/* Tx Firmware Related flags (10-11)*/
 	u8 cts_enable:1;
-- 
2.30.2


^ permalink raw reply	[flat|nested] 18+ messages in thread

* [PATCH 14/16] Staging: rtl8192e: Rename variable bAddNewTs
  2024-09-08 19:26 [PATCH 00/16] Staging: rtl8192e: Cleanup even more camelcase variable names Tree Davies
                   ` (12 preceding siblings ...)
  2024-09-08 19:26 ` [PATCH 13/16] Staging: rtl8192e: Rename variable nStuckCount Tree Davies
@ 2024-09-08 19:26 ` Tree Davies
  2024-09-08 19:26 ` [PATCH 15/16] Staging: rtl8192e: Rename variable RxBufShift Tree Davies
                   ` (2 subsequent siblings)
  16 siblings, 0 replies; 18+ messages in thread
From: Tree Davies @ 2024-09-08 19:26 UTC (permalink / raw)
  To: gregkh, philipp.g.hortmann, anjan
  Cc: linux-staging, linux-kernel, Tree Davies

Rename variable bAddNewTs to add_new_ts
to fix checkpatch warning Avoid CamelCase.

Signed-off-by: Tree Davies <tdavies@darkphysics.net>
---
 drivers/staging/rtl8192e/rtl819x_TSProc.c | 4 ++--
 drivers/staging/rtl8192e/rtllib.h         | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/rtl8192e/rtl819x_TSProc.c b/drivers/staging/rtl8192e/rtl819x_TSProc.c
index 18b717a7409c..89092cd434de 100644
--- a/drivers/staging/rtl8192e/rtl819x_TSProc.c
+++ b/drivers/staging/rtl8192e/rtl819x_TSProc.c
@@ -225,7 +225,7 @@ static void MakeTSEntry(struct ts_common_info *ts_common_info, u8 *addr,
 }
 
 bool rtllib_get_ts(struct rtllib_device *ieee, struct ts_common_info **ppTS,
-	   u8 *addr, u8 TID, enum tr_select tx_rx_select, bool bAddNewTs)
+	   u8 *addr, u8 TID, enum tr_select tx_rx_select, bool add_new_ts)
 {
 	u8	UP = 0;
 	struct qos_tsinfo tspec;
@@ -269,7 +269,7 @@ bool rtllib_get_ts(struct rtllib_device *ieee, struct ts_common_info **ppTS,
 	if (*ppTS)
 		return true;
 
-	if (!bAddNewTs) {
+	if (!add_new_ts) {
 		netdev_dbg(ieee->dev, "add new TS failed(tid:%d)\n", UP);
 		return false;
 	}
diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h
index 540ab4e34e70..d8155ea3a002 100644
--- a/drivers/staging/rtl8192e/rtllib.h
+++ b/drivers/staging/rtl8192e/rtllib.h
@@ -1757,7 +1757,7 @@ void rtllib_tx_ba_inact_timeout(struct timer_list *t);
 void rtllib_rx_ba_inact_timeout(struct timer_list *t);
 void rtllib_reset_ba_entry(struct ba_record *ba);
 bool rtllib_get_ts(struct rtllib_device *ieee, struct ts_common_info **ppTS, u8 *addr,
-	   u8 TID, enum tr_select tx_rx_select, bool bAddNewTs);
+	   u8 TID, enum tr_select tx_rx_select, bool add_new_ts);
 void rtllib_ts_init(struct rtllib_device *ieee);
 void rtllib_ts_start_add_ba_process(struct rtllib_device *ieee,
 			 struct tx_ts_record *pTxTS);
-- 
2.30.2


^ permalink raw reply	[flat|nested] 18+ messages in thread

* [PATCH 15/16] Staging: rtl8192e: Rename variable RxBufShift
  2024-09-08 19:26 [PATCH 00/16] Staging: rtl8192e: Cleanup even more camelcase variable names Tree Davies
                   ` (13 preceding siblings ...)
  2024-09-08 19:26 ` [PATCH 14/16] Staging: rtl8192e: Rename variable bAddNewTs Tree Davies
@ 2024-09-08 19:26 ` Tree Davies
  2024-09-08 19:26 ` [PATCH 16/16] Staging: rtl8192e: Rename variable RxDrvInfoSize Tree Davies
  2024-09-08 20:44 ` [PATCH 00/16] Staging: rtl8192e: Cleanup even more camelcase variable names Philipp Hortmann
  16 siblings, 0 replies; 18+ messages in thread
From: Tree Davies @ 2024-09-08 19:26 UTC (permalink / raw)
  To: gregkh, philipp.g.hortmann, anjan
  Cc: linux-staging, linux-kernel, Tree Davies

Rename variable RxBufShift to rx_buf_shift
to fix checkpatch warning Avoid CamelCase.

Signed-off-by: Tree Davies <tdavies@darkphysics.net>
---
 drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 6 +++---
 drivers/staging/rtl8192e/rtl8192e/rtl_core.c   | 2 +-
 drivers/staging/rtl8192e/rtllib.h              | 2 +-
 3 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
index eab6bbf9f3bf..d25ac5adfc49 100644
--- a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
+++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
@@ -1493,7 +1493,7 @@ static void _rtl92e_translate_rx_signal_stats(struct net_device *dev,
 	u8 *tmp_buf;
 	u8 *praddr;
 
-	tmp_buf = skb->data + pstats->RxDrvInfoSize + pstats->RxBufShift;
+	tmp_buf = skb->data + pstats->RxDrvInfoSize + pstats->rx_buf_shift;
 
 	hdr = (struct ieee80211_hdr_3addr *)tmp_buf;
 	fc = le16_to_cpu(hdr->frame_control);
@@ -1640,10 +1640,10 @@ bool rtl92e_get_rx_stats(struct net_device *dev, struct rtllib_rx_stats *stats,
 		return false;
 
 	stats->RxDrvInfoSize = pdesc->RxDrvInfoSize;
-	stats->RxBufShift = (pdesc->Shift) & 0x03;
+	stats->rx_buf_shift = (pdesc->Shift) & 0x03;
 	stats->decrypted = !pdesc->SWDec;
 
-	pDrvInfo = (struct rx_fwinfo *)(skb->data + stats->RxBufShift);
+	pDrvInfo = (struct rx_fwinfo *)(skb->data + stats->rx_buf_shift);
 
 	stats->rate = _rtl92e_rate_hw_to_mgn((bool)pDrvInfo->RxHT,
 					     pDrvInfo->RxRate);
diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c
index 5a4113c97b1c..d43841a9b21b 100644
--- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c
+++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c
@@ -1523,7 +1523,7 @@ static void _rtl92e_rx_normal(struct net_device *dev)
 
 		skb_put(skb, pdesc->Length);
 		skb_reserve(skb, stats.RxDrvInfoSize +
-			stats.RxBufShift);
+			stats.rx_buf_shift);
 		skb_trim(skb, skb->len - S_CRC_LEN);
 		rtllib_hdr = (struct ieee80211_hdr *)skb->data;
 		if (!is_multicast_ether_addr(rtllib_hdr->addr1)) {
diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h
index d8155ea3a002..6cd374a9a955 100644
--- a/drivers/staging/rtl8192e/rtllib.h
+++ b/drivers/staging/rtl8192e/rtllib.h
@@ -475,7 +475,7 @@ struct rtllib_rx_stats {
 	u32 time_stamp_high;
 
 	u8    RxDrvInfoSize;
-	u8    RxBufShift;
+	u8    rx_buf_shift;
 	bool  bIsAMPDU;
 	bool  bFirstMPDU;
 	bool  contain_htc;
-- 
2.30.2


^ permalink raw reply	[flat|nested] 18+ messages in thread

* [PATCH 16/16] Staging: rtl8192e: Rename variable RxDrvInfoSize
  2024-09-08 19:26 [PATCH 00/16] Staging: rtl8192e: Cleanup even more camelcase variable names Tree Davies
                   ` (14 preceding siblings ...)
  2024-09-08 19:26 ` [PATCH 15/16] Staging: rtl8192e: Rename variable RxBufShift Tree Davies
@ 2024-09-08 19:26 ` Tree Davies
  2024-09-08 20:44 ` [PATCH 00/16] Staging: rtl8192e: Cleanup even more camelcase variable names Philipp Hortmann
  16 siblings, 0 replies; 18+ messages in thread
From: Tree Davies @ 2024-09-08 19:26 UTC (permalink / raw)
  To: gregkh, philipp.g.hortmann, anjan
  Cc: linux-staging, linux-kernel, Tree Davies

Rename variable RxDrvInfoSize to rx_drv_info_size
to fix checkpatch warning Avoid CamelCase.

Signed-off-by: Tree Davies <tdavies@darkphysics.net>
---
 drivers/staging/rtl8192e/rtl8192e/r8190P_def.h | 2 +-
 drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 4 ++--
 drivers/staging/rtl8192e/rtl8192e/rtl_core.c   | 2 +-
 drivers/staging/rtl8192e/rtllib.h              | 2 +-
 4 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/staging/rtl8192e/rtl8192e/r8190P_def.h b/drivers/staging/rtl8192e/rtl8192e/r8190P_def.h
index de0cd40df25f..552fd9b6e3e5 100644
--- a/drivers/staging/rtl8192e/rtl8192e/r8190P_def.h
+++ b/drivers/staging/rtl8192e/rtl8192e/r8190P_def.h
@@ -227,7 +227,7 @@ struct rx_desc {
 	u16			Length:14;
 	u16			CRC32:1;
 	u16			ICV:1;
-	u8			RxDrvInfoSize;
+	u8			rx_drv_info_size;
 	u8			Shift:2;
 	u8			PHYStatus:1;
 	u8			SWDec:1;
diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
index d25ac5adfc49..2672b1ddf88e 100644
--- a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
+++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
@@ -1493,7 +1493,7 @@ static void _rtl92e_translate_rx_signal_stats(struct net_device *dev,
 	u8 *tmp_buf;
 	u8 *praddr;
 
-	tmp_buf = skb->data + pstats->RxDrvInfoSize + pstats->rx_buf_shift;
+	tmp_buf = skb->data + pstats->rx_drv_info_size + pstats->rx_buf_shift;
 
 	hdr = (struct ieee80211_hdr_3addr *)tmp_buf;
 	fc = le16_to_cpu(hdr->frame_control);
@@ -1639,7 +1639,7 @@ bool rtl92e_get_rx_stats(struct net_device *dev, struct rtllib_rx_stats *stats,
 	if (stats->hw_error)
 		return false;
 
-	stats->RxDrvInfoSize = pdesc->RxDrvInfoSize;
+	stats->rx_drv_info_size = pdesc->rx_drv_info_size;
 	stats->rx_buf_shift = (pdesc->Shift) & 0x03;
 	stats->decrypted = !pdesc->SWDec;
 
diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c
index d43841a9b21b..dc1301f1a0c1 100644
--- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c
+++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c
@@ -1522,7 +1522,7 @@ static void _rtl92e_rx_normal(struct net_device *dev)
 				 priv->rxbuffersize, DMA_FROM_DEVICE);
 
 		skb_put(skb, pdesc->Length);
-		skb_reserve(skb, stats.RxDrvInfoSize +
+		skb_reserve(skb, stats.rx_drv_info_size +
 			stats.rx_buf_shift);
 		skb_trim(skb, skb->len - S_CRC_LEN);
 		rtllib_hdr = (struct ieee80211_hdr *)skb->data;
diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h
index 6cd374a9a955..d6615f787d53 100644
--- a/drivers/staging/rtl8192e/rtllib.h
+++ b/drivers/staging/rtl8192e/rtllib.h
@@ -474,7 +474,7 @@ struct rtllib_rx_stats {
 	u32 time_stamp_low;
 	u32 time_stamp_high;
 
-	u8    RxDrvInfoSize;
+	u8    rx_drv_info_size;
 	u8    rx_buf_shift;
 	bool  bIsAMPDU;
 	bool  bFirstMPDU;
-- 
2.30.2


^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PATCH 00/16] Staging: rtl8192e: Cleanup even more camelcase variable names
  2024-09-08 19:26 [PATCH 00/16] Staging: rtl8192e: Cleanup even more camelcase variable names Tree Davies
                   ` (15 preceding siblings ...)
  2024-09-08 19:26 ` [PATCH 16/16] Staging: rtl8192e: Rename variable RxDrvInfoSize Tree Davies
@ 2024-09-08 20:44 ` Philipp Hortmann
  16 siblings, 0 replies; 18+ messages in thread
From: Philipp Hortmann @ 2024-09-08 20:44 UTC (permalink / raw)
  To: Tree Davies, gregkh, anjan; +Cc: linux-staging, linux-kernel

On 9/8/24 21:26, Tree Davies wrote:
> This series performs variable renames
> ~ Tree
> 
> Tree Davies (16):
>    Staging: rtl8192e: Rename variable pReorderEntry
>    Staging: rtl8192e: Rename variable SeqNum
>    Staging: rtl8192e: Rename variable SignalStrength
>    Staging: rtl8192e: Rename variable pFrame
>    Staging: rtl8192e: Rename variable bPacketToSelf
>    Staging: rtl8192e: Rename variable Para1
>    Staging: rtl8192e: Rename variable Para2
>    Staging: rtl8192e: Rename variable ScanOperationBackupHandler
>    Staging: rtl8192e: Rename variable Operation
>    Staging: rtl8192e: Rename variable bAssoc
>    Staging: rtl8192e: Rename variable SignalQuality
>    Staging: rtl8192e: Rename variable isEncrypt
>    Staging: rtl8192e: Rename variable nStuckCount
>    Staging: rtl8192e: Rename variable bAddNewTs
>    Staging: rtl8192e: Rename variable RxBufShift
>    Staging: rtl8192e: Rename variable RxDrvInfoSize
> 
>   .../staging/rtl8192e/rtl8192e/r8190P_def.h    |   2 +-
>   .../staging/rtl8192e/rtl8192e/r8192E_dev.c    |  40 +++---
>   .../staging/rtl8192e/rtl8192e/r8192E_phy.c    |  22 ++--
>   .../staging/rtl8192e/rtl8192e/r8192E_phy.h    |   4 +-
>   drivers/staging/rtl8192e/rtl8192e/rtl_core.c  |  14 +--
>   drivers/staging/rtl8192e/rtl8192e/rtl_wx.c    |   4 +-
>   drivers/staging/rtl8192e/rtl819x_HTProc.c     |   4 +-
>   drivers/staging/rtl8192e/rtl819x_TSProc.c     |  30 ++---
>   drivers/staging/rtl8192e/rtllib.h             |  32 ++---
>   drivers/staging/rtl8192e/rtllib_rx.c          | 116 +++++++++---------
>   drivers/staging/rtl8192e/rtllib_softmac_wx.c  |   4 +-
>   11 files changed, 136 insertions(+), 136 deletions(-)
> 


Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>

^ permalink raw reply	[flat|nested] 18+ messages in thread

end of thread, other threads:[~2024-09-08 20:44 UTC | newest]

Thread overview: 18+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-09-08 19:26 [PATCH 00/16] Staging: rtl8192e: Cleanup even more camelcase variable names Tree Davies
2024-09-08 19:26 ` [PATCH 01/16] Staging: rtl8192e: Rename variable pReorderEntry Tree Davies
2024-09-08 19:26 ` [PATCH 02/16] Staging: rtl8192e: Rename variable SeqNum Tree Davies
2024-09-08 19:26 ` [PATCH 03/16] Staging: rtl8192e: Rename variable SignalStrength Tree Davies
2024-09-08 19:26 ` [PATCH 04/16] Staging: rtl8192e: Rename variable pFrame Tree Davies
2024-09-08 19:26 ` [PATCH 05/16] Staging: rtl8192e: Rename variable bPacketToSelf Tree Davies
2024-09-08 19:26 ` [PATCH 06/16] Staging: rtl8192e: Rename variable Para1 Tree Davies
2024-09-08 19:26 ` [PATCH 07/16] Staging: rtl8192e: Rename variable Para2 Tree Davies
2024-09-08 19:26 ` [PATCH 08/16] Staging: rtl8192e: Rename variable ScanOperationBackupHandler Tree Davies
2024-09-08 19:26 ` [PATCH 09/16] Staging: rtl8192e: Rename variable Operation Tree Davies
2024-09-08 19:26 ` [PATCH 10/16] Staging: rtl8192e: Rename variable bAssoc Tree Davies
2024-09-08 19:26 ` [PATCH 11/16] Staging: rtl8192e: Rename variable SignalQuality Tree Davies
2024-09-08 19:26 ` [PATCH 12/16] Staging: rtl8192e: Rename variable isEncrypt Tree Davies
2024-09-08 19:26 ` [PATCH 13/16] Staging: rtl8192e: Rename variable nStuckCount Tree Davies
2024-09-08 19:26 ` [PATCH 14/16] Staging: rtl8192e: Rename variable bAddNewTs Tree Davies
2024-09-08 19:26 ` [PATCH 15/16] Staging: rtl8192e: Rename variable RxBufShift Tree Davies
2024-09-08 19:26 ` [PATCH 16/16] Staging: rtl8192e: Rename variable RxDrvInfoSize Tree Davies
2024-09-08 20:44 ` [PATCH 00/16] Staging: rtl8192e: Cleanup even more camelcase variable names Philipp Hortmann

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®