[PATCH] iio: adc: ad_sigma_delta: Select IIO_BUFFER_DMAENGINE and SPI_OFFLOAD

[PATCH] iio: adc: ad_sigma_delta: Select IIO_BUFFER_DMAENGINE and SPI_OFFLOAD

[Nathan Chancellor]

CONFIG_AD_SIGMA_DELTA uses several symbols that it does not explicitly
select. If no other enabled driver selects them, the build fails with
either a linker failure if the driver is built in or a modpost failure
if the driver is a module.

  ld.lld: error: undefined symbol: devm_spi_offload_rx_stream_request_dma_chan
  ld.lld: error: undefined symbol: devm_iio_dmaengine_buffer_setup_with_handle
  ld.lld: error: undefined symbol: devm_spi_offload_trigger_get
  ld.lld: error: undefined symbol: devm_spi_offload_get
  ld.lld: error: undefined symbol: spi_offload_trigger_enable
  ld.lld: error: undefined symbol: spi_offload_trigger_disable

Select the necessary Kconfig symbols to include these functions in the
build to clear up the errors.

Fixes: 219da3ea842a ("iio: adc: ad_sigma_delta: add SPI offload support")
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
---
 drivers/iio/adc/Kconfig | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
index d43edc7b0c0f..6de2abad0197 100644
--- a/drivers/iio/adc/Kconfig
+++ b/drivers/iio/adc/Kconfig
@@ -22,7 +22,9 @@ config AB8500_GPADC
 config AD_SIGMA_DELTA
 	tristate
 	select IIO_BUFFER
+	select IIO_BUFFER_DMAENGINE
 	select IIO_TRIGGERED_BUFFER
+	select SPI_OFFLOAD
 
 config AD4000
 	tristate "Analog Devices AD4000 ADC Driver"

---
base-commit: 1d71d4a318fb911ff9594d82c9fbd206e510b32f
change-id: 20250714-iio-ad_sigma_delta-fix-kconfig-selects-6e7d3c83883d

Best regards,
--  
Nathan Chancellor <nathan@kernel.org>

Re: [PATCH] iio: adc: ad_sigma_delta: Select IIO_BUFFER_DMAENGINE and SPI_OFFLOAD

[David Lechner]

On 7/14/25 1:30 PM, Nathan Chancellor wrote:
> CONFIG_AD_SIGMA_DELTA uses several symbols that it does not explicitly
> select. If no other enabled driver selects them, the build fails with
> either a linker failure if the driver is built in or a modpost failure
> if the driver is a module.
> 
>   ld.lld: error: undefined symbol: devm_spi_offload_rx_stream_request_dma_chan
>   ld.lld: error: undefined symbol: devm_iio_dmaengine_buffer_setup_with_handle
>   ld.lld: error: undefined symbol: devm_spi_offload_trigger_get
>   ld.lld: error: undefined symbol: devm_spi_offload_get
>   ld.lld: error: undefined symbol: spi_offload_trigger_enable
>   ld.lld: error: undefined symbol: spi_offload_trigger_disable
> 
> Select the necessary Kconfig symbols to include these functions in the
> build to clear up the errors.
> 
> Fixes: 219da3ea842a ("iio: adc: ad_sigma_delta: add SPI offload support")
> Signed-off-by: Nathan Chancellor <nathan@kernel.org>
> ---

Thanks for the fix.

Reviewed-by: David Lechner <dlechner@baylibre.com>

Re: [PATCH] iio: adc: ad_sigma_delta: Select IIO_BUFFER_DMAENGINE and SPI_OFFLOAD

[Jonathan Cameron]

On Tue, 15 Jul 2025 10:40:45 -0500
David Lechner <dlechner@baylibre.com> wrote:

> On 7/14/25 1:30 PM, Nathan Chancellor wrote:
> > CONFIG_AD_SIGMA_DELTA uses several symbols that it does not explicitly
> > select. If no other enabled driver selects them, the build fails with
> > either a linker failure if the driver is built in or a modpost failure
> > if the driver is a module.
> > 
> >   ld.lld: error: undefined symbol: devm_spi_offload_rx_stream_request_dma_chan
> >   ld.lld: error: undefined symbol: devm_iio_dmaengine_buffer_setup_with_handle
> >   ld.lld: error: undefined symbol: devm_spi_offload_trigger_get
> >   ld.lld: error: undefined symbol: devm_spi_offload_get
> >   ld.lld: error: undefined symbol: spi_offload_trigger_enable
> >   ld.lld: error: undefined symbol: spi_offload_trigger_disable
> > 
> > Select the necessary Kconfig symbols to include these functions in the
> > build to clear up the errors.
> > 
> > Fixes: 219da3ea842a ("iio: adc: ad_sigma_delta: add SPI offload support")
> > Signed-off-by: Nathan Chancellor <nathan@kernel.org>
> > ---  
> 
> Thanks for the fix.
> 
> Reviewed-by: David Lechner <dlechner@baylibre.com>
> 

Applied to the togreg branch of iio.git and pushed out (briefly) as
testing for 0-day to take a look.

Thanks,

Jonathan