* [PATCH] pinctrl: sunxi: a733: do not switch the mux to read IRQ lines
@ 2026-11-10 13:01 Vinicius Pedrosa
2026-11-17 17:22 ` Andre Przywara
0 siblings, 1 reply; 2+ messages in thread
From: Vinicius Pedrosa @ 2026-11-10 13:01 UTC (permalink / raw)
To: Linus Walleij, linux-gpio
Cc: Andre Przywara, Chen-Yu Tsai, Jernej Skrabec, Samuel Holland,
Bartosz Golaszewski, Enzo Adriano, Pablo Mazzini,
linux-arm-kernel, linux-sunxi, linux-kernel
The A733 description sets irq_read_needs_mux. When a GPIO used as an
interrupt is read, sunxi_pinctrl_gpio_get() then switches the pin to
input and back to SUN4I_FUNC_IRQ, which is function 6. The A733
interrupt function is 14, so after the first read the pin is left on
function 6 and its interrupt no longer fires.
On my board this breaks microSD card detection: the PF6
card-detect line is read at probe, and after that neither removal nor
insertion of the card is noticed.
The A733 data register reports the pin level while the pin is muxed
to the interrupt function, so the switch is not needed. The A523 and
D1 descriptions do not set this flag either. Drop it.
Fixes: 0535bfbfa97b ("pinctrl: sunxi: add support for the Allwinner A733")
Signed-off-by: Vinicius Pedrosa <vinicius.eduardo.pedrosa@gmail.com>
---
Tested on a Cubie A7Z with the pending A733 clock, PMIC and DT series
applied: before this change PF6 read back function 6 and card removal
and insertion were not seen; with it PF6 stays on function 14 and one
removal/insertion cycle was detected.
drivers/pinctrl/sunxi/pinctrl-sun60i-a733.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/pinctrl/sunxi/pinctrl-sun60i-a733.c b/drivers/pinctrl/sunxi/pinctrl-sun60i-a733.c
index ca82f08a3a65..456d9170c2a2 100644
--- a/drivers/pinctrl/sunxi/pinctrl-sun60i-a733.c
+++ b/drivers/pinctrl/sunxi/pinctrl-sun60i-a733.c
@@ -23,7 +23,6 @@ static const u8 a733_irq_bank_muxes[SUNXI_PINCTRL_MAX_BANKS] =
static struct sunxi_pinctrl_desc a733_pinctrl_data = {
.irq_banks = 10,
- .irq_read_needs_mux = true,
.io_bias_cfg_variant = BIAS_VOLTAGE_PIO_POW_MODE_SEL,
};
--
2.43.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] pinctrl: sunxi: a733: do not switch the mux to read IRQ lines
2026-11-10 13:01 [PATCH] pinctrl: sunxi: a733: do not switch the mux to read IRQ lines Vinicius Pedrosa
@ 2026-11-17 17:22 ` Andre Przywara
0 siblings, 0 replies; 2+ messages in thread
From: Andre Przywara @ 2026-11-17 17:22 UTC (permalink / raw)
To: Vinicius Pedrosa, Linus Walleij, linux-gpio
Cc: Chen-Yu Tsai, Jernej Skrabec, Samuel Holland,
Bartosz Golaszewski, Enzo Adriano, Pablo Mazzini,
linux-arm-kernel, linux-sunxi, linux-kernel
Hi,
On 11/10/26 14:01, Vinicius Pedrosa wrote:
> The A733 description sets irq_read_needs_mux.
ouch, I missed that, sorry about that. I removed that even explicitly
from the A523 ...
> When a GPIO used as an
> interrupt is read, sunxi_pinctrl_gpio_get() then switches the pin to
> input and back to SUN4I_FUNC_IRQ, which is function 6. The A733
> interrupt function is 14, so after the first read the pin is left on
> function 6 and its interrupt no longer fires.
>
> On my board this breaks microSD card detection: the PF6
> card-detect line is read at probe, and after that neither removal nor
> insertion of the card is noticed.
>
> The A733 data register reports the pin level while the pin is muxed
> to the interrupt function, so the switch is not needed. The A523 and
> D1 descriptions do not set this flag either. Drop it.
>
> Fixes: 0535bfbfa97b ("pinctrl: sunxi: add support for the Allwinner A733")
> Signed-off-by: Vinicius Pedrosa <vinicius.eduardo.pedrosa@gmail.com>
Reviewed-by: Andre Przywara <andre.przywara@arm.com>
Thanks,
Andre
> ---
> Tested on a Cubie A7Z with the pending A733 clock, PMIC and DT series
> applied: before this change PF6 read back function 6 and card removal
> and insertion were not seen; with it PF6 stays on function 14 and one
> removal/insertion cycle was detected.
>
> drivers/pinctrl/sunxi/pinctrl-sun60i-a733.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/pinctrl/sunxi/pinctrl-sun60i-a733.c b/drivers/pinctrl/sunxi/pinctrl-sun60i-a733.c
> index ca82f08a3a65..456d9170c2a2 100644
> --- a/drivers/pinctrl/sunxi/pinctrl-sun60i-a733.c
> +++ b/drivers/pinctrl/sunxi/pinctrl-sun60i-a733.c
> @@ -23,7 +23,6 @@ static const u8 a733_irq_bank_muxes[SUNXI_PINCTRL_MAX_BANKS] =
>
> static struct sunxi_pinctrl_desc a733_pinctrl_data = {
> .irq_banks = 10,
> - .irq_read_needs_mux = true,
> .io_bias_cfg_variant = BIAS_VOLTAGE_PIO_POW_MODE_SEL,
> };
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-11-17 17:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-10 13:01 [PATCH] pinctrl: sunxi: a733: do not switch the mux to read IRQ lines Vinicius Pedrosa
2026-11-17 17:22 ` Andre Przywara
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®