mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Haoxiang Li" <haoxiang_li2024@163.com>
To: "Andi Shyti" <andi.shyti@kernel.org>
Cc: jani.nikula@linux.intel.com, joonas.lahtinen@linux.intel.com,
	rodrigo.vivi@intel.com, tursulin@ursulin.net, airlied@gmail.com,
	simona@ffwll.ch, intel-gfx@lists.freedesktop.org,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/i915/vma: Fix a memory leak in i915_vma_pin_ww()
Date: Sat, 21 Nov 2026 15:24:38 +0800 (CST)	[thread overview]
Message-ID: <773b434.18cd.1a1fcfe2c1f.Coremail.haoxiang_li2024@163.com> (raw)
In-Reply-To: <awAYXcgE4RMg3Hqi@zenone.zhora.eu>

Hi, Andi

At 2026-11-20 17:59:12, "Andi Shyti" <andi.shyti@kernel.org> wrote:
>
>It would also be interesting to explain how this oversight
>(because that's what it is) happened in the first place.
>

I think the the merge commit added the check for i915_gem_object_get_moving_fence()
but used wrong goto label. I am not sure why this happened but i found this is not isolated
in the kernel, like adding a new function call without corresponding error handling path.

Regards,
Haoxiang Li

      reply	other threads:[~2026-11-21  7:25 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-18 15:32 Haoxiang Li
2026-11-19  8:04 ` Joonas Lahtinen
2026-11-19  9:58   ` Haoxiang Li
2026-11-19 22:04   ` Andi Shyti
2026-11-19 22:08 ` Andi Shyti
2026-11-20  9:59 ` Andi Shyti
2026-11-21  7:24   ` Haoxiang Li [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=773b434.18cd.1a1fcfe2c1f.Coremail.haoxiang_li2024@163.com \
    --to=haoxiang_li2024@163.com \
    --cc=airlied@gmail.com \
    --cc=andi.shyti@kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@linux.intel.com \
    --cc=joonas.lahtinen@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rodrigo.vivi@intel.com \
    --cc=simona@ffwll.ch \
    --cc=tursulin@ursulin.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®