mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andi Shyti <andi.shyti@kernel.org>
To: Haoxiang Li <haoxiang_li2024@163.com>
Cc: jani.nikula@linux.intel.com, joonas.lahtinen@linux.intel.com,
	 rodrigo.vivi@intel.com, tursulin@ursulin.net, airlied@gmail.com,
	simona@ffwll.ch,  intel-gfx@lists.freedesktop.org,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/i915/vma: Fix a memory leak in i915_vma_pin_ww()
Date: Fri, 20 Nov 2026 10:59:12 +0100	[thread overview]
Message-ID: <awAYXcgE4RMg3Hqi@zenone.zhora.eu> (raw)
In-Reply-To: <20261118153205.2432736-1-haoxiang_li2024@163.com>

Hi Haoxing,

On Wed, Nov 18, 2026 at 11:32:05PM +0800, Haoxiang Li wrote:
> i915_vma_pin_ww() allocates bind work before retrieving the object's
> moving fence. If the lookup fails, it jumps to err_rpm, bypassing the
> fence commit at err_fence and leaking the work allocation.
> 
> Jump to err_fence instead so the fence callbacks can release the work.

BTW, this commit description, along with the title, is too
LLM-ish. Can you please write a simpler and more descriptive
commit message?

Please do not blindly rely on your LLM for this. Write it
yourself and use the LLM only to fix the grammar.

It would also be interesting to explain how this oversight
(because that's what it is) happened in the first place.

I'll wait for v2. You can add my R-b as well.

Andi

  parent reply	other threads:[~2026-11-20  9:59 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-18 15:32 Haoxiang Li
2026-11-19  8:04 ` Joonas Lahtinen
2026-11-19  9:58   ` Haoxiang Li
2026-11-19 22:04   ` Andi Shyti
2026-11-19 22:08 ` Andi Shyti
2026-11-20  9:59 ` Andi Shyti [this message]
2026-11-21  7:24   ` Haoxiang Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=awAYXcgE4RMg3Hqi@zenone.zhora.eu \
    --to=andi.shyti@kernel.org \
    --cc=airlied@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=haoxiang_li2024@163.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@linux.intel.com \
    --cc=joonas.lahtinen@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rodrigo.vivi@intel.com \
    --cc=simona@ffwll.ch \
    --cc=tursulin@ursulin.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®