mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] ARM: at91: Replace __ASSEMBLY__ with __ASSEMBLER__
@ 2026-08-21  8:36 Thomas Huth
  2026-09-17 15:59 ` Alexandre Belloni
  2026-09-19 14:45 ` claudiu beznea
  0 siblings, 2 replies; 3+ messages in thread
From: Thomas Huth @ 2026-08-21  8:36 UTC (permalink / raw)
  To: Nicolas Ferre, Alexandre Belloni, Claudiu Beznea
  Cc: linux-arm-kernel, linux-kernel

While the GCC and Clang compilers already define __ASSEMBLER__ auto-
matically when compiling assembly code, __ASSEMBLY__ is a macro that
only gets defined by the Makefiles in the kernel. This can be very
confusing when switching between userspace and kernelspace coding, or
when dealing with uapi headers that rather should use __ASSEMBLER__
instead. Let's standardize now on the __ASSEMBLER__ macro to avoid
this confusion.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 Note: This has been split from an earlier bigger patch of mine into
       a separate patch to ease reviewing

 arch/arm/mach-at91/pm.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/mach-at91/pm.h b/arch/arm/mach-at91/pm.h
index 50c3a425d1400..2193e1ab98476 100644
--- a/arch/arm/mach-at91/pm.h
+++ b/arch/arm/mach-at91/pm.h
@@ -25,7 +25,7 @@
 #define AT91_PM_ULP1		0x03
 #define	AT91_PM_BACKUP		0x04
 
-#ifndef __ASSEMBLY__
+#ifndef __ASSEMBLER__
 struct at91_pm_data {
 	void __iomem *pmc;
 	void __iomem *ramc[2];
-- 
2.55.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ARM: at91: Replace __ASSEMBLY__ with __ASSEMBLER__
  2026-08-21  8:36 [PATCH] ARM: at91: Replace __ASSEMBLY__ with __ASSEMBLER__ Thomas Huth
@ 2026-09-17 15:59 ` Alexandre Belloni
  2026-09-19 14:45 ` claudiu beznea
  1 sibling, 0 replies; 3+ messages in thread
From: Alexandre Belloni @ 2026-09-17 15:59 UTC (permalink / raw)
  To: Thomas Huth; +Cc: Nicolas Ferre, Claudiu Beznea, linux-arm-kernel, linux-kernel

On 21/08/2026 10:36:45+0200, Thomas Huth wrote:
> While the GCC and Clang compilers already define __ASSEMBLER__ auto-
> matically when compiling assembly code, __ASSEMBLY__ is a macro that
> only gets defined by the Makefiles in the kernel. This can be very
> confusing when switching between userspace and kernelspace coding, or
> when dealing with uapi headers that rather should use __ASSEMBLER__
> instead. Let's standardize now on the __ASSEMBLER__ macro to avoid
> this confusion.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
Acked-by: Alexandre Belloni <alexandre.belloni@bootlin.com>

> ---
>  Note: This has been split from an earlier bigger patch of mine into
>        a separate patch to ease reviewing
> 
>  arch/arm/mach-at91/pm.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/mach-at91/pm.h b/arch/arm/mach-at91/pm.h
> index 50c3a425d1400..2193e1ab98476 100644
> --- a/arch/arm/mach-at91/pm.h
> +++ b/arch/arm/mach-at91/pm.h
> @@ -25,7 +25,7 @@
>  #define AT91_PM_ULP1		0x03
>  #define	AT91_PM_BACKUP		0x04
>  
> -#ifndef __ASSEMBLY__
> +#ifndef __ASSEMBLER__
>  struct at91_pm_data {
>  	void __iomem *pmc;
>  	void __iomem *ramc[2];
> -- 
> 2.55.0
> 

-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ARM: at91: Replace __ASSEMBLY__ with __ASSEMBLER__
  2026-08-21  8:36 [PATCH] ARM: at91: Replace __ASSEMBLY__ with __ASSEMBLER__ Thomas Huth
  2026-09-17 15:59 ` Alexandre Belloni
@ 2026-09-19 14:45 ` claudiu beznea
  1 sibling, 0 replies; 3+ messages in thread
From: claudiu beznea @ 2026-09-19 14:45 UTC (permalink / raw)
  To: Thomas Huth, Nicolas Ferre, Alexandre Belloni
  Cc: linux-arm-kernel, linux-kernel



On 8/21/26 11:36, Thomas Huth wrote:
> While the GCC and Clang compilers already define __ASSEMBLER__ auto-
> matically when compiling assembly code, __ASSEMBLY__ is a macro that
> only gets defined by the Makefiles in the kernel. This can be very
> confusing when switching between userspace and kernelspace coding, or
> when dealing with uapi headers that rather should use __ASSEMBLER__
> instead. Let's standardize now on the __ASSEMBLER__ macro to avoid
> this confusion.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Claudiu Beznea <claudiu.beznea@tuxon.dev>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-09-19 14:46 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-08-21  8:36 [PATCH] ARM: at91: Replace __ASSEMBLY__ with __ASSEMBLER__ Thomas Huth
2026-09-17 15:59 ` Alexandre Belloni
2026-09-19 14:45 ` claudiu beznea

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®