mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: Maxime Ripard <maxime.ripard@free-electrons.com>,
	Mark Brown <broonie@kernel.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>, Chen-Yu Tsai <wens@csie.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] regulator: core: Allow use of "status = disabled" in regulator dts nodes
Date: Wed, 27 Apr 2016 17:52:51 +0200	[thread overview]
Message-ID: <780af88d-a14a-f527-fe0a-1bb50cddc216@redhat.com> (raw)
In-Reply-To: <20160427155009.GB17159@lukather>

Hi,

On 27-04-16 17:50, Maxime Ripard wrote:
> Hi Mark,
>
> On Wed, Apr 27, 2016 at 04:01:08PM +0100, Mark Brown wrote:
>> On Wed, Apr 27, 2016 at 04:40:05PM +0200, Hans de Goede wrote:
>>
>>> Or, since regulator_of_get_init_data uses for_each_available_child_of_node
>>> which checks the "status" value we can actually already use
>>> "status=disabled" cool. So this simply already works :)
>>
>> To repeat you really shouldn't have *any* DT nodes for regulators that
>> aren't in use, there should be nothing to put in their nodes.  If
>> there's anything there that's a sign that your DT has problems.
>
> How should we deal with regulators that are on by default but are not
> used in the system then?

I think we've already solved that one, we do list them, thereby giving the
regulator core permission to touch them and then let the regulator core
turn them off for us.

Regards,

Hans

  reply	other threads:[~2016-04-27 15:52 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-27 14:03 [PATCH resend 0/2] " Hans de Goede
2016-04-27 14:03 ` [PATCH 1/2] " Hans de Goede
2016-04-27 14:24   ` Mark Brown
2016-04-27 14:31     ` Hans de Goede
2016-04-27 14:37       ` Mark Brown
2016-04-27 14:40         ` Hans de Goede
2016-04-27 15:01           ` Mark Brown
2016-04-27 15:50             ` Maxime Ripard
2016-04-27 15:52               ` Hans de Goede [this message]
2016-04-27 15:54                 ` Hans de Goede
2016-04-27 16:32                   ` Mark Brown
2016-04-27 14:03 ` [PATCH 2/2] regulator: axp20x: Handle regulator_register returning ENODEV Hans de Goede
2016-04-27 14:25   ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=780af88d-a14a-f527-fe0a-1bb50cddc216@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=broonie@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maxime.ripard@free-electrons.com \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®