From: Hannes Reinecke <hare@suse.de>
To: Daniel Wagner <dwagner@suse.de>, Keith Busch <kbusch@kernel.org>
Cc: Sagi Grimberg <sagi@grimberg.me>, Jens Axboe <axboe@fb.com>,
Christoph Hellwig <hch@lst.de>,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] nvme-tcp: Check if request has started before processing it
Date: Mon, 1 Mar 2021 14:55:30 +0100 [thread overview]
Message-ID: <786dcef5-148d-ff34-590c-804b331ac519@suse.de> (raw)
In-Reply-To: <20210301132639.n3eowtvkms2n5mog@beryllium.lan>
On 3/1/21 2:26 PM, Daniel Wagner wrote:
> On Sat, Feb 27, 2021 at 02:19:01AM +0900, Keith Busch wrote:
>> Crashing is bad, silent data corruption is worse. Is there truly no
>> defense against that? If not, why should anyone rely on this?
>
> If we receive an response for which we don't have a started request, we
> know that something is wrong. Couldn't we in just reset the connection
> in this case? We don't have to pretend nothing has happened and
> continuing normally. This would avoid a host crash and would not create
> (more) data corruption. Or I am just too naive?
>
This is actually a sensible solution.
Please send a patch for that.
Cheers,
Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), GF: Felix Imendörffer
next prev parent reply other threads:[~2021-03-01 13:57 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-12 18:17 Daniel Wagner
2021-02-12 20:58 ` Sagi Grimberg
2021-02-12 21:09 ` Keith Busch
2021-02-12 21:49 ` Sagi Grimberg
2021-02-13 8:46 ` Hannes Reinecke
2021-02-15 10:40 ` Daniel Wagner
2021-02-15 21:29 ` Sagi Grimberg
2021-02-26 12:35 ` Daniel Wagner
2021-02-26 12:54 ` Hannes Reinecke
2021-02-26 16:13 ` Keith Busch
2021-02-26 16:42 ` Hannes Reinecke
2021-02-26 17:19 ` Keith Busch
2021-03-01 13:26 ` Daniel Wagner
2021-03-01 13:55 ` Hannes Reinecke [this message]
2021-03-01 16:05 ` Keith Busch
2021-03-01 16:53 ` Hannes Reinecke
2021-03-01 20:59 ` Keith Busch
2021-03-02 7:18 ` Hannes Reinecke
2021-03-02 18:45 ` Keith Busch
2021-02-15 21:23 ` Sagi Grimberg
2021-02-16 8:51 ` Hannes Reinecke
2021-02-13 8:42 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=786dcef5-148d-ff34-590c-804b331ac519@suse.de \
--to=hare@suse.de \
--cc=axboe@fb.com \
--cc=dwagner@suse.de \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®