mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Falkowski, Maciej" <maciej.falkowski@linux.intel.com>
To: Lizhi Hou <lizhi.hou@amd.com>,
	ogabbay@kernel.org, quic_jhugo@quicinc.com,
	dri-devel@lists.freedesktop.org
Cc: linux-kernel@vger.kernel.org, max.zhen@amd.com,
	sonal.santan@amd.com, mario.limonciello@amd.com
Subject: Re: [PATCH V1] accel/amdxdna: Fix incorrect error code returned for failed chain command
Date: Tue, 3 Feb 2026 19:52:19 +0100	[thread overview]
Message-ID: <7891a7c6-bcf2-4099-b91e-5f8c99ea31a5@linux.intel.com> (raw)
In-Reply-To: <20260203184037.2751889-1-lizhi.hou@amd.com>

Reviewed-by: Maciej Falkowski <maciej.falkowski@linux.intel.com>

On 2/3/2026 7:40 PM, Lizhi Hou wrote:
> The driver currently returns an incorrect error code when a chain command
> fails. In this case, ERT_CMD_STATE_ERROR is expected to be reported for
> failed chain commands.
>
> Fixes: aac243092b70 ("accel/amdxdna: Add command execution")
> Signed-off-by: Lizhi Hou <lizhi.hou@amd.com>
> ---
>   drivers/accel/amdxdna/aie2_ctx.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/accel/amdxdna/aie2_ctx.c b/drivers/accel/amdxdna/aie2_ctx.c
> index ad5b5cd0bc81..fe8f9783a73c 100644
> --- a/drivers/accel/amdxdna/aie2_ctx.c
> +++ b/drivers/accel/amdxdna/aie2_ctx.c
> @@ -274,7 +274,7 @@ aie2_sched_cmdlist_resp_handler(void *handle, void __iomem *data, size_t size)
>   		ret = -EINVAL;
>   		goto out;
>   	}
> -	amdxdna_cmd_set_state(cmd_abo, fail_cmd_status);
> +	amdxdna_cmd_set_state(cmd_abo, ERT_CMD_STATE_ERROR);
>   
>   	if (amdxdna_cmd_get_op(cmd_abo) == ERT_CMD_CHAIN) {
>   		struct amdxdna_cmd_chain *cc = amdxdna_cmd_get_payload(cmd_abo, NULL);

  parent reply	other threads:[~2026-02-03 18:52 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-03 18:40 Lizhi Hou
2026-02-03 18:45 ` Mario Limonciello
2026-02-03 18:52 ` Falkowski, Maciej [this message]
2026-02-03 19:40   ` Lizhi Hou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7891a7c6-bcf2-4099-b91e-5f8c99ea31a5@linux.intel.com \
    --to=maciej.falkowski@linux.intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lizhi.hou@amd.com \
    --cc=mario.limonciello@amd.com \
    --cc=max.zhen@amd.com \
    --cc=ogabbay@kernel.org \
    --cc=quic_jhugo@quicinc.com \
    --cc=sonal.santan@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®