* [PATCH V1] accel/amdxdna: Fix incorrect error code returned for failed chain command
@ 2026-02-03 18:40 Lizhi Hou
2026-02-03 18:45 ` Mario Limonciello
2026-02-03 18:52 ` Falkowski, Maciej
0 siblings, 2 replies; 4+ messages in thread
From: Lizhi Hou @ 2026-02-03 18:40 UTC (permalink / raw)
To: ogabbay, quic_jhugo, dri-devel, maciej.falkowski
Cc: Lizhi Hou, linux-kernel, max.zhen, sonal.santan, mario.limonciello
The driver currently returns an incorrect error code when a chain command
fails. In this case, ERT_CMD_STATE_ERROR is expected to be reported for
failed chain commands.
Fixes: aac243092b70 ("accel/amdxdna: Add command execution")
Signed-off-by: Lizhi Hou <lizhi.hou@amd.com>
---
drivers/accel/amdxdna/aie2_ctx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/accel/amdxdna/aie2_ctx.c b/drivers/accel/amdxdna/aie2_ctx.c
index ad5b5cd0bc81..fe8f9783a73c 100644
--- a/drivers/accel/amdxdna/aie2_ctx.c
+++ b/drivers/accel/amdxdna/aie2_ctx.c
@@ -274,7 +274,7 @@ aie2_sched_cmdlist_resp_handler(void *handle, void __iomem *data, size_t size)
ret = -EINVAL;
goto out;
}
- amdxdna_cmd_set_state(cmd_abo, fail_cmd_status);
+ amdxdna_cmd_set_state(cmd_abo, ERT_CMD_STATE_ERROR);
if (amdxdna_cmd_get_op(cmd_abo) == ERT_CMD_CHAIN) {
struct amdxdna_cmd_chain *cc = amdxdna_cmd_get_payload(cmd_abo, NULL);
--
2.34.1
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH V1] accel/amdxdna: Fix incorrect error code returned for failed chain command
2026-02-03 18:40 [PATCH V1] accel/amdxdna: Fix incorrect error code returned for failed chain command Lizhi Hou
@ 2026-02-03 18:45 ` Mario Limonciello
2026-02-03 18:52 ` Falkowski, Maciej
1 sibling, 0 replies; 4+ messages in thread
From: Mario Limonciello @ 2026-02-03 18:45 UTC (permalink / raw)
To: Lizhi Hou, ogabbay, quic_jhugo, dri-devel, maciej.falkowski
Cc: linux-kernel, max.zhen, sonal.santan
On 2/3/26 12:40 PM, Lizhi Hou wrote:
> The driver currently returns an incorrect error code when a chain command
> fails. In this case, ERT_CMD_STATE_ERROR is expected to be reported for
> failed chain commands.
>
> Fixes: aac243092b70 ("accel/amdxdna: Add command execution")
> Signed-off-by: Lizhi Hou <lizhi.hou@amd.com>
Reviewed-by: Mario Limonciello (AMD) <superm1@kernel.org>
> ---
> drivers/accel/amdxdna/aie2_ctx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/accel/amdxdna/aie2_ctx.c b/drivers/accel/amdxdna/aie2_ctx.c
> index ad5b5cd0bc81..fe8f9783a73c 100644
> --- a/drivers/accel/amdxdna/aie2_ctx.c
> +++ b/drivers/accel/amdxdna/aie2_ctx.c
> @@ -274,7 +274,7 @@ aie2_sched_cmdlist_resp_handler(void *handle, void __iomem *data, size_t size)
> ret = -EINVAL;
> goto out;
> }
> - amdxdna_cmd_set_state(cmd_abo, fail_cmd_status);
> + amdxdna_cmd_set_state(cmd_abo, ERT_CMD_STATE_ERROR);
>
> if (amdxdna_cmd_get_op(cmd_abo) == ERT_CMD_CHAIN) {
> struct amdxdna_cmd_chain *cc = amdxdna_cmd_get_payload(cmd_abo, NULL);
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH V1] accel/amdxdna: Fix incorrect error code returned for failed chain command
2026-02-03 18:40 [PATCH V1] accel/amdxdna: Fix incorrect error code returned for failed chain command Lizhi Hou
2026-02-03 18:45 ` Mario Limonciello
@ 2026-02-03 18:52 ` Falkowski, Maciej
2026-02-03 19:40 ` Lizhi Hou
1 sibling, 1 reply; 4+ messages in thread
From: Falkowski, Maciej @ 2026-02-03 18:52 UTC (permalink / raw)
To: Lizhi Hou, ogabbay, quic_jhugo, dri-devel
Cc: linux-kernel, max.zhen, sonal.santan, mario.limonciello
Reviewed-by: Maciej Falkowski <maciej.falkowski@linux.intel.com>
On 2/3/2026 7:40 PM, Lizhi Hou wrote:
> The driver currently returns an incorrect error code when a chain command
> fails. In this case, ERT_CMD_STATE_ERROR is expected to be reported for
> failed chain commands.
>
> Fixes: aac243092b70 ("accel/amdxdna: Add command execution")
> Signed-off-by: Lizhi Hou <lizhi.hou@amd.com>
> ---
> drivers/accel/amdxdna/aie2_ctx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/accel/amdxdna/aie2_ctx.c b/drivers/accel/amdxdna/aie2_ctx.c
> index ad5b5cd0bc81..fe8f9783a73c 100644
> --- a/drivers/accel/amdxdna/aie2_ctx.c
> +++ b/drivers/accel/amdxdna/aie2_ctx.c
> @@ -274,7 +274,7 @@ aie2_sched_cmdlist_resp_handler(void *handle, void __iomem *data, size_t size)
> ret = -EINVAL;
> goto out;
> }
> - amdxdna_cmd_set_state(cmd_abo, fail_cmd_status);
> + amdxdna_cmd_set_state(cmd_abo, ERT_CMD_STATE_ERROR);
>
> if (amdxdna_cmd_get_op(cmd_abo) == ERT_CMD_CHAIN) {
> struct amdxdna_cmd_chain *cc = amdxdna_cmd_get_payload(cmd_abo, NULL);
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH V1] accel/amdxdna: Fix incorrect error code returned for failed chain command
2026-02-03 18:52 ` Falkowski, Maciej
@ 2026-02-03 19:40 ` Lizhi Hou
0 siblings, 0 replies; 4+ messages in thread
From: Lizhi Hou @ 2026-02-03 19:40 UTC (permalink / raw)
To: Falkowski, Maciej, ogabbay, quic_jhugo, dri-devel
Cc: linux-kernel, max.zhen, sonal.santan, mario.limonciello
Applied to drm-misc-next-fixes.
On 2/3/26 10:52, Falkowski, Maciej wrote:
> Reviewed-by: Maciej Falkowski <maciej.falkowski@linux.intel.com>
>
> On 2/3/2026 7:40 PM, Lizhi Hou wrote:
>> The driver currently returns an incorrect error code when a chain
>> command
>> fails. In this case, ERT_CMD_STATE_ERROR is expected to be reported for
>> failed chain commands.
>>
>> Fixes: aac243092b70 ("accel/amdxdna: Add command execution")
>> Signed-off-by: Lizhi Hou <lizhi.hou@amd.com>
>> ---
>> drivers/accel/amdxdna/aie2_ctx.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/accel/amdxdna/aie2_ctx.c
>> b/drivers/accel/amdxdna/aie2_ctx.c
>> index ad5b5cd0bc81..fe8f9783a73c 100644
>> --- a/drivers/accel/amdxdna/aie2_ctx.c
>> +++ b/drivers/accel/amdxdna/aie2_ctx.c
>> @@ -274,7 +274,7 @@ aie2_sched_cmdlist_resp_handler(void *handle,
>> void __iomem *data, size_t size)
>> ret = -EINVAL;
>> goto out;
>> }
>> - amdxdna_cmd_set_state(cmd_abo, fail_cmd_status);
>> + amdxdna_cmd_set_state(cmd_abo, ERT_CMD_STATE_ERROR);
>> if (amdxdna_cmd_get_op(cmd_abo) == ERT_CMD_CHAIN) {
>> struct amdxdna_cmd_chain *cc =
>> amdxdna_cmd_get_payload(cmd_abo, NULL);
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-02-03 19:40 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-02-03 18:40 [PATCH V1] accel/amdxdna: Fix incorrect error code returned for failed chain command Lizhi Hou
2026-02-03 18:45 ` Mario Limonciello
2026-02-03 18:52 ` Falkowski, Maciej
2026-02-03 19:40 ` Lizhi Hou
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®