* [PATCH] drm/tiny: print 'struct resource *' correctly
@ 2023-10-15 13:11 Yussef Dalton
2023-10-15 15:35 ` Randy Dunlap
0 siblings, 1 reply; 3+ messages in thread
From: Yussef Dalton @ 2023-10-15 13:11 UTC (permalink / raw)
To: tzimmermann; +Cc: javierm, dri-devel, linux-kernel, Yussef Dalton
Since format specifier %pr refers to a 'struct resource *', there is no
need to take the address of the 'res' variable since it is already of
type 'struct resource *'.
Signed-off-by: Yussef Dalton <yussef.dalton@gmail.com>
---
drivers/gpu/drm/tiny/ofdrm.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/tiny/ofdrm.c b/drivers/gpu/drm/tiny/ofdrm.c
index 2d999a0facde..6372ab383747 100644
--- a/drivers/gpu/drm/tiny/ofdrm.c
+++ b/drivers/gpu/drm/tiny/ofdrm.c
@@ -1208,13 +1208,13 @@ static struct ofdrm_device *ofdrm_device_create(struct drm_driver *drv,
ret = devm_aperture_acquire_from_firmware(dev, fb_pgbase, fb_pgsize);
if (ret) {
- drm_err(dev, "could not acquire memory range %pr: error %d\n", &res, ret);
+ drm_err(dev, "could not acquire memory range %pr: error %d\n", res, ret);
return ERR_PTR(ret);
}
mem = devm_request_mem_region(&pdev->dev, fb_pgbase, fb_pgsize, drv->name);
if (!mem) {
- drm_warn(dev, "could not acquire memory region %pr\n", &res);
+ drm_warn(dev, "could not acquire memory region %pr\n", res);
return ERR_PTR(-ENOMEM);
}
--
2.41.0
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] drm/tiny: print 'struct resource *' correctly
2023-10-15 13:11 [PATCH] drm/tiny: print 'struct resource *' correctly Yussef Dalton
@ 2023-10-15 15:35 ` Randy Dunlap
2023-12-16 23:12 ` Yussef Dalton
0 siblings, 1 reply; 3+ messages in thread
From: Randy Dunlap @ 2023-10-15 15:35 UTC (permalink / raw)
To: Yussef Dalton, tzimmermann; +Cc: javierm, dri-devel, linux-kernel
On 10/15/23 06:11, Yussef Dalton wrote:
> Since format specifier %pr refers to a 'struct resource *', there is no
> need to take the address of the 'res' variable since it is already of
> type 'struct resource *'.
>
> Signed-off-by: Yussef Dalton <yussef.dalton@gmail.com>
Reviewed-by: Randy Dunlap <rdunlap@infradead.org>
Thanks.
> ---
> drivers/gpu/drm/tiny/ofdrm.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/tiny/ofdrm.c b/drivers/gpu/drm/tiny/ofdrm.c
> index 2d999a0facde..6372ab383747 100644
> --- a/drivers/gpu/drm/tiny/ofdrm.c
> +++ b/drivers/gpu/drm/tiny/ofdrm.c
> @@ -1208,13 +1208,13 @@ static struct ofdrm_device *ofdrm_device_create(struct drm_driver *drv,
>
> ret = devm_aperture_acquire_from_firmware(dev, fb_pgbase, fb_pgsize);
> if (ret) {
> - drm_err(dev, "could not acquire memory range %pr: error %d\n", &res, ret);
> + drm_err(dev, "could not acquire memory range %pr: error %d\n", res, ret);
> return ERR_PTR(ret);
> }
>
> mem = devm_request_mem_region(&pdev->dev, fb_pgbase, fb_pgsize, drv->name);
> if (!mem) {
> - drm_warn(dev, "could not acquire memory region %pr\n", &res);
> + drm_warn(dev, "could not acquire memory region %pr\n", res);
> return ERR_PTR(-ENOMEM);
> }
>
--
~Randy
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] drm/tiny: print 'struct resource *' correctly
2023-10-15 15:35 ` Randy Dunlap
@ 2023-12-16 23:12 ` Yussef Dalton
0 siblings, 0 replies; 3+ messages in thread
From: Yussef Dalton @ 2023-12-16 23:12 UTC (permalink / raw)
To: Randy Dunlap, tzimmermann; +Cc: javierm, dri-devel, linux-kernel
On 10/15/23 17:35, Randy Dunlap wrote:
>
>
> On 10/15/23 06:11, Yussef Dalton wrote:
>> Since format specifier %pr refers to a 'struct resource *', there is no
>> need to take the address of the 'res' variable since it is already of
>> type 'struct resource *'.
>>
>> Signed-off-by: Yussef Dalton <yussef.dalton@gmail.com>
>
> Reviewed-by: Randy Dunlap <rdunlap@infradead.org>
>
> Thanks.
>
>> ---
>> drivers/gpu/drm/tiny/ofdrm.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/tiny/ofdrm.c b/drivers/gpu/drm/tiny/ofdrm.c
>> index 2d999a0facde..6372ab383747 100644
>> --- a/drivers/gpu/drm/tiny/ofdrm.c
>> +++ b/drivers/gpu/drm/tiny/ofdrm.c
>> @@ -1208,13 +1208,13 @@ static struct ofdrm_device *ofdrm_device_create(struct drm_driver *drv,
>>
>> ret = devm_aperture_acquire_from_firmware(dev, fb_pgbase, fb_pgsize);
>> if (ret) {
>> - drm_err(dev, "could not acquire memory range %pr: error %d\n", &res, ret);
>> + drm_err(dev, "could not acquire memory range %pr: error %d\n", res, ret);
>> return ERR_PTR(ret);
>> }
>>
>> mem = devm_request_mem_region(&pdev->dev, fb_pgbase, fb_pgsize, drv->name);
>> if (!mem) {
>> - drm_warn(dev, "could not acquire memory region %pr\n", &res);
>> + drm_warn(dev, "could not acquire memory region %pr\n", res);
>> return ERR_PTR(-ENOMEM);
>> }
>>
>
Hi,
Sorry for the bump, but is there any news on my patch?
Regards,
Yussef
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-12-16 23:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-10-15 13:11 [PATCH] drm/tiny: print 'struct resource *' correctly Yussef Dalton
2023-10-15 15:35 ` Randy Dunlap
2023-12-16 23:12 ` Yussef Dalton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®