mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Guilherme G. Piccoli" <gpiccoli@igalia.com>
To: Dave Hansen <dave.hansen@intel.com>,
	tony.luck@intel.com, tglx@linutronix.de,
	linux-kernel@vger.kernel.org, x86@kernel.org
Cc: mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com,
	hpa@zytor.com, luto@kernel.org, kernel-dev@igalia.com,
	kernel@gpiccoli.net, Fenghua Yu <fenghua.yu@intel.com>,
	Joshua Ashton <joshua@froggi.es>,
	Paul Gofman <pgofman@codeweavers.com>,
	Pavel Machek <pavel@denx.de>,
	Pierre-Loup Griffais <pgriffais@valvesoftware.com>,
	Melissa Wen <mwen@igalia.com>
Subject: Re: [PATCH] x86/split_lock: Restore warn mode (and add a new one) to avoid userspace regression
Date: Thu, 29 Sep 2022 12:30:09 -0300	[thread overview]
Message-ID: <7917fde2-a381-5404-c5ae-6ffd433f85ec@igalia.com> (raw)
In-Reply-To: <cc8d0101-73b9-b286-a7a7-e9305cdc1bd9@intel.com>

On 29/09/2022 12:17, Dave Hansen wrote:
> [...]
>> Hi Dave, thanks for your response. I really appreciated your reasoning,
>> and I think it's a good argument. In the end, adding misery would harm
>> the users that are unlikely to be able to fix (or at least, fix quickly)
>> the split lock situation, like games or legacy/proprietary code.
>>
>> I have a revert removing the misery ready and tested, let me know if I
>> should submit it.
> 
> I'm a bit of a late arrival to the split lock party, so I'm a bit
> hesitant to merge any changes immediately.
> 

OK, agree that we could indeed gather more opinions, like Thomas' and
other interested parties. But...


> How about we give it a few weeks and see if the current behavior impacts
> anyone else?  Maybe the best route will be more clear then.

...I disagree in just letting it fly for weeks with all players of God
of War 2 running modern Intel chips unable to play in 5.19+ because of
this change.

Certainly we have more games/applications that are impacted, I just
don't think we should wait on having 3 userspace breakages reported, for
example, to take an action - why should gamers live with this for an
arbitrary amount of time, until others report more issues?

Cheers,


Guilherme

  reply	other threads:[~2022-09-29 15:30 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-28 14:21 Guilherme G. Piccoli
2022-09-28 20:24 ` Luck, Tony
2022-09-28 20:50   ` Joshua Ashton
2022-09-28 20:56   ` Guilherme G. Piccoli
2022-10-06 20:15     ` Thomas Gleixner
2022-10-06 20:58       ` Guilherme G. Piccoli
2022-10-06  9:04   ` Pavel Machek
2022-10-06 15:07     ` Guilherme G. Piccoli
2022-09-28 21:50 ` Dave Hansen
2022-09-29 14:57   ` Guilherme G. Piccoli
2022-09-29 15:17     ` Dave Hansen
2022-09-29 15:30       ` Guilherme G. Piccoli [this message]
2022-09-29 16:26         ` Dave Hansen
2022-09-29 17:15           ` Guilherme G. Piccoli
2022-09-29 17:23           ` Paul Gofman
2022-09-29 15:37       ` Luck, Tony
2022-10-30 16:13         ` Lukas Straub
2022-09-29 17:17   ` Zebediah Figura

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7917fde2-a381-5404-c5ae-6ffd433f85ec@igalia.com \
    --to=gpiccoli@igalia.com \
    --cc=bp@alien8.de \
    --cc=dave.hansen@intel.com \
    --cc=dave.hansen@linux.intel.com \
    --cc=fenghua.yu@intel.com \
    --cc=hpa@zytor.com \
    --cc=joshua@froggi.es \
    --cc=kernel-dev@igalia.com \
    --cc=kernel@gpiccoli.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=mingo@redhat.com \
    --cc=mwen@igalia.com \
    --cc=pavel@denx.de \
    --cc=pgofman@codeweavers.com \
    --cc=pgriffais@valvesoftware.com \
    --cc=tglx@linutronix.de \
    --cc=tony.luck@intel.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome